[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173774#comment-14173774
]
Hudson commented on MAPREDUCE-5970:
---
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1928 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1928/])
MAPREDUCE-5970. Provide a boolean switch to enable MR-AM profiling. Contributed
by Gera Shegalov (jlowe: rev f19771a24c2f90982cf6dec35889836a6146c968)
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
* hadoop-mapreduce-project/CHANGES.txt
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Fix For: 2.6.0
>
> Attachments: MAPREDUCE-5970.v01.patch, MAPREDUCE-5970.v02.patch,
> MAPREDUCE-5970.v03.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173764#comment-14173764
]
Hudson commented on MAPREDUCE-5970:
---
FAILURE: Integrated in Hadoop-Hdfs-trunk #1903 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1903/])
MAPREDUCE-5970. Provide a boolean switch to enable MR-AM profiling. Contributed
by Gera Shegalov (jlowe: rev f19771a24c2f90982cf6dec35889836a6146c968)
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* hadoop-mapreduce-project/CHANGES.txt
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Fix For: 2.6.0
>
> Attachments: MAPREDUCE-5970.v01.patch, MAPREDUCE-5970.v02.patch,
> MAPREDUCE-5970.v03.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173644#comment-14173644
]
Hudson commented on MAPREDUCE-5970:
---
FAILURE: Integrated in Hadoop-Yarn-trunk #713 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/713/])
MAPREDUCE-5970. Provide a boolean switch to enable MR-AM profiling. Contributed
by Gera Shegalov (jlowe: rev f19771a24c2f90982cf6dec35889836a6146c968)
* hadoop-mapreduce-project/CHANGES.txt
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Fix For: 2.6.0
>
> Attachments: MAPREDUCE-5970.v01.patch, MAPREDUCE-5970.v02.patch,
> MAPREDUCE-5970.v03.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172691#comment-14172691
]
Hudson commented on MAPREDUCE-5970:
---
FAILURE: Integrated in Hadoop-trunk-Commit #6266 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6266/])
MAPREDUCE-5970. Provide a boolean switch to enable MR-AM profiling. Contributed
by Gera Shegalov (jlowe: rev f19771a24c2f90982cf6dec35889836a6146c968)
* hadoop-mapreduce-project/CHANGES.txt
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Fix For: 2.6.0
>
> Attachments: MAPREDUCE-5970.v01.patch, MAPREDUCE-5970.v02.patch,
> MAPREDUCE-5970.v03.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172662#comment-14172662
]
Jason Lowe commented on MAPREDUCE-5970:
---
+1 lgtm. Committing this.
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: MAPREDUCE-5970.v01.patch, MAPREDUCE-5970.v02.patch,
> MAPREDUCE-5970.v03.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170407#comment-14170407
]
Hadoop QA commented on MAPREDUCE-5970:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12674653/MAPREDUCE-5970.v03.patch
against trunk revision cc93e7e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4961//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4961//console
This message is automatically generated.
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: MAPREDUCE-5970.v01.patch, MAPREDUCE-5970.v02.patch,
> MAPREDUCE-5970.v03.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169691#comment-14169691
]
Jason Lowe commented on MAPREDUCE-5970:
---
Thanks for updating the patch, Gera! The audit and unit test failures are
unrelated. Patch looks good except for one minor thing which I missed in the
initial review. I noticed that tasks add their profile params as the last
parameter before the classname on the JVM command-line, but YARNRunner is
adding the AM profile options as the first thing. For consistency in case
there's overlap between the profile params and admin/user options these should
be last to match the existing behavior for tasks.
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: MAPREDUCE-5970.v01.patch, MAPREDUCE-5970.v02.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165701#comment-14165701
]
Hadoop QA commented on MAPREDUCE-5970:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12673945/MAPREDUCE-5970.v02.patch
against trunk revision 180afa2.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:
org.apache.hadoop.mapred.pipes.TestPipeApplication
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4948//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4948//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4948//console
This message is automatically generated.
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: MAPREDUCE-5970.v01.patch, MAPREDUCE-5970.v02.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161256#comment-14161256
]
Hadoop QA commented on MAPREDUCE-5970:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655973/MAPREDUCE-5970.v01.patch
against trunk revision 3affad9.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.web.TestWebHDFSXAttr
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4935//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4935//console
This message is automatically generated.
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: MAPREDUCE-5970.v01.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160941#comment-14160941
]
Jason Lowe commented on MAPREDUCE-5970:
---
Thanks for the patch, Gera! Looks good overall. It should be straightforward
to add a test case to TestYARNRunner to verify the new property behaves as
expected, see TestYARNRunner.testAMAdminCommandOpts as an example.
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: MAPREDUCE-5970.v01.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5970) Provide a boolean switch to enable MR-AM profiling
[
https://issues.apache.org/jira/browse/MAPREDUCE-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063165#comment-14063165
]
Hadoop QA commented on MAPREDUCE-5970:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655973/MAPREDUCE-5970.v01.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4739//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4739//console
This message is automatically generated.
> Provide a boolean switch to enable MR-AM profiling
> --
>
> Key: MAPREDUCE-5970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5970
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster, client
>Affects Versions: 2.4.1
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: MAPREDUCE-5970.v01.patch
>
>
> MR task profiling can be enabled with a simple switch
> {{mapreduce.task.profile=true}}. We can analogously have
> {{yarn.app.mapreduce.am.profile}} for MR-AM
--
This message was sent by Atlassian JIRA
(v6.2#6252)
