[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149276#comment-14149276 ] Hudson commented on MAPREDUCE-6078: --- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1908 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1908/]) MAPREDUCE-6078. native-task: fix gtest build on macosx (Binglin Chang) (aw: rev 6c3cebda3f3662af9db46c1bbfe22543ac18ed57) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt * hadoop-mapreduce-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest-all.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest_main.cc > native-task: fix gtest build on macosx > -- > > Key: MAPREDUCE-6078 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Binglin Chang >Assignee: Binglin Chang >Priority: Trivial > Fix For: 3.0.0 > > Attachments: MAPREDUCE-6078.v1.patch, MAPREDUCE-6078.v2.patch > > > Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 > separate gtest compile from nttest in order to surpress compile warnings, but > it forget to add addition compile flags added to nttest is also required for > gtest build, this patch fix this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149197#comment-14149197 ] Hudson commented on MAPREDUCE-6078: --- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1883 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1883/]) MAPREDUCE-6078. native-task: fix gtest build on macosx (Binglin Chang) (aw: rev 6c3cebda3f3662af9db46c1bbfe22543ac18ed57) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest-all.cc * hadoop-mapreduce-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest_main.cc > native-task: fix gtest build on macosx > -- > > Key: MAPREDUCE-6078 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Binglin Chang >Assignee: Binglin Chang >Priority: Trivial > Fix For: 3.0.0 > > Attachments: MAPREDUCE-6078.v1.patch, MAPREDUCE-6078.v2.patch > > > Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 > separate gtest compile from nttest in order to surpress compile warnings, but > it forget to add addition compile flags added to nttest is also required for > gtest build, this patch fix this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149056#comment-14149056 ] Hudson commented on MAPREDUCE-6078: --- FAILURE: Integrated in Hadoop-Yarn-trunk #692 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/692/]) MAPREDUCE-6078. native-task: fix gtest build on macosx (Binglin Chang) (aw: rev 6c3cebda3f3662af9db46c1bbfe22543ac18ed57) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h * hadoop-mapreduce-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest-all.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest_main.cc > native-task: fix gtest build on macosx > -- > > Key: MAPREDUCE-6078 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Binglin Chang >Assignee: Binglin Chang >Priority: Trivial > Fix For: 3.0.0 > > Attachments: MAPREDUCE-6078.v1.patch, MAPREDUCE-6078.v2.patch > > > Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 > separate gtest compile from nttest in order to surpress compile warnings, but > it forget to add addition compile flags added to nttest is also required for > gtest build, this patch fix this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147829#comment-14147829 ] Hudson commented on MAPREDUCE-6078: --- FAILURE: Integrated in Hadoop-trunk-Commit #6106 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6106/]) MAPREDUCE-6078. native-task: fix gtest build on macosx (Binglin Chang) (aw: rev 6c3cebda3f3662af9db46c1bbfe22543ac18ed57) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest_main.cc * hadoop-mapreduce-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest-all.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt > native-task: fix gtest build on macosx > -- > > Key: MAPREDUCE-6078 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Binglin Chang >Assignee: Binglin Chang >Priority: Trivial > Fix For: 3.0.0 > > Attachments: MAPREDUCE-6078.v1.patch, MAPREDUCE-6078.v2.patch > > > Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 > separate gtest compile from nttest in order to surpress compile warnings, but > it forget to add addition compile flags added to nttest is also required for > gtest build, this patch fix this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[
https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147381#comment-14147381
]
Hadoop QA commented on MAPREDUCE-6078:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671134/MAPREDUCE-6078.v2.patch
against trunk revision 428a766.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4913//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4913//console
This message is automatically generated.
> native-task: fix gtest build on macosx
> --
>
> Key: MAPREDUCE-6078
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
>Reporter: Binglin Chang
>Assignee: Binglin Chang
>Priority: Trivial
> Attachments: MAPREDUCE-6078.v1.patch, MAPREDUCE-6078.v2.patch
>
>
> Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977
> separate gtest compile from nttest in order to surpress compile warnings, but
> it forget to add addition compile flags added to nttest is also required for
> gtest build, this patch fix this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147312#comment-14147312 ] Allen Wittenauer commented on MAPREDUCE-6078: - Is there some reason we just don't upgrade to gtest 1.7.0 instead, which fixes this issue without any cmake craziness? > native-task: fix gtest build on macosx > -- > > Key: MAPREDUCE-6078 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Binglin Chang >Assignee: Binglin Chang >Priority: Trivial > Attachments: MAPREDUCE-6078.v1.patch > > > Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 > separate gtest compile from nttest in order to surpress compile warnings, but > it forget to add addition compile flags added to nttest is also required for > gtest build, this patch fix this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128250#comment-14128250 ] Binglin Chang commented on MAPREDUCE-6078: -- Looks like cmake 2.6(which is in currently build requirement) does require this? The doc is a little different, I guess I could verify this in a cmake2.6 env(need to get a old centos env..) But I think to careful is good. http://www.cmake.org/cmake/help/cmake2.6docs.html#command:if Evaluates the given expression. If the result is true, the commands in the THEN section are invoked. Otherwise, the commands in the else section are invoked. The elseif and else sections are optional. You may have multiple elseif clauses. **Note that the same expression must be given to if, and endif.** Long expressions can be used and the order or precedence is that the EXISTS, COMMAND, and DEFINED operators will be evaluated first. Then any EQUAL, LESS, GREATER, STRLESS, STRGREATER, STREQUAL, MATCHES will be evaluated. Then NOT operators and finally AND, OR operators will be evaluated. Possible expressions are: > native-task: fix gtest build on macosx > -- > > Key: MAPREDUCE-6078 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Binglin Chang >Assignee: Binglin Chang >Priority: Trivial > Attachments: MAPREDUCE-6078.v1.patch > > > Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 > separate gtest compile from nttest in order to surpress compile warnings, but > it forget to add addition compile flags added to nttest is also required for > gtest build, this patch fix this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[
https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128222#comment-14128222
]
Sean Zhong commented on MAPREDUCE-6078:
---
Hi binling,
The doc said the express at else and end is optional.
from http://www.cmake.org/cmake/help/v2.8.8/cmake.html#command:if
{quote}
Evaluates the given expression. If the result is true, the commands in the THEN
section are invoked. Otherwise, the commands in the else section are invoked.
The elseif and else sections are optional. You may have multiple elseif
clauses. *** Note that the expression in the else and endif clause is
optional.*** Long expressions can be used and there is a traditional order of
precedence.
{quote}
> native-task: fix gtest build on macosx
> --
>
> Key: MAPREDUCE-6078
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
>Reporter: Binglin Chang
>Assignee: Binglin Chang
>Priority: Trivial
> Attachments: MAPREDUCE-6078.v1.patch
>
>
> Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977
> separate gtest compile from nttest in order to surpress compile warnings, but
> it forget to add addition compile flags added to nttest is also required for
> gtest build, this patch fix this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127974#comment-14127974 ] Binglin Chang commented on MAPREDUCE-6078: -- What do you mean? I guess thats the weird cmake syntax. > native-task: fix gtest build on macosx > -- > > Key: MAPREDUCE-6078 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Binglin Chang >Assignee: Binglin Chang >Priority: Trivial > Attachments: MAPREDUCE-6078.v1.patch > > > Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 > separate gtest compile from nttest in order to surpress compile warnings, but > it forget to add addition compile flags added to nttest is also required for > gtest build, this patch fix this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
[ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127269#comment-14127269 ] Allen Wittenauer commented on MAPREDUCE-6078: - Um, should the conditional try to match on the same thing? > native-task: fix gtest build on macosx > -- > > Key: MAPREDUCE-6078 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Binglin Chang >Assignee: Binglin Chang >Priority: Trivial > Attachments: MAPREDUCE-6078.v1.patch > > > Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 > separate gtest compile from nttest in order to surpress compile warnings, but > it forget to add addition compile flags added to nttest is also required for > gtest build, this patch fix this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
