[jira] [Commented] (MAPREDUCE-6796) Remove unused properties from JTConfig.java
[ https://issues.apache.org/jira/browse/MAPREDUCE-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637428#comment-15637428 ] Haibo Chen commented on MAPREDUCE-6796: --- Thanks [~ajisakaa] for your reviews! > Remove unused properties from JTConfig.java > --- > > Key: MAPREDUCE-6796 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6796 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Haibo Chen > Fix For: 3.0.0-alpha2 > > Attachments: mapreduce6796.001.patch, mapreduce6796.002.patch, > mapreduce6796.002.patch > > > JobTracker-side of MAPREDUCE-6794. > There are many unused properties in JTConfig.java. Let's remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6796) Remove unused properties from JTConfig.java
[ https://issues.apache.org/jira/browse/MAPREDUCE-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637403#comment-15637403 ] Hudson commented on MAPREDUCE-6796: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10773 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10773/]) MAPREDUCE-6796. Remove unused properties from JTConfig.java. Contributed (aajisaka: rev de0132748da4d5cd4ef65571987b2581ff456084) * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/ConfigUtil.java * (edit) hadoop-tools/hadoop-sls/src/main/data/2jobs2min-rumen-jh.json * (edit) hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/server/jobtracker/JTConfig.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/resources/job_1329348432655_0001_conf.xml > Remove unused properties from JTConfig.java > --- > > Key: MAPREDUCE-6796 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6796 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Haibo Chen > Fix For: 3.0.0-alpha2 > > Attachments: mapreduce6796.001.patch, mapreduce6796.002.patch, > mapreduce6796.002.patch > > > JobTracker-side of MAPREDUCE-6794. > There are many unused properties in JTConfig.java. Let's remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6796) Remove unused properties from JTConfig.java
[ https://issues.apache.org/jira/browse/MAPREDUCE-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635806#comment-15635806 ] Akira Ajisaka commented on MAPREDUCE-6796: -- +1, the test failure looks unrelated to the patch. > Remove unused properties from JTConfig.java > --- > > Key: MAPREDUCE-6796 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6796 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Haibo Chen > Attachments: mapreduce6796.001.patch, mapreduce6796.002.patch, > mapreduce6796.002.patch > > > JobTracker-side of MAPREDUCE-6794. > There are many unused properties in JTConfig.java. Let's remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6796) Remove unused properties from JTConfig.java
[ https://issues.apache.org/jira/browse/MAPREDUCE-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630428#comment-15630428 ] Hadoop QA commented on MAPREDUCE-6796: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 15s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 6s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 33s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 10s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 56s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 2s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 54s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 54s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 32s {color} | {color:red} root: The patch generated 5 new + 401 unchanged - 122 fixed = 406 total (was 523) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 56s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s {color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 19s {color} | {color:red} hadoop-common in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 45s {color} | {color:green} hadoop-mapreduce-client-core in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 4s {color} | {color:green} hadoop-mapreduce-client-hs in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 54s {color} | {color:green} hadoop-sls in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 22s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 58m 55s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.net.TestDNS | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12836652/mapreduce6796.002.patch | | JIRA Issue | MAPREDUCE-6796 | | Optional Tests | asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle xml | | uname | Linux e74a1e8010c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 3779190 | | Default Java |
[jira] [Commented] (MAPREDUCE-6796) Remove unused properties from JTConfig.java
[ https://issues.apache.org/jira/browse/MAPREDUCE-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630018#comment-15630018 ] Haibo Chen commented on MAPREDUCE-6796: --- Agreed. I'll update the patch to accommodate the change. > Remove unused properties from JTConfig.java > --- > > Key: MAPREDUCE-6796 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6796 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Haibo Chen > Attachments: mapreduce6796.001.patch > > > JobTracker-side of MAPREDUCE-6794. > There are many unused properties in JTConfig.java. Let's remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6796) Remove unused properties from JTConfig.java
[ https://issues.apache.org/jira/browse/MAPREDUCE-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627732#comment-15627732 ] Akira Ajisaka commented on MAPREDUCE-6796: -- Looks good to me. I'm thinking we can remove the following properties * mapreduce.jobtracker.http.address * mapreduce.jobtracker.handler.count * mapreduce.jobtracker.restart.recover * mapreduce.jobtracker.taskscheduler * mapreduce.jobtracker.instrumentation * mapreduce.jobtracker.maxtasks.perjob * mapreduce.jobtracker.heartbeats.in.second * mapreduce.jobtracker.persist.jobstatus.hours * mapreduce.jobtracker.persist.jobstatus.dir * mapreduce.jobtracker.retirejobs * mapreduce.jobtracker.retiredjobs.cache.size * mapreduce.jobtracker.taskscheduler.taskalloc.capacitypad * mapreduce.jobtracker.jobinit.threads * mapreduce.jobtracker.expire.trackers.interval * mapreduce.jobtracker.taskscheduler.maxrunningtasks.perjob * mapreduce.jobtracker.hosts.filename * mapreduce.jobtracker.hosts.exclude.filename * mapreduce.jobtracker.jobhistory.lru.cache.size * mapreduce.jobtracker.jobhistory.block.size * mapreduce.jobtracker.jobhistory.completed.location * mapreduce.jobtracker.jobhistory.location * mapreduce.jobtracker.blacklist.average.threshold * mapreduce.jobtracker.tasktracker.maxblacklists * mapreduce.jobtracker.split.metainfo.maxsize * mapreduce.jobtracker.webinterface.trusted because these parameters are used only in ConfigUtil.java. What do you think? > Remove unused properties from JTConfig.java > --- > > Key: MAPREDUCE-6796 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6796 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Haibo Chen > Attachments: mapreduce6796.001.patch > > > JobTracker-side of MAPREDUCE-6794. > There are many unused properties in JTConfig.java. Let's remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6796) Remove unused properties from JTConfig.java
[ https://issues.apache.org/jira/browse/MAPREDUCE-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623026#comment-15623026 ] Haibo Chen commented on MAPREDUCE-6796: --- Checkstyle issues are unrelated. > Remove unused properties from JTConfig.java > --- > > Key: MAPREDUCE-6796 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6796 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Haibo Chen > Attachments: mapreduce6796.001.patch > > > JobTracker-side of MAPREDUCE-6794. > There are many unused properties in JTConfig.java. Let's remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6796) Remove unused properties from JTConfig.java
[ https://issues.apache.org/jira/browse/MAPREDUCE-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623015#comment-15623015 ] Hadoop QA commented on MAPREDUCE-6796: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 46s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 55s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 33s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 9s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 57s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 1s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 31s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 52s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 52s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 33s {color} | {color:red} root: The patch generated 6 new + 496 unchanged - 27 fixed = 502 total (was 523) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 56s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s {color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 31s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 12s {color} | {color:green} hadoop-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 43s {color} | {color:green} hadoop-mapreduce-client-core in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 7s {color} | {color:green} hadoop-mapreduce-client-hs in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 54s {color} | {color:green} hadoop-sls in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 56m 56s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12836185/mapreduce6796.001.patch | | JIRA Issue | MAPREDUCE-6796 | | Optional Tests | asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle xml | | uname | Linux 184d47136398 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / f646fe3 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | checkstyle |