[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979620#comment-15979620 ] Hudson commented on MAPREDUCE-6871: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11622 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11622/]) MAPREDUCE-6871. Allow users to specify racks and nodes for strict (rkanter: rev 3721cfe1fbd98c5b6aa46aefdfcf62276c28c4a4) * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java > Allow users to specify racks and nodes for strict locality for AMs > -- > > Key: MAPREDUCE-6871 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6871 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: client >Reporter: Robert Kanter >Assignee: Robert Kanter > Fix For: 2.9.0, 3.0.0-alpha3 > > Attachments: MAPREDUCE-6871.001.patch, MAPREDUCE-6871.002.patch, > MAPREDUCE-6871.003.patch, MAPREDUCE-6871.004.patch, MAPREDUCE-6871.005.patch, > MAPREDUCE-6871.005.patch > > > YARN-6050 fixed the YARN API to allow multiple {{ResourceRequest}}'s when > submitting an AM so that you can actually do rack or node locality. We > should allow MapReduce users to take advantage of this by exposing this > functionality in some way. The raw YARN API allows for a lot of flexibility > (e.g. different resources per request, etc), but we don't necessarily want to > allow the user to do too much here so they don't shoot themselves in the foot > and we don't make this overly complicated. > I propose we allow users to specify racks and nodes for strict locality. > This would allow users to restrict an MR AM to specific racks and/or nodes. > We could add a new property, > {{mapreduce.job.am.resource-request.strict.locality}}, which takes a > comma-separated list of entries like: > - {{/}} > - {{//}} > - {{}} (assumes /default-rack) > MapReduce would then use this information to create the corresponding > {{ResourceRequest}}'s. > For example, > {{mapreduce.job.am.resource-request.strict.locality=/rack1/node1}} would > create the following {{ResourceRequest}}'s: > - resourceName=ANY, relaxLocality=false, capability=> - resourceName=/rack1, relaxLocality=false, capability= > - resourceName=node1, relaxLocality=true, capability= > By default, the property would be unset, and you'd get the normal {{ANY}} > {{ResourceRequest}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979509#comment-15979509 ] Karthik Kambatla commented on MAPREDUCE-6871: - bq. it does need to be a map. If someone specifies /rack1,/rack1/node1, we'd need to update the already created request for rack1 to have the strict locality set to false. Gotcha. That makes sense. String.format does make it more readable. +1 > Allow users to specify racks and nodes for strict locality for AMs > -- > > Key: MAPREDUCE-6871 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6871 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: client >Reporter: Robert Kanter >Assignee: Robert Kanter > Attachments: MAPREDUCE-6871.001.patch, MAPREDUCE-6871.002.patch, > MAPREDUCE-6871.003.patch, MAPREDUCE-6871.004.patch, MAPREDUCE-6871.005.patch, > MAPREDUCE-6871.005.patch > > > YARN-6050 fixed the YARN API to allow multiple {{ResourceRequest}}'s when > submitting an AM so that you can actually do rack or node locality. We > should allow MapReduce users to take advantage of this by exposing this > functionality in some way. The raw YARN API allows for a lot of flexibility > (e.g. different resources per request, etc), but we don't necessarily want to > allow the user to do too much here so they don't shoot themselves in the foot > and we don't make this overly complicated. > I propose we allow users to specify racks and nodes for strict locality. > This would allow users to restrict an MR AM to specific racks and/or nodes. > We could add a new property, > {{mapreduce.job.am.resource-request.strict.locality}}, which takes a > comma-separated list of entries like: > - {{/}} > - {{//}} > - {{}} (assumes /default-rack) > MapReduce would then use this information to create the corresponding > {{ResourceRequest}}'s. > For example, > {{mapreduce.job.am.resource-request.strict.locality=/rack1/node1}} would > create the following {{ResourceRequest}}'s: > - resourceName=ANY, relaxLocality=false, capability=> - resourceName=/rack1, relaxLocality=false, capability= > - resourceName=node1, relaxLocality=true, capability= > By default, the property would be unset, and you'd get the normal {{ANY}} > {{ResourceRequest}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977310#comment-15977310 ] Robert Kanter commented on MAPREDUCE-6871: -- Test failure unrelated > Allow users to specify racks and nodes for strict locality for AMs > -- > > Key: MAPREDUCE-6871 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6871 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: client >Reporter: Robert Kanter >Assignee: Robert Kanter > Attachments: MAPREDUCE-6871.001.patch, MAPREDUCE-6871.002.patch, > MAPREDUCE-6871.003.patch, MAPREDUCE-6871.004.patch, MAPREDUCE-6871.005.patch, > MAPREDUCE-6871.005.patch > > > YARN-6050 fixed the YARN API to allow multiple {{ResourceRequest}}'s when > submitting an AM so that you can actually do rack or node locality. We > should allow MapReduce users to take advantage of this by exposing this > functionality in some way. The raw YARN API allows for a lot of flexibility > (e.g. different resources per request, etc), but we don't necessarily want to > allow the user to do too much here so they don't shoot themselves in the foot > and we don't make this overly complicated. > I propose we allow users to specify racks and nodes for strict locality. > This would allow users to restrict an MR AM to specific racks and/or nodes. > We could add a new property, > {{mapreduce.job.am.resource-request.strict.locality}}, which takes a > comma-separated list of entries like: > - {{/}} > - {{//}} > - {{}} (assumes /default-rack) > MapReduce would then use this information to create the corresponding > {{ResourceRequest}}'s. > For example, > {{mapreduce.job.am.resource-request.strict.locality=/rack1/node1}} would > create the following {{ResourceRequest}}'s: > - resourceName=ANY, relaxLocality=false, capability=> - resourceName=/rack1, relaxLocality=false, capability= > - resourceName=node1, relaxLocality=true, capability= > By default, the property would be unset, and you'd get the normal {{ANY}} > {{ResourceRequest}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977272#comment-15977272 ] Hadoop QA commented on MAPREDUCE-6871: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 45s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 58s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 34s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 53s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 34s {color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 48s {color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 3 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 40s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 31s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 31s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 46s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 47s {color} | {color:green} hadoop-mapreduce-client-core in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 110m 9s {color} | {color:red} hadoop-mapreduce-client-jobclient in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 27s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 139m 18s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.mapred.TestLocalMRNotification | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:0ac17dc | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12864311/MAPREDUCE-6871.005.patch | | JIRA Issue | MAPREDUCE-6871 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 797fc76746c3 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / c0cf11e | | Default Java | 1.8.0_121 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6962/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html | | unit |
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975951#comment-15975951 ] Hadoop QA commented on MAPREDUCE-6871: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 1s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 54s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 0s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 33s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 26s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 48s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 34s {color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 54s {color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 3 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 6s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 45s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 32s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 42s {color} | {color:green} hadoop-mapreduce-client-core in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 101m 40s {color} | {color:green} hadoop-mapreduce-client-jobclient in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 40s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 132m 59s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:0ac17dc | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12864170/MAPREDUCE-6871.004.patch | | JIRA Issue | MAPREDUCE-6871 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 8fdccacbb863 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / c154935 | | Default Java | 1.8.0_121 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6961/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html | | Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6961/testReport/ | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972005#comment-15972005 ] Karthik Kambatla commented on MAPREDUCE-6871: - Thanks for updating the patch, Robert. Few minor comments: # For the config, the resource-request part might not be adding much information. How about we call it just mapreduce.job.am.strict-locality and update the corresponding field in MRJobConfig as well? Sorry for not pointing it out in my previous review. # YARNRunner.generateResourceRequests: ## Let us wrap the debug log in a isDebugEnabled guard. {code}LOG.debug("AppMaster capability = " + capability);{code} ## rackRequests need not be a map. It could be a set as well. # In the tests, verifyResourceRequestLocality sets node label expression multiple times. Is that required? > Allow users to specify racks and nodes for strict locality for AMs > -- > > Key: MAPREDUCE-6871 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6871 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: client >Reporter: Robert Kanter >Assignee: Robert Kanter > Attachments: MAPREDUCE-6871.001.patch, MAPREDUCE-6871.002.patch, > MAPREDUCE-6871.003.patch > > > YARN-6050 fixed the YARN API to allow multiple {{ResourceRequest}}'s when > submitting an AM so that you can actually do rack or node locality. We > should allow MapReduce users to take advantage of this by exposing this > functionality in some way. The raw YARN API allows for a lot of flexibility > (e.g. different resources per request, etc), but we don't necessarily want to > allow the user to do too much here so they don't shoot themselves in the foot > and we don't make this overly complicated. > I propose we allow users to specify racks and nodes for strict locality. > This would allow users to restrict an MR AM to specific racks and/or nodes. > We could add a new property, > {{mapreduce.job.am.resource-request.strict.locality}}, which takes a > comma-separated list of entries like: > - {{/}} > - {{//}} > - {{}} (assumes /default-rack) > MapReduce would then use this information to create the corresponding > {{ResourceRequest}}'s. > For example, > {{mapreduce.job.am.resource-request.strict.locality=/rack1/node1}} would > create the following {{ResourceRequest}}'s: > - resourceName=ANY, relaxLocality=false, capability=> - resourceName=/rack1, relaxLocality=false, capability= > - resourceName=node1, relaxLocality=true, capability= > By default, the property would be unset, and you'd get the normal {{ANY}} > {{ResourceRequest}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967103#comment-15967103 ] Hadoop QA commented on MAPREDUCE-6871: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 45s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 54s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 9s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 8s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 40s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 46s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 10s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 38s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 1s {color} | {color:green} hadoop-mapreduce-client-core in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 104m 1s {color} | {color:green} hadoop-mapreduce-client-jobclient in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 29s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 141m 24s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:612578f | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12863188/MAPREDUCE-6871.003.patch | | JIRA Issue | MAPREDUCE-6871 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 5271f9ca5c19 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 0cab572 | | Default Java | 1.8.0_121 | | findbugs | v3.0.0 | | Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6954/testReport/ | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client | | Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6954/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Allow
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961682#comment-15961682 ] Karthik Kambatla commented on MAPREDUCE-6871: - Thanks for working on this, Robert. The patch looks mostly good. The tests in particular are quite comprehensive. Few minor comments: # findResourceRequest, in its current form, iterates through all ResourceRequests. Instead, would it be more efficient to track the set of racks that have been included so far? # Can we move the AM container's ResourceRequest construction into its own method for better readability? > Allow users to specify racks and nodes for strict locality for AMs > -- > > Key: MAPREDUCE-6871 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6871 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: client >Reporter: Robert Kanter >Assignee: Robert Kanter > Attachments: MAPREDUCE-6871.001.patch, MAPREDUCE-6871.002.patch > > > YARN-6050 fixed the YARN API to allow multiple {{ResourceRequest}}'s when > submitting an AM so that you can actually do rack or node locality. We > should allow MapReduce users to take advantage of this by exposing this > functionality in some way. The raw YARN API allows for a lot of flexibility > (e.g. different resources per request, etc), but we don't necessarily want to > allow the user to do too much here so they don't shoot themselves in the foot > and we don't make this overly complicated. > I propose we allow users to specify racks and nodes for strict locality. > This would allow users to restrict an MR AM to specific racks and/or nodes. > We could add a new property, > {{mapreduce.job.am.resource-request.strict.locality}}, which takes a > comma-separated list of entries like: > - {{/}} > - {{//}} > - {{}} (assumes /default-rack) > MapReduce would then use this information to create the corresponding > {{ResourceRequest}}'s. > For example, > {{mapreduce.job.am.resource-request.strict.locality=/rack1/node1}} would > create the following {{ResourceRequest}}'s: > - resourceName=ANY, relaxLocality=false, capability=> - resourceName=/rack1, relaxLocality=false, capability= > - resourceName=node1, relaxLocality=true, capability= > By default, the property would be unset, and you'd get the normal {{ANY}} > {{ResourceRequest}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960133#comment-15960133 ] Hadoop QA commented on MAPREDUCE-6871: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 28s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 59s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m 3s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 28s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 11s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 37s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 39s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 59s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 54s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 22s {color} | {color:green} hadoop-mapreduce-client-core in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 108m 19s {color} | {color:green} hadoop-mapreduce-client-jobclient in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 31s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 148m 29s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:a9ad5d6 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12862389/MAPREDUCE-6871.002.patch | | JIRA Issue | MAPREDUCE-6871 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux a9c964f291ee 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / a49fac5 | | Default Java | 1.8.0_121 | | findbugs | v3.0.0 | | Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6949/testReport/ | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client | | Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6949/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. >
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957499#comment-15957499 ] Haibo Chen commented on MAPREDUCE-6871: --- Thanks [~rkanter] for the patch! A few comments 1) Do you think having regular expression for the configuration is more robust? rack1/node2 will be treated as a node name with current implementation. If this will cause application failure later, better we catch it early before submission. 2) Maybe rename mapreduce.job.am.resource-request.strict.locality to mapreduce.job.am.resource-request-strict-locality ? 3) The different test cases can be broken into different test methods individually, so that one test case failure won't disguise failures in following test cases. > Allow users to specify racks and nodes for strict locality for AMs > -- > > Key: MAPREDUCE-6871 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6871 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: client >Reporter: Robert Kanter >Assignee: Robert Kanter > Attachments: MAPREDUCE-6871.001.patch > > > YARN-6050 fixed the YARN API to allow multiple {{ResourceRequest}}'s when > submitting an AM so that you can actually do rack or node locality. We > should allow MapReduce users to take advantage of this by exposing this > functionality in some way. The raw YARN API allows for a lot of flexibility > (e.g. different resources per request, etc), but we don't necessarily want to > allow the user to do too much here so they don't shoot themselves in the foot > and we don't make this overly complicated. > I propose we allow users to specify racks and nodes for strict locality. > This would allow users to restrict an MR AM to specific racks and/or nodes. > We could add a new property, > {{mapreduce.job.am.resource-request.strict.locality}}, which takes a > comma-separated list of entries like: > - {{/}} > - {{//}} > - {{}} (assumes /default-rack) > MapReduce would then use this information to create the corresponding > {{ResourceRequest}}'s. > For example, > {{mapreduce.job.am.resource-request.strict.locality=/rack1/node1}} would > create the following {{ResourceRequest}}'s: > - resourceName=ANY, relaxLocality=false, capability=> - resourceName=/rack1, relaxLocality=false, capability= > - resourceName=node1, relaxLocality=true, capability= > By default, the property would be unset, and you'd get the normal {{ANY}} > {{ResourceRequest}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6871) Allow users to specify racks and nodes for strict locality for AMs
[ https://issues.apache.org/jira/browse/MAPREDUCE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947850#comment-15947850 ] Hadoop QA commented on MAPREDUCE-6871: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 51s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m 25s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 20s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 18s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 35s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 34s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 32s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 59s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 33s {color} | {color:red} hadoop-mapreduce-client-core in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 21s {color} | {color:green} hadoop-mapreduce-client-core in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 114m 45s {color} | {color:green} hadoop-mapreduce-client-jobclient in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 25s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 153m 28s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:a9ad5d6 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12861073/MAPREDUCE-6871.001.patch | | JIRA Issue | MAPREDUCE-6871 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 64f5fe4d508b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 15e3873 | | Default Java | 1.8.0_121 | | findbugs | v3.0.0 | | javadoc | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6934/artifact/patchprocess/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt | | Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6934/testReport/ | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: