[jira] [Commented] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205231#comment-16205231 ] ASF GitHub Bot commented on MAPREDUCE-6973: --- GitHub user mgarnara reopened a pull request: https://github.com/apache/hadoop/pull/280 MAPREDUCE-6973. Appropriate comments on creating _SUCCESS file. @jlowe You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgarnara/hadoop mgarnara-MAPREDUCE-6973-corrected-references-of-_SUCCESS-file Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/280.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #280 commit 94609353e04d2b7a1b56ed4c7d3fb7dd62eb2d18 Author: Mehul Garnara Date: 2017-10-02T17:00:36Z fix(mapreduce): approprite comments on creating _SUCCESS file > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205228#comment-16205228 ] ASF GitHub Bot commented on MAPREDUCE-6973: --- Github user mgarnara commented on the issue: https://github.com/apache/hadoop/pull/280 Since Jenkins isn't picking up and commenting on the pull request, reopening again > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205229#comment-16205229 ] ASF GitHub Bot commented on MAPREDUCE-6973: --- Github user mgarnara closed the pull request at: https://github.com/apache/hadoop/pull/280 > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190261#comment-16190261 ] Jason Lowe commented on MAPREDUCE-6973: --- Hmm Jenkins isn't picking up and commenting on the pull request. I'd recommend just attaching a patch file here and moving this JIRA to Patch Available. > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188591#comment-16188591 ] Mehul Garnara (MG) commented on MAPREDUCE-6973: --- Yes going through it and trying creating my local dev env by following BUILDING.txt, couple of hurdles in between mostly those are related on proxy due to executing via my company network. Able to create docker image and virtual box i.e. hadoopdev. Working to figuring out few errors occurred while running ./start-build-env.sh on my Mac. Thanks! > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188505#comment-16188505 ] Jason Lowe commented on MAPREDUCE-6973: --- No problem! Be sure to check out the [How to Contribute|https://wiki.apache.org/hadoop/HowToContribute] page if you have not already. > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188496#comment-16188496 ] Mehul Garnara (MG) commented on MAPREDUCE-6973: --- [~jlowe] - thank you for updating this issue and assign to me. I'm going to open a PR today and would tag you for your information/reference. Again, thank you helping here and giving opportunity to start contributing :) > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
