[jira] [Resolved] (MAPREDUCE-6286) A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly.

2017-07-31 Thread Junping Du (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Junping Du resolved MAPREDUCE-6286.
---
Resolution: Won't Fix

MAPREDUCE-5875 is revert, so patch here is not needed. reopen and resolve it as 
won't fix.

> A typo in HistoryViewer makes some code useless, which causes counter limits 
> are not reset correctly.
> -
>
> Key: MAPREDUCE-6286
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6286
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: client
>Affects Versions: 2.6.0
>Reporter: zhihai xu
>Assignee: zhihai xu
> Fix For: 2.9.0, 3.0.0-alpha1
>
> Attachments: MAPREDUCE-6286.000.patch
>
>
> A typo in HistoryViewer makes some code useless and it causes counter limits 
> are not reset correctly.
> The typo is
> Limits.reset(conf);
> We should use jobConf instead of conf.
> With the typo, the following code becomes useless:
> {code}
>   final Path jobConfPath = new Path(jobFile.getParent(),  jobDetails[0]
>   + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
>   final Configuration jobConf = new Configuration(conf);
> jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
> {code}
> The code wants to load the configuration from the Job configuration file and 
> reset the Limits based on the new configuration loaded from the Job 
> configuration file. But with the typo, the Limits are reset with the old 
> configuration.
> So this typo is apparent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Resolved] (MAPREDUCE-6286) A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly.

2016-04-27 Thread Harsh J (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J resolved MAPREDUCE-6286.

Resolution: Fixed

Uh sorry, the commit message timeline is confusing on this. This is indeed 
present in the trunk and branch-2.8/branch-2, was only reverted in branch-2.7. 
My bad - sorry for the noise - the addendum vs. 2.7 notes confused me :(

Resetting to earlier state.

> A typo in HistoryViewer makes some code useless, which causes counter limits 
> are not reset correctly.
> -
>
> Key: MAPREDUCE-6286
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6286
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: client
>Affects Versions: 2.6.0
>Reporter: zhihai xu
>Assignee: zhihai xu
> Fix For: 2.8.0
>
> Attachments: MAPREDUCE-6286.000.patch
>
>
> A typo in HistoryViewer makes some code useless and it causes counter limits 
> are not reset correctly.
> The typo is
> Limits.reset(conf);
> We should use jobConf instead of conf.
> With the typo, the following code becomes useless:
> {code}
>   final Path jobConfPath = new Path(jobFile.getParent(),  jobDetails[0]
>   + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
>   final Configuration jobConf = new Configuration(conf);
> jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
> {code}
> The code wants to load the configuration from the Job configuration file and 
> reset the Limits based on the new configuration loaded from the Job 
> configuration file. But with the typo, the Limits are reset with the old 
> configuration.
> So this typo is apparent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)