[jira] [Updated] (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun C Murthy updated MAPREDUCE-2193: - Status: Open (was: Patch Available) Sorry to come in late, the patch has gone stale. Can you please rebase? Thanks. 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Priority: Blocker Fix For: 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff, mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r6.diff, mapreduce.trunk.findbugs.r7.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated MAPREDUCE-2193: --- Attachment: mapreduce.trunk.findbugs.r7.diff Rebased patch with OK_FINDBUGS_WARNINGS bumped to 2 to cover the JobInProgress's IS2 warnings that are non-ignorable. (Same report as last one) 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Priority: Blocker Fix For: 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff, mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r6.diff, mapreduce.trunk.findbugs.r7.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated MAPREDUCE-2193: --- Status: Patch Available (was: In Progress) 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Priority: Blocker Fix For: 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff, mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r6.diff, mapreduce.trunk.findbugs.r7.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Daley updated MAPREDUCE-2193: --- Fix Version/s: (was: 0.22.0) Not a blocker for 0.22. Removing from 0.22. 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff, mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r6.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Attachment: mapreduce.trunk.findbugs.r5.diff Oops, looks like my diff failed to contain the Holder file. Forgot to add it to svn before diff. Uploading a proper patch and setting to 'In Progress'. 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff, mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r5.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Status: In Progress (was: Patch Available) 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff, mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r5.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Attachment: mapreduce.trunk.findbugs.r6.diff 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff, mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r5.diff, mapreduce.trunk.findbugs.r6.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[
https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J Chouraria updated MAPREDUCE-2193:
-
Attachment: mapreduce.trunk.findbugs.r5.diff
New patch (still leaves a couple of sync warnings left, as introduced by
MAPREDUCE-2026).
@Chris - I've made the changes you suggested. Although, even with those
changes, is it required for {{getTasks(TaskType)}} to be sync'd? I've sync'd it
in this patch, but let me know if it can be removed, and the warning ignored
(possibly inaccurate, as admitted by Findbugs).
@Todd - Shall I open a new JIRA for other places HolderT may be used at?
The additional two findbug warnings generated by the issue pointed by Priyo
(MAPREDUCE-2026 - Interesting why it does not show up in the test-patch?) needs
to be ignored/re-reviewed as well (for {{getMapCounters}}/{{getReduceCounters}}
are left synchronized - why?).
13 Findbugs warnings on trunk and branch-0.22
-
Key: MAPREDUCE-2193
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193
Project: Hadoop Map/Reduce
Issue Type: Bug
Affects Versions: 0.22.0, 0.23.0
Reporter: Nigel Daley
Assignee: Harsh J Chouraria
Priority: Blocker
Fix For: 0.22.0, 0.23.0
Attachments: findbugsWarnings.html, hadoop-findbugs-report.html,
hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff,
mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff,
mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff
There are 13 findbugs warnings on trunk. See attached html file. These must
be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS
property in src/test/test-patch.properties should also be set to 0 in the
patch that fixes this issue.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Attachment: hadoop-findbugs-report.html Fresh Findbugs report for previous patch. 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff, mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[
https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J Chouraria updated MAPREDUCE-2193:
-
Attachment: mapreduce.trunk.findbugs.r4.diff
Another new patch (Rev 4.)
* Moved Holder from o.a.h.mapreduce to o.a.h.mapreduce.util
* Added the forgotten-about ASF license and API interface annotations, as per
Todd's comments
ant clean findbugs -Dfindbugs.home=/opt/findbugs - 0, as before.
Waiting for another review for the 'synchronized' change made in the {{TIP[]
JobInProgress::getTasks(TaskType)}} method.
13 Findbugs warnings on trunk and branch-0.22
-
Key: MAPREDUCE-2193
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193
Project: Hadoop Map/Reduce
Issue Type: Bug
Affects Versions: 0.22.0, 0.23.0
Reporter: Nigel Daley
Assignee: Harsh J Chouraria
Priority: Blocker
Fix For: 0.22.0, 0.23.0
Attachments: findbugsWarnings.html, hadoop-findbugs-report.html,
hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff,
mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff,
mapreduce.trunk.findbugs.r4.diff
There are 13 findbugs warnings on trunk. See attached html file. These must
be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS
property in src/test/test-patch.properties should also be set to 0 in the
patch that fixes this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Status: In Progress (was: Patch Available) Thanks for the review Todd. I've made the getTasks synchronized now and also have removed the ignores. About the Holder, must I write the class myself? And if it is going to be used in other places as well, where must I put it (package/project wise)? 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Status: Patch Available (was: In Progress) 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Attachment: mapreduce.trunk.findbugs.r3.diff New patch that tries to resolve Todd's additional comments. * Adds a new class 'HolderT' added in o.a.h.mapreduce package, for use right now only in Localizer.java. Re-added synchronized block in Localizer.java. * Removed ignores on maps/reduces/etc TIP arrays in JobInProgress.java and made the getTasks() method synchronized. Checkstyle passes on Holder.java with 0 errors/warnings (via the report of `ant checkstyle`). Findbugs reports 0 errors, like the previous attachment. 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Attachment: hadoop-findbugs-report.html mapreduce.trunk.findbugs.r2.diff I had a look at JIP's use of those TIP arrays again, and I guess that it is alright to ignore non sync access to them via getTasks() as getTasks() is thread safe. But I may be wrong, so please review. Marking as PA. 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Tags: findbugs Status: Patch Available (was: Open) 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Assignee: Harsh J Chouraria Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J Chouraria updated MAPREDUCE-2193: - Attachment: hadoop-findbugs-report.html mapreduce.trunk.findbugs.r1.diff Attempting this cause it looks like an interesting task for a newcomer. Attached a patch that filters and fixes some of these warnings. [Also attached the resultant warning HTML page]. Please review :) Regarding the four remaining IS2_INCONSISTENT_SYNC warnings, I'm unable to think of a proper way to exclude them (as I think getTasks() doesn't require to be synchronized). I tried performing a Match on the Method, but findbugs is only interested in the Field as a whole. Ignoring the Fields (maps, reduces, setup, cleanup) for the entire JIP class doesn't look like a good idea to me. Any tips on how to resolve this filtering? 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22
[ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Daley updated MAPREDUCE-2193: --- Attachment: findbugsWarnings.html 13 Findbugs warnings on trunk and branch-0.22 - Key: MAPREDUCE-2193 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 0.22.0, 0.23.0 Reporter: Nigel Daley Priority: Blocker Fix For: 0.22.0, 0.23.0 Attachments: findbugsWarnings.html There are 13 findbugs warnings on trunk. See attached html file. These must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
