[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junping Du updated MAPREDUCE-2631:
--
Fix Version/s: (was: 2.9.0)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Fix For: 2.8.0, 3.0.0-alpha2
>
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.0005.patch, MAPREDUCE-2631.0006.patch,
> MAPREDUCE-2631.0007.patch, MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated MAPREDUCE-2631:
-
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 3.0.0-alpha2
2.9.0
2.8.0
Status: Resolved (was: Patch Available)
Thanks for the contributions [~sunilg] and review from [~raviprak], [~tlipcon].
Committed it trunk, branch-2 and branch-2.8
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Fix For: 2.8.0, 2.9.0, 3.0.0-alpha2
>
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.0005.patch, MAPREDUCE-2631.0006.patch,
> MAPREDUCE-2631.0007.patch, MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Attachment: MAPREDUCE-2631.0007.patch
Yes. Updating patch for same.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.0005.patch, MAPREDUCE-2631.0006.patch,
> MAPREDUCE-2631.0007.patch, MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Status: Patch Available (was: Open)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.0005.patch, MAPREDUCE-2631.0006.patch,
> MAPREDUCE-2631.0007.patch, MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Attachment: MAPREDUCE-2631.0006.patch
As per the offline discussion with [~naganarasimha...@apache.org], *file* or
*out* need not have to be set null. So we can avoid {{isClosed}}. We will get
an IOException since the streams are already closed. I think in such cases,
caller can get exception rather than suppressing the same.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.0005.patch, MAPREDUCE-2631.0006.patch,
> MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Attachment: MAPREDUCE-2631.0005.patch
Rebasing patch.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.0005.patch, MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated MAPREDUCE-2631:
-
Status: Open (was: Patch Available)
Hi [~sunilg],
I am fine with the approach, can you rebase the patch as its not getting
applied
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated MAPREDUCE-2631:
-
Assignee: Sunil G (was: Naganarasimha G R)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Attachment: 0004-MAPREDUCE-2631.patch
Hi [~devaraj.k]
Updating a patch after correcting few warnings.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, 0004-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Attachment: 0003-MAPREDUCE-2631.patch
Uploading patch after correcting test failures.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Status: Patch Available (was: Open)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> 0003-MAPREDUCE-2631.patch, MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devaraj K updated MAPREDUCE-2631:
-
Status: Open (was: Patch Available)
Cancelling patch to fix the test failure.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devaraj K updated MAPREDUCE-2631:
-
Labels: (was: BB2015-05-TBR)
Component/s: (was: jobtracker)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Attachment: 0002-MAPREDUCE-2631.patch
Uploading same patch again to check Test failures.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Labels: BB2015-05-TBR
> Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch,
> MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Status: Patch Available (was: Open)
Kicking jenkins again.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Labels: BB2015-05-TBR
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.02.patch,
> MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch,
> MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Status: Open (was: Patch Available)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Labels: BB2015-05-TBR
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.02.patch,
> MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch,
> MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Prakash updated MAPREDUCE-2631:
Labels: BB2015-05-TBR (was: BB2015-05-RFC)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Labels: BB2015-05-TBR
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.02.patch,
> MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch,
> MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Prakash updated MAPREDUCE-2631:
Labels: BB2015-05-RFC (was: )
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Labels: BB2015-05-RFC
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.02.patch,
> MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch,
> MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Prakash updated MAPREDUCE-2631:
Attachment: MAPREDUCE-2631.02.patch
Thanks for the patch Sunil. In BinaryProtocol.close(), if out.close() throws an
exception, file will never be set to null right?
Uploading a new patch which does this:
{code}
public void close() throws IOException {
try {
flush();
} finally {
IOUtils.closeStream(file);
file = null;
IOUtils.closeStream(file);
out = null;
}
}
{code}
Similarly for IFileOutputStream . Could you please review it?
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.02.patch,
> MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch,
> MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Prakash updated MAPREDUCE-2631:
Labels: (was: BB2015-05-RFC)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Summary: Potential resource leaks in BinaryProtocol$TeeOutputStream.java
(was: Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
TaskLogServlet.java)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Labels: BB2015-05-RFC
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Description:
{code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
public void close() throws IOException {
flush();
file.close();
out.close();
}
{code}
In the above code, if the file.close() throws any exception out will not be
closed.
was:
{code:title=TaskLogServlet.java|borderStyle=solid}
private void printTaskLog(HttpServletResponse response,
OutputStream out, TaskAttemptID taskId,
long start, long end, boolean plainText,
TaskLog.LogName filter, boolean isCleanup)
throws IOException {
if (!plainText) {
out.write(("" + filter + " logs\n" +
"\n").getBytes());
}
try {
InputStream taskLogReader =
new TaskLog.Reader(taskId, filter, start, end, isCleanup);
byte[] b = new byte[65536];
int result;
while (true) {
result = taskLogReader.read(b);
if (result > 0) {
if (plainText) {
out.write(b, 0, result);
} else {
HtmlQuoting.quoteHtmlChars(out, b, 0, result);
}
} else {
break;
}
}
taskLogReader.close();
{code}
In the above code, if any exception thrown while reading
(taskLogReader.read(b)), taskLogReader will not be closed.
{code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
public void close() throws IOException {
flush();
file.close();
out.close();
}
{code}
In the above code, if the file.close() throws any exception out will not be
closed.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Labels: BB2015-05-RFC
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Assignee: Sunil G (was: Ravi Teja Ch N V)
Labels: BB2015-05-RFC (was: )
Status: Patch Available (was: Open)
Submitting the change to kick jenkins.
[~raviteja] pls reassign if you are interested still.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Sunil G
> Labels: BB2015-05-RFC
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated MAPREDUCE-2631:
---
Attachment: 0001-MAPREDUCE-2631.patch
Rebasing patch against trunk. Patch still looks valid.
Activity done as part of bugbash0515.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Ravi Teja Ch N V
> Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.1.patch,
> MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated MAPREDUCE-2631:
Status: Open (was: Patch Available)
Cancelling patch as it no longer applies.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Ravi Teja Ch N V
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated MAPREDUCE-2631:
Status: Patch Available (was: Open)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Ravi Teja Ch N V
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated MAPREDUCE-2631:
Status: Open (was: Patch Available)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Ravi Teja Ch N V
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated MAPREDUCE-2631:
Fix Version/s: (was: 0.24.0)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
>Assignee: Ravi Teja Ch N V
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Attachment: MAPREDUCE-2631.3.patch
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Status: Patch Available (was: Open)
Rebased the patch to the latest version.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun C Murthy updated MAPREDUCE-2631:
-
Status: Open (was: Patch Available)
Sorry, the patch has gone stale. Can you please rebase? Thanks.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Status: Patch Available (was: Open)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Attachment: MAPREDUCE-2631.2.patch
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch,
> MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated MAPREDUCE-2631:
---
Status: Open (was: Patch Available)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Status: Open (was: Patch Available)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Status: Patch Available (was: Open)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Attachment: MAPREDUCE-2631.1.patch
Resolved the release audit comments.
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.1.patch, MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Fix Version/s: 0.23.0
Status: Patch Available (was: Open)
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
[
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Teja Ch N V updated MAPREDUCE-2631:
Attachment: MAPREDUCE-2631.patch
> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and
> TaskLogServlet.java
> ---
>
> Key: MAPREDUCE-2631
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
>Affects Versions: 0.23.0
>Reporter: Ravi Teja Ch N V
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
> OutputStream out, TaskAttemptID taskId,
> long start, long end, boolean plainText,
> TaskLog.LogName filter, boolean isCleanup)
> throws IOException {
> if (!plainText) {
> out.write(("" + filter + " logs\n" +
> "\n").getBytes());
> }
> try {
> InputStream taskLogReader =
> new TaskLog.Reader(taskId, filter, start, end, isCleanup);
> byte[] b = new byte[65536];
> int result;
> while (true) {
> result = taskLogReader.read(b);
> if (result > 0) {
> if (plainText) {
> out.write(b, 0, result);
> } else {
> HtmlQuoting.quoteHtmlChars(out, b, 0, result);
> }
> } else {
> break;
> }
> }
> taskLogReader.close();
> {code}
> In the above code, if any exception thrown while reading
> (taskLogReader.read(b)), taskLogReader will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
> flush();
> file.close();
> out.close();
> }
> {code}
> In the above code, if the file.close() throws any exception out will not be
> closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
