[jira] [Updated] (MAPREDUCE-2788) Normalize requests in FifoScheduler.allocate to prevent NPEs later
[ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun C Murthy updated MAPREDUCE-2788: - Fix Version/s: 0.23.0 > Normalize requests in FifoScheduler.allocate to prevent NPEs later > -- > > Key: MAPREDUCE-2788 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Reporter: Ahmed Radwan >Assignee: Ahmed Radwan > Fix For: 0.23.0 > > Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, > MAPREDUCE-2788_rev3.patch, MAPREDUCE-2788_rev4.patch, > MAPREDUCE-2788_rev5.patch > > > The assignContainer() method in > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue > can cause the scheduler to crash if the ResourseRequest capability memory == > 0 (divide by zero). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2788) Normalize requests in FifoScheduler.allocate to prevent NPEs later
[ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun C Murthy updated MAPREDUCE-2788: - Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. Thanks Ahmed! > Normalize requests in FifoScheduler.allocate to prevent NPEs later > -- > > Key: MAPREDUCE-2788 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Reporter: Ahmed Radwan >Assignee: Ahmed Radwan > Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, > MAPREDUCE-2788_rev3.patch, MAPREDUCE-2788_rev4.patch, > MAPREDUCE-2788_rev5.patch > > > The assignContainer() method in > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue > can cause the scheduler to crash if the ResourseRequest capability memory == > 0 (divide by zero). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2788) Normalize requests in FifoScheduler.allocate to prevent NPEs later
[ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Radwan updated MAPREDUCE-2788: Status: Patch Available (was: Open) > Normalize requests in FifoScheduler.allocate to prevent NPEs later > -- > > Key: MAPREDUCE-2788 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Reporter: Ahmed Radwan >Assignee: Ahmed Radwan > Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, > MAPREDUCE-2788_rev3.patch, MAPREDUCE-2788_rev4.patch, > MAPREDUCE-2788_rev5.patch > > > The assignContainer() method in > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue > can cause the scheduler to crash if the ResourseRequest capability memory == > 0 (divide by zero). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2788) Normalize requests in FifoScheduler.allocate to prevent NPEs later
[ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Radwan updated MAPREDUCE-2788: Attachment: MAPREDUCE-2788_rev5.patch Added a simple test case to verify the request normalization behavior for different valid and invalid memory values. > Normalize requests in FifoScheduler.allocate to prevent NPEs later > -- > > Key: MAPREDUCE-2788 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Reporter: Ahmed Radwan >Assignee: Ahmed Radwan > Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, > MAPREDUCE-2788_rev3.patch, MAPREDUCE-2788_rev4.patch, > MAPREDUCE-2788_rev5.patch > > > The assignContainer() method in > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue > can cause the scheduler to crash if the ResourseRequest capability memory == > 0 (divide by zero). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2788) Normalize requests in FifoScheduler.allocate to prevent NPEs later
[ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated MAPREDUCE-2788: - Status: Open (was: Patch Available) Ahmed, Could you please add a test case with this patch? > Normalize requests in FifoScheduler.allocate to prevent NPEs later > -- > > Key: MAPREDUCE-2788 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Reporter: Ahmed Radwan >Assignee: Ahmed Radwan > Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, > MAPREDUCE-2788_rev3.patch, MAPREDUCE-2788_rev4.patch > > > The assignContainer() method in > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue > can cause the scheduler to crash if the ResourseRequest capability memory == > 0 (divide by zero). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2788) Normalize requests in FifoScheduler.allocate to prevent NPEs later
[ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Radwan updated MAPREDUCE-2788: Status: Patch Available (was: Open) > Normalize requests in FifoScheduler.allocate to prevent NPEs later > -- > > Key: MAPREDUCE-2788 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Reporter: Ahmed Radwan >Assignee: Ahmed Radwan > Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, > MAPREDUCE-2788_rev3.patch, MAPREDUCE-2788_rev4.patch > > > The assignContainer() method in > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue > can cause the scheduler to crash if the ResourseRequest capability memory == > 0 (divide by zero). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2788) Normalize requests in FifoScheduler.allocate to prevent NPEs later
[ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Radwan updated MAPREDUCE-2788: Attachment: MAPREDUCE-2788_rev4.patch The attached new patch pulls out requests' normalization methods to SchedulerUtils, and both FS and CS now use them. FS.allocate() already calls normalizeRequests(), but the previous implementation for normalizeRequest() in FS doesn't rectify the case where memory==0. This is now fixed. Please let me know if you have further comments. > Normalize requests in FifoScheduler.allocate to prevent NPEs later > -- > > Key: MAPREDUCE-2788 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Reporter: Ahmed Radwan >Assignee: Ahmed Radwan > Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, > MAPREDUCE-2788_rev3.patch, MAPREDUCE-2788_rev4.patch > > > The assignContainer() method in > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue > can cause the scheduler to crash if the ResourseRequest capability memory == > 0 (divide by zero). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2788) Normalize requests in FifoScheduler.allocate to prevent NPEs later
[ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun C Murthy updated MAPREDUCE-2788: - Priority: Major (was: Critical) Summary: Normalize requests in FifoScheduler.allocate to prevent NPEs later (was: LeafQueue.assignContainer() can cause a crash if request.getCapability().getMemory() == 0) Changing the title to reflect the existing bug. > Normalize requests in FifoScheduler.allocate to prevent NPEs later > -- > > Key: MAPREDUCE-2788 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Reporter: Ahmed Radwan >Assignee: Ahmed Radwan > Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, > MAPREDUCE-2788_rev3.patch > > > The assignContainer() method in > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue > can cause the scheduler to crash if the ResourseRequest capability memory == > 0 (divide by zero). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
