[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Prakash updated MAPREDUCE-3087: Attachment: working.classpath.uniq notworking.classpath.uniq The classpath I grepped | sort | uniq from the two task.sh files I got (one from the working version and the other from the notworking version). Looks like the classpath which worked had some other jars not present in the new classpath. I'm guessing as part of the simplification for CLASSPATH maybe we missed something that was being included earlier? > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Ravi Prakash > Attachments: notworking.classpath.uniq, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[
https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Prakash updated MAPREDUCE-3087:
Attachment: MAPREDUCE-3087.patch
Seems like I finally figured this one out.
The line at issue is MRApps.java:191
bq.
thisClassLoader.getResource(mrAppGeneratedClasspathFile).getFile() );
The output of the getFile() method includes the "!mrapp-generated-classpath" .
e.g. in a test program
{noformat}
URL url = new
URL("file:/somepath/somewhere/mr-apps.jar!mrapp-generated-classpath");
System.out.println("Added " + url.getFile());
System.out.println("Should add " + url.getFile().split("!")[0] );
{noformat}
outputs
{noformat}
Added /somepath/somewhere/mr-apps.jar!mrapp-generated-classpath
Should add /somepath/somewhere/mr-apps.jar
{noformat}
So the line 191 was simply adding
/somepath/somewhere/mr-app.jar!mrapp-generated-classpath to the classpath. This
prevents my JVM to read mr-app.jar as included in the classpath.
Attaching a small patch to fix this issue. Can someone please review and commit
this?
> CLASSPATH not the same after MAPREDUCE-2880
> ---
>
> Key: MAPREDUCE-3087
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Ravi Prakash
> Attachments: MAPREDUCE-3087.patch, notworking.classpath.uniq,
> working.classpath.uniq
>
>
> After MAPREDUCE-2880, my classpath was missing key jar files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Prakash updated MAPREDUCE-3087: Fix Version/s: 0.23.0 Assignee: Ravi Prakash Target Version/s: 0.23.0 Affects Version/s: 0.23.0 Status: Patch Available (was: Open) > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, notworking.classpath.uniq, > working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Prakash updated MAPREDUCE-3087: Component/s: mrv2 > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, notworking.classpath.uniq, > working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Prakash updated MAPREDUCE-3087: Attachment: MAPREDUCE-3087.patch Geez Hadoop QA. Why do you have be to such a stickler for tests? All right, all right. Here you go. Happy now? > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > notworking.classpath.uniq, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun C Murthy updated MAPREDUCE-3087: - Status: Open (was: Patch Available) Ravi, thanks for digging through this. Patch looks ok, not sure if there is a better way. OTOH, I don't get the changes to pom deps? Also, pls fix the javac warning. Thanks. > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > notworking.classpath.uniq, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Prakash updated MAPREDUCE-3087: Attachment: MAPREDUCE-3087.patch Arun. It was a blocker for me to do any dev work because all my jobs were failing I don't know if we ever want to have something in the CLASSPATH which doesn't make sense to the JVM, and /somepath/mr-apps.jar!/mrapp-generated-classpath doesn't make sense to the JVM (so it will be ignored). Please ignore the last patch. It was an attempt to include tests, but it seems pretty hard because: 1. If I include the real mr-app.jar (using pom.xml), then a circular dependency is created. 2. If I don't include the mr-app.jar, then I must checkin and include in the CLASSPATH some jar containing a file mrapp-generated-classpath. This seemed too much effort for a simple one line change. I'm re-uploading the 1st patch with is a single line change. > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > MAPREDUCE-3087.patch, notworking.classpath.uniq, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Prakash updated MAPREDUCE-3087: Attachment: test-mr-app.jar MAPREDUCE-3087.patch I do not know how to include the jar file in a patch. After applying the MAPREDUCE-3087.patch, the test-mr-app.jar file needs to go in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/resources/ Can someone please tell me how else to include a test jar file? Or if there is another way write this unit test? > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, notworking.classpath.uniq, > test-mr-app.jar, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Prakash updated MAPREDUCE-3087: Status: Patch Available (was: Open) > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, notworking.classpath.uniq, > test-mr-app.jar, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Prakash updated MAPREDUCE-3087: Priority: Critical (was: Major) > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Critical > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, notworking.classpath.uniq, > test-mr-app.jar, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated MAPREDUCE-3087: --- Status: Open (was: Patch Available) > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Critical > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, notworking.classpath.uniq, > test-mr-app.jar, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated MAPREDUCE-3087: --- Attachment: MAPREDUCE-3087-3.patch Attaching Ravi's first patch again to run through Jenkins. > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Critical > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087-3.patch, MAPREDUCE-3087.patch, > MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > notworking.classpath.uniq, test-mr-app.jar, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated MAPREDUCE-3087: --- Hadoop Flags: Reviewed Status: Patch Available (was: Open) > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Critical > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087-3.patch, MAPREDUCE-3087.patch, > MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > notworking.classpath.uniq, test-mr-app.jar, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3087) CLASSPATH not the same after MAPREDUCE-2880
[ https://issues.apache.org/jira/browse/MAPREDUCE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated MAPREDUCE-3087: --- Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this to trunk and branch-0.23. Thanks Ravi Prakash! > CLASSPATH not the same after MAPREDUCE-2880 > --- > > Key: MAPREDUCE-3087 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3087 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Critical > Fix For: 0.23.0 > > Attachments: MAPREDUCE-3087-3.patch, MAPREDUCE-3087.patch, > MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, MAPREDUCE-3087.patch, > notworking.classpath.uniq, test-mr-app.jar, working.classpath.uniq > > > After MAPREDUCE-2880, my classpath was missing key jar files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
