[jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
[ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Abdelnur updated MAPREDUCE-5213: -- Resolution: Fixed Fix Version/s: 2.1.0-beta Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks Karthik. Committed to trunk, branch-2 and branch-2.1. > Re-assess TokenCache methods marked @Private > > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla >Priority: Minor > Fix For: 2.1.0-beta > > Attachments: mr-5213-1.patch, mr-5213-2.patch > > > While looking at the source, noticed that TokenCache#loadTokens methods are > marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
[ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated MAPREDUCE-5213: Issue Type: Bug (was: Sub-task) Parent: (was: MAPREDUCE-5108) > Re-assess TokenCache methods marked @Private > > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla >Priority: Minor > Attachments: mr-5213-1.patch, mr-5213-2.patch > > > While looking at the source, noticed that TokenCache#loadTokens methods are > marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
[ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated MAPREDUCE-5213: Issue Type: Sub-task (was: Bug) Parent: MAPREDUCE-5108 > Re-assess TokenCache methods marked @Private > > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla >Priority: Minor > Attachments: mr-5213-1.patch, mr-5213-2.patch > > > While looking at the source, noticed that TokenCache#loadTokens methods are > marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
[ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated MAPREDUCE-5213: Attachment: mr-5213-2.patch Patch to fix the javac warning, that should also fix the tests issue. > Re-assess TokenCache methods marked @Private > > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla >Priority: Minor > Attachments: mr-5213-1.patch, mr-5213-2.patch > > > While looking at the source, noticed that TokenCache#loadTokens methods are > marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
[ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated MAPREDUCE-5213: Status: Patch Available (was: Open) > Re-assess TokenCache methods marked @Private > > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: mr-5213-1.patch > > > While looking at the source, noticed that TokenCache#loadTokens methods are > marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
[ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated MAPREDUCE-5213: Priority: Minor (was: Major) > Re-assess TokenCache methods marked @Private > > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla >Priority: Minor > Attachments: mr-5213-1.patch > > > While looking at the source, noticed that TokenCache#loadTokens methods are > marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
[ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated MAPREDUCE-5213: Attachment: mr-5213-1.patch As per discussion on MAPREDUCE-5275, the methods in TokenCache were introduced only to maintain compatibility against Hadoop-1. These methods were originally intended to be private. Moreover, they aren't used anywhere else in the code. In addition to marking them @Private, we should deprecate them to ensure they can be remove in subsequent major releases. Uploading a trivial patch that does that. > Re-assess TokenCache methods marked @Private > > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: mr-5213-1.patch > > > While looking at the source, noticed that TokenCache#loadTokens methods are > marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
[ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated MAPREDUCE-5213: Description: While looking at the source, noticed that TokenCache#loadTokens methods are marked @Private but not used anywhere. We should either remove those methods or mark them Public or LimitedPrivate. was: While looking at the source, noticed that TokenCache has a few methods annotated as Private, but aren't being used anywhere else. If not, we should probably delete them. Summary: Re-assess TokenCache methods marked @Private (was: Annotate TokenCache methods as Public or LimitedPrivate) > Re-assess TokenCache methods marked @Private > > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > > While looking at the source, noticed that TokenCache#loadTokens methods are > marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
