[jira] [Updated] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated MAPREDUCE-5708: Labels: BB2015-05-TBR (was: ) > Duplicate String.format in getSpillFileForWrite > --- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Konstantin Weitz >Priority: Minor > Labels: BB2015-05-TBR > Attachments: 0001-Removed-duplicate-String.format.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely > _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does > not only affect performance, but leads to the weird requirement that task > attempt ids cannot contain _%_ characters (because these would be interpreted > as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt > ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Weitz updated MAPREDUCE-5708: Status: Patch Available (was: Open) > Duplicate String.format in getSpillFileForWrite > --- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Konstantin Weitz >Priority: Minor > Attachments: 0001-Removed-duplicate-String.format.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely > _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does > not only affect performance, but leads to the weird requirement that task > attempt ids cannot contain _%_ characters (because these would be interpreted > as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt > ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Weitz updated MAPREDUCE-5708: Status: Open (was: Patch Available) > Duplicate String.format in getSpillFileForWrite > --- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Konstantin Weitz >Priority: Minor > Attachments: 0001-Removed-duplicate-String.format.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely > _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does > not only affect performance, but leads to the weird requirement that task > attempt ids cannot contain _%_ characters (because these would be interpreted > as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt > ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Weitz updated MAPREDUCE-5708: Attachment: 0001-Removed-duplicate-String.format.patch > Duplicate String.format in getSpillFileForWrite > --- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Konstantin Weitz >Priority: Minor > Attachments: 0001-Removed-duplicate-String.format.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely > _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does > not only affect performance, but leads to the weird requirement that task > attempt ids cannot contain _%_ characters (because these would be interpreted > as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt > ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Weitz updated MAPREDUCE-5708: Description: The code responsible for formatting the spill file name (namely _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain _%_ characters (because these would be interpreted as format specifiers in the outside _String.format_ call). I assume this was done by mistake, as it could only be useful if task attempt ids contained _%n_. was: The code responsible for formatting the spill file name (namely _gettSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain _%_ characters (because these would be interpreted as format specifiers in the outside _String.format_ call). I assume this was done by mistake, as it could only be useful if task attempt ids contained _%n_. > Duplicate String.format in getSpillFileForWrite > --- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Konstantin Weitz >Priority: Minor > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely > _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does > not only affect performance, but leads to the weird requirement that task > attempt ids cannot contain _%_ characters (because these would be interpreted > as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt > ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Weitz updated MAPREDUCE-5708: Status: Patch Available (was: Open) > Duplicate String.format in getSpillFileForWrite > --- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Konstantin Weitz >Priority: Minor > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely > _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does > not only affect performance, but leads to the weird requirement that task > attempt ids cannot contain _%_ characters (because these would be interpreted > as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt > ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Weitz updated MAPREDUCE-5708: Description: The code responsible for formatting the spill file name (namely _gettSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain _%_ characters (because these would be interpreted as format specifiers in the outside _String.format_ call). I assume this was done by mistake, as it could only be useful if task attempt ids contained _%n_. was: The code responsible for formatting the spill file name (namely {code}getSpillFileForWrite{code}) unnecessarily calls {code}String.format{code} twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain {code}%{code} characters (because these would be interpreted as format specifiers in the outside {code}String.format{code} call). I assume this was done by mistake, as it could only be useful if task attempt ids contained {code}%n{code}. > Duplicate String.format in getSpillFileForWrite > --- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Konstantin Weitz >Priority: Minor > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely > _gettSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does > not only affect performance, but leads to the weird requirement that task > attempt ids cannot contain _%_ characters (because these would be interpreted > as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt > ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.1.5#6160)