[jira] [Updated] (MAPREDUCE-5971) Move the default options for distcp -p to DistCpOptionSwitch
[ https://issues.apache.org/jira/browse/MAPREDUCE-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated MAPREDUCE-5971: --- Resolution: Fixed Fix Version/s: 2.6.0 Status: Resolved (was: Patch Available) Committed to trunk and branch-2, thanks Charles > Move the default options for distcp -p to DistCpOptionSwitch > > > Key: MAPREDUCE-5971 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5971 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: distcp >Affects Versions: trunk >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Trivial > Fix For: 2.6.0 > > Attachments: MAPREDUCE-5971.001.patch, MAPREDUCE-5971.002.patch > > > The default preserve flags for distcp -p are embedded in the OptionsParser > code. Refactor to co-locate them with the actual flag initialization. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (MAPREDUCE-5971) Move the default options for distcp -p to DistCpOptionSwitch
[ https://issues.apache.org/jira/browse/MAPREDUCE-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated MAPREDUCE-5971: --- Summary: Move the default options for distcp -p to DistCpOptionSwitch (was: move the default options for distcp -p to DistCpOptionSwitch) > Move the default options for distcp -p to DistCpOptionSwitch > > > Key: MAPREDUCE-5971 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5971 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: distcp >Affects Versions: trunk >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Trivial > Attachments: MAPREDUCE-5971.001.patch, MAPREDUCE-5971.002.patch > > > The default preserve flags for distcp -p are embedded in the OptionsParser > code. Refactor to co-locate them with the actual flag initialization. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (MAPREDUCE-5971) move the default options for distcp -p to DistCpOptionSwitch
[ https://issues.apache.org/jira/browse/MAPREDUCE-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Lamb updated MAPREDUCE-5971: Attachment: MAPREDUCE-5971.002.patch Thanks for the review [~andrew.wang]. Per our conversation offline, here's the dead-simple change (move it to a constant). > move the default options for distcp -p to DistCpOptionSwitch > > > Key: MAPREDUCE-5971 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5971 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: distcp >Affects Versions: trunk >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Trivial > Attachments: MAPREDUCE-5971.001.patch, MAPREDUCE-5971.002.patch > > > The default preserve flags for distcp -p are embedded in the OptionsParser > code. Refactor to co-locate them with the actual flag initialization. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (MAPREDUCE-5971) move the default options for distcp -p to DistCpOptionSwitch
[ https://issues.apache.org/jira/browse/MAPREDUCE-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Lamb updated MAPREDUCE-5971: Attachment: MAPREDUCE-5971.001.patch > move the default options for distcp -p to DistCpOptionSwitch > > > Key: MAPREDUCE-5971 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5971 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: distcp >Affects Versions: trunk >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Trivial > Attachments: MAPREDUCE-5971.001.patch > > > The default preserve flags for distcp -p are embedded in the OptionsParser > code. Refactor to co-locate them with the actual flag initialization. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (MAPREDUCE-5971) move the default options for distcp -p to DistCpOptionSwitch
[ https://issues.apache.org/jira/browse/MAPREDUCE-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Lamb updated MAPREDUCE-5971: Status: Patch Available (was: Open) A simple patch is attached. I didn't make any unit tests since TestDistCpWithXAttrs exercises this. I can easily add a specific unit test for this though. > move the default options for distcp -p to DistCpOptionSwitch > > > Key: MAPREDUCE-5971 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5971 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: distcp >Affects Versions: trunk >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Trivial > > The default preserve flags for distcp -p are embedded in the OptionsParser > code. Refactor to co-locate them with the actual flag initialization. -- This message was sent by Atlassian JIRA (v6.2#6252)
