[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
[ https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862474#action_12862474 ] Tom White commented on MAPREDUCE-1067: -- I suspect this may not be a blocker. Default state of queues is undefined when unspecified - Key: MAPREDUCE-1067 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067 Project: Hadoop Map/Reduce Issue Type: Bug Components: jobtracker Affects Versions: 0.21.0 Reporter: V.V.Chaitanya Krishna Assignee: V.V.Chaitanya Krishna Priority: Blocker Fix For: 0.21.0 Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch, MAPREDUCE-1067-3.patch, MAPREDUCE-1067-4.patch, MAPREDUCE-1067-5.patch, MAPREDUCE-1067-6.patch Currently, if the state of a queue is not specified, it is being set to undefined state instead of running state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
[ https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792383#action_12792383 ] V.V.Chaitanya Krishna commented on MAPREDUCE-1067: -- bq. -1 contrib tests. The patch failed contrib unit tests. The test failures are unrelated to this issue (ref. MAPREDUCE-1311) Default state of queues is undefined when unspecified - Key: MAPREDUCE-1067 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067 Project: Hadoop Map/Reduce Issue Type: Bug Components: jobtracker Affects Versions: 0.21.0 Reporter: V.V.Chaitanya Krishna Assignee: V.V.Chaitanya Krishna Priority: Blocker Fix For: 0.21.0 Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch, MAPREDUCE-1067-3.patch, MAPREDUCE-1067-4.patch, MAPREDUCE-1067-5.patch, MAPREDUCE-1067-6.patch Currently, if the state of a queue is not specified, it is being set to undefined state instead of running state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
[ https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791868#action_12791868 ] rahul k singh commented on MAPREDUCE-1067: -- +1 with patch Default state of queues is undefined when unspecified - Key: MAPREDUCE-1067 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067 Project: Hadoop Map/Reduce Issue Type: Bug Components: jobtracker Affects Versions: 0.21.0 Reporter: V.V.Chaitanya Krishna Assignee: V.V.Chaitanya Krishna Priority: Blocker Fix For: 0.21.0 Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch, MAPREDUCE-1067-3.patch, MAPREDUCE-1067-4.patch, MAPREDUCE-1067-5.patch, MAPREDUCE-1067-6.patch Currently, if the state of a queue is not specified, it is being set to undefined state instead of running state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
[ https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792242#action_12792242 ] Hadoop QA commented on MAPREDUCE-1067: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428275/MAPREDUCE-1067-6.patch against trunk revision 891823. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/212/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/212/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/212/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/212/console This message is automatically generated. Default state of queues is undefined when unspecified - Key: MAPREDUCE-1067 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067 Project: Hadoop Map/Reduce Issue Type: Bug Components: jobtracker Affects Versions: 0.21.0 Reporter: V.V.Chaitanya Krishna Assignee: V.V.Chaitanya Krishna Priority: Blocker Fix For: 0.21.0 Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch, MAPREDUCE-1067-3.patch, MAPREDUCE-1067-4.patch, MAPREDUCE-1067-5.patch, MAPREDUCE-1067-6.patch Currently, if the state of a queue is not specified, it is being set to undefined state instead of running state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
[
https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791808#action_12791808
]
rahul k singh commented on MAPREDUCE-1067:
--
some very minor nits:
QueueConfigurationParser.java
1. if (queueState != null !(children != null children.size() 0)) {
queueState != null check
QueueState.java
Instead of comment i//we are passing uppercase , as java returns the
respective case enum object
//so for stopped valueOf returns the lowercase enum stopped object.
We should say We are passing uppercase , as according to javadoc for
valueOfThe name must match exactly an identifier used to declare an enum
constant in this type. (Extraneous whitespace characters are not permitted.)
--My initial comment wasnt very correct.
Queue.java
1. In the statement
throw new IllegalStateException(this.name +
is a container queue and cannot be set.);
It should be is a container queue . Container queue is always in running
state , and its state cannot be overridden
Default state of queues is undefined when unspecified
-
Key: MAPREDUCE-1067
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: jobtracker
Affects Versions: 0.21.0
Reporter: V.V.Chaitanya Krishna
Assignee: V.V.Chaitanya Krishna
Priority: Blocker
Fix For: 0.21.0
Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch,
MAPREDUCE-1067-3.patch, MAPREDUCE-1067-4.patch, MAPREDUCE-1067-5.patch
Currently, if the state of a queue is not specified, it is being set to
undefined state instead of running state.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
[ https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787985#action_12787985 ] rahul k singh commented on MAPREDUCE-1067: -- Queue.java 1.we can use children instead of this.children , similary for this.name. QueueState.java 1. comment in getState is incorrect. // check if state is in uppercase and then set the state. instead of above it should be //we are passing uppercase , as java returns the respective case enum object //so for stopped valueOf returns the lowercase enum stopped object. 2. TestQueueManager. There is validation check only for child queue and acls. we need to also include a state check . That is validation for case where in we have state and child queue defined. Default state of queues is undefined when unspecified - Key: MAPREDUCE-1067 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067 Project: Hadoop Map/Reduce Issue Type: Bug Components: jobtracker Affects Versions: 0.21.0 Reporter: V.V.Chaitanya Krishna Assignee: V.V.Chaitanya Krishna Priority: Blocker Fix For: 0.21.0 Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch, MAPREDUCE-1067-3.patch, MAPREDUCE-1067-4.patch Currently, if the state of a queue is not specified, it is being set to undefined state instead of running state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
[
https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787412#action_12787412
]
rahul k singh commented on MAPREDUCE-1067:
--
Queue.java
1. if(state == null) should be done first .
In the same method setState ,
replace the exception message with this :
is a container queue , its state always running and cannot be reset.
2. children.add(child);
if (QueueState.STOPPED.equals(this.state)) {
throw new IllegalStateException(this.name +
is a container queue and cannot be in STOPPED state.);
}
In the above scenario , the if check should be before we add children.I
think it should be before
children == null check , first statement in the method.
The message above should be adding child to a queue with state as stopped.
Also mention in comments that this check is not required if Queue object is
built from the XML , this indescrepency
might happen if this Queue is directly built.
Default state of queues is undefined when unspecified
-
Key: MAPREDUCE-1067
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: jobtracker
Affects Versions: 0.21.0
Reporter: V.V.Chaitanya Krishna
Assignee: V.V.Chaitanya Krishna
Priority: Blocker
Fix For: 0.21.0
Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch,
MAPREDUCE-1067-3.patch
Currently, if the state of a queue is not specified, it is being set to
undefined state instead of running state.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
[ https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786843#action_12786843 ] rahul k singh commented on MAPREDUCE-1067: -- Queue.java 1. In setState we are not checking if the state passed is RUNNING or STOPPED. Also there should be check in addChild , when we add a child , we need to check if State is changed to STOPPED or not, if yes we should throw an error. This is required as the order in which queue tag or state is not defined. QueueConfigurationParser.java 1 . The check for queue being a container queue is not required. As we already check this in validate method , wherein we check for queue tag and state tag being siblings.Can you confirm this observation? QueueState.java 1. We do not need a enumMap for states. Default state of queues is undefined when unspecified - Key: MAPREDUCE-1067 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067 Project: Hadoop Map/Reduce Issue Type: Bug Components: jobtracker Affects Versions: 0.21.0 Reporter: V.V.Chaitanya Krishna Assignee: V.V.Chaitanya Krishna Priority: Blocker Fix For: 0.21.0 Attachments: MAPREDUCE-1067-1.patch Currently, if the state of a queue is not specified, it is being set to undefined state instead of running state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
