[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828472#action_12828472 ] Hudson commented on MAPREDUCE-1097: --- Integrated in Hadoop-Mapreduce-trunk-Commit #225 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/225/]) Changes/fixes to support Vertica 3.5 Key: MAPREDUCE-1097 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097 Project: Hadoop Map/Reduce Issue Type: Improvement Components: contrib/vertica Affects Versions: 0.21.0 Environment: Hadoop 0.21.0 pre-release and Vertica 3.5 Reporter: Omer Trajman Assignee: Omer Trajman Priority: Minor Fix For: 0.21.0 Attachments: MAPREDUCE-1097-2.patch, MAPREDUCE-1097-3.patch, MAPREDUCE-1097.patch Vertica 3.5 includes three changes that the formatters should handle: 1) deploy_design function that handles much of the logic in the optimize method. This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function. 2) truncate table instead of recreating the table 3) numeric, decimal, money, number types (all the same path) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804583#action_12804583 ] Hudson commented on MAPREDUCE-1097: --- Integrated in Hadoop-Mapreduce-trunk #216 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/216/]) . Add support for Vertica 3.5 to its contrib module. Contributed by Omer Trajman Changes/fixes to support Vertica 3.5 Key: MAPREDUCE-1097 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097 Project: Hadoop Map/Reduce Issue Type: Improvement Components: contrib/vertica Affects Versions: 0.21.0 Environment: Hadoop 0.21.0 pre-release and Vertica 3.5 Reporter: Omer Trajman Assignee: Omer Trajman Priority: Minor Fix For: 0.21.0 Attachments: MAPREDUCE-1097-2.patch, MAPREDUCE-1097-3.patch, MAPREDUCE-1097.patch Vertica 3.5 includes three changes that the formatters should handle: 1) deploy_design function that handles much of the logic in the optimize method. This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function. 2) truncate table instead of recreating the table 3) numeric, decimal, money, number types (all the same path) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12798445#action_12798445 ] Hadoop QA commented on MAPREDUCE-1097: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429841/MAPREDUCE-1097-3.patch against trunk revision 897118. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/371/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/371/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/371/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/371/console This message is automatically generated. Changes/fixes to support Vertica 3.5 Key: MAPREDUCE-1097 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097 Project: Hadoop Map/Reduce Issue Type: Improvement Affects Versions: 0.21.0 Environment: Hadoop 0.21.0 pre-release and Vertica 3.5 Reporter: Omer Trajman Assignee: Omer Trajman Priority: Minor Fix For: 0.21.0 Attachments: MAPREDUCE-1097-2.patch, MAPREDUCE-1097-3.patch, MAPREDUCE-1097.patch Vertica 3.5 includes three changes that the formatters should handle: 1) deploy_design function that handles much of the logic in the optimize method. This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function. 2) truncate table instead of recreating the table 3) numeric, decimal, money, number types (all the same path) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787431#action_12787431 ] Hadoop QA commented on MAPREDUCE-1097: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427297/MAPREDUCE-1097-2.patch against trunk revision 888269. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/173/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/173/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/173/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/173/console This message is automatically generated. Changes/fixes to support Vertica 3.5 Key: MAPREDUCE-1097 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097 Project: Hadoop Map/Reduce Issue Type: Improvement Affects Versions: 0.21.0 Environment: Hadoop 0.21.0 pre-release and Vertica 3.5 Reporter: Omer Trajman Assignee: Omer Trajman Priority: Minor Fix For: 0.21.0 Attachments: MAPREDUCE-1097-2.patch, MAPREDUCE-1097.patch Vertica 3.5 includes three changes that the formatters should handle: 1) deploy_design function that handles much of the logic in the optimize method. This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function. 2) truncate table instead of recreating the table 3) numeric, decimal, money, number types (all the same path) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[
https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787176#action_12787176
]
Aaron Kimball commented on MAPREDUCE-1097:
--
Omer,
The gridmix failure is a known bug elsewhere in Hadoop; that's unrelated to
this patch.
As for the rest of the code you posted...
VerticaOutputFormat:
* make a constant {{VERSION_3_5 = 305}} in VerticaUtil?
* pool for refresh complete - poll...
* You select table_name, projection_name, and status from
vt_projection_refresh, but you never seem to read projection_name from the
ResultSet. Is this intentional?
* Also, I think you should call ResultSet.close() before calling the next
stmt.executeQuery()
* Related, at the end of the function, I think you may want to call
stmt.close() to ensure that all those resources are freed before continuing on.
* What's an ahm ? (Add to source comment?)
VerticaRecord:
* line 378: no need to cast to BigDecimal before calling toString
* It looks like REAL, DECIMAL, and NUMERIC used to be treated as doubles in
Java, and are now treated as BigDecimal. Is this correct? If so, what happens
to existing data (e.g., serialized into SequenceFiles) that contains data of
this type? Is this an incompatible change?
* It also looks as though you are changing how nulls are handled. Is this
backwards compatible with existing VerticaRecord deployments?
* line 575: unnecessary cast to BigDecimal.
Changes/fixes to support Vertica 3.5
Key: MAPREDUCE-1097
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097
Project: Hadoop Map/Reduce
Issue Type: Improvement
Affects Versions: 0.21.0
Environment: Hadoop 0.21.0 pre-release and Vertica 3.5
Reporter: Omer Trajman
Assignee: Omer Trajman
Priority: Minor
Fix For: 0.21.0
Attachments: MAPREDUCE-1097.patch
Vertica 3.5 includes three changes that the formatters should handle:
1) deploy_design function that handles much of the logic in the optimize
method. This improvement uses deploy_design if the server version supports
it instead of orchestrating in the formatter function.
2) truncate table instead of recreating the table
3) numeric, decimal, money, number types (all the same path)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787273#action_12787273 ] Omer Trajman commented on MAPREDUCE-1097: - Thanks Aaron - I'll tackle these and post a new patch. On VerticaRecord - it's not supposed to be used as a persistent format so I didn't put in any handling for these changes. Not sure if there's any way to indicate that. Changes/fixes to support Vertica 3.5 Key: MAPREDUCE-1097 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097 Project: Hadoop Map/Reduce Issue Type: Improvement Affects Versions: 0.21.0 Environment: Hadoop 0.21.0 pre-release and Vertica 3.5 Reporter: Omer Trajman Assignee: Omer Trajman Priority: Minor Fix For: 0.21.0 Attachments: MAPREDUCE-1097.patch Vertica 3.5 includes three changes that the formatters should handle: 1) deploy_design function that handles much of the logic in the optimize method. This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function. 2) truncate table instead of recreating the table 3) numeric, decimal, money, number types (all the same path) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786413#action_12786413 ] Omer Trajman commented on MAPREDUCE-1097: - Test failure was in gridmix. Any suggestions? Should I just resubmit? Changes/fixes to support Vertica 3.5 Key: MAPREDUCE-1097 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097 Project: Hadoop Map/Reduce Issue Type: Improvement Affects Versions: 0.21.0 Environment: Hadoop 0.21.0 pre-release and Vertica 3.5 Reporter: Omer Trajman Assignee: Omer Trajman Priority: Minor Fix For: 0.21.0 Attachments: MAPREDUCE-1097.patch Vertica 3.5 includes three changes that the formatters should handle: 1) deploy_design function that handles much of the logic in the optimize method. This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function. 2) truncate table instead of recreating the table 3) numeric, decimal, money, number types (all the same path) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786344#action_12786344 ] Hadoop QA commented on MAPREDUCE-1097: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12425767/MAPREDUCE-1097.patch against trunk revision 887135. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/293/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/293/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/293/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/293/console This message is automatically generated. Changes/fixes to support Vertica 3.5 Key: MAPREDUCE-1097 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097 Project: Hadoop Map/Reduce Issue Type: Improvement Affects Versions: 0.21.0 Environment: Hadoop 0.21.0 pre-release and Vertica 3.5 Reporter: Omer Trajman Assignee: Omer Trajman Priority: Minor Fix For: 0.21.0 Attachments: MAPREDUCE-1097.patch Vertica 3.5 includes three changes that the formatters should handle: 1) deploy_design function that handles much of the logic in the optimize method. This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function. 2) truncate table instead of recreating the table 3) numeric, decimal, money, number types (all the same path) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica 3.5
[ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781258#action_12781258 ] Hadoop QA commented on MAPREDUCE-1097: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12425767/MAPREDUCE-1097.patch against trunk revision 882790. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/259/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/259/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/259/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/259/console This message is automatically generated. Changes/fixes to support Vertica 3.5 Key: MAPREDUCE-1097 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097 Project: Hadoop Map/Reduce Issue Type: Improvement Affects Versions: 0.21.0 Environment: Hadoop 0.21.0 pre-release and Vertica 3.5 Reporter: Omer Trajman Assignee: Omer Trajman Priority: Minor Attachments: MAPREDUCE-1097.patch Vertica 3.5 includes three changes that the formatters should handle: 1) deploy_design function that handles much of the logic in the optimize method. This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function. 2) truncate table instead of recreating the table 3) numeric, decimal, money, number types (all the same path) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
