[jira] Commented: (MAPREDUCE-1286) Quotes in environment HADOOP_CLIENT_OPTS confuse parsing if this env is concatenated with something else
[ https://issues.apache.org/jira/browse/MAPREDUCE-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796744#action_12796744 ] Hudson commented on MAPREDUCE-1286: --- Integrated in Hadoop-Mapreduce-trunk #196 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/196/]) > Quotes in environment HADOOP_CLIENT_OPTS confuse parsing if this env is > concatenated with something else > > > Key: MAPREDUCE-1286 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1286 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: task >Affects Versions: 0.20.2 > Environment: Linux F12; streaming >Reporter: Yuri Pradkin >Assignee: Yuri Pradkin > Attachments: mr-1286 > > > I use streaming and in the perl-reducer I write to hdfs using a pipe to hdfs > -put - It turns out that because TaskRunner sets the environment > HADOOP_CLIENT_OPTS in double quotes, when hdfs shell script concatenates > these with something else, the command fails: .e.g java -Dblah=x -Dfoo=y > "-Dhadoop.tasklog.taskid=z -Dhadoop.tasklog.totalLogFileSize=s"... > Since I don't see any reason to have these double quotes in the original > code; I propose they're removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1286) Quotes in environment HADOOP_CLIENT_OPTS confuse parsing if this env is concatenated with something else
[ https://issues.apache.org/jira/browse/MAPREDUCE-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791598#action_12791598 ] Yuri Pradkin commented on MAPREDUCE-1286: - OK, can somebody commit this please? It's kind of trivial, but all the more reasons to close it. > Quotes in environment HADOOP_CLIENT_OPTS confuse parsing if this env is > concatenated with something else > > > Key: MAPREDUCE-1286 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1286 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: task >Affects Versions: 0.20.2 > Environment: Linux F12; streaming >Reporter: Yuri Pradkin >Assignee: Yuri Pradkin > Attachments: mr-1286 > > > I use streaming and in the perl-reducer I write to hdfs using a pipe to hdfs > -put - It turns out that because TaskRunner sets the environment > HADOOP_CLIENT_OPTS in double quotes, when hdfs shell script concatenates > these with something else, the command fails: .e.g java -Dblah=x -Dfoo=y > "-Dhadoop.tasklog.taskid=z -Dhadoop.tasklog.totalLogFileSize=s"... > Since I don't see any reason to have these double quotes in the original > code; I propose they're removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1286) Quotes in environment HADOOP_CLIENT_OPTS confuse parsing if this env is concatenated with something else
[ https://issues.apache.org/jira/browse/MAPREDUCE-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788338#action_12788338 ] Hadoop QA commented on MAPREDUCE-1286: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427511/mr-1286 against trunk revision 888761. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/311/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/311/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/311/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/311/console This message is automatically generated. > Quotes in environment HADOOP_CLIENT_OPTS confuse parsing if this env is > concatenated with something else > > > Key: MAPREDUCE-1286 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1286 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: task >Affects Versions: 0.20.2 > Environment: Linux F12; streaming >Reporter: Yuri Pradkin >Assignee: Yuri Pradkin > Attachments: mr-1286 > > > I use streaming and in the perl-reducer I write to hdfs using a pipe to hdfs > -put - It turns out that because TaskRunner sets the environment > HADOOP_CLIENT_OPTS in double quotes, when hdfs shell script concatenates > these with something else, the command fails: .e.g java -Dblah=x -Dfoo=y > "-Dhadoop.tasklog.taskid=z -Dhadoop.tasklog.totalLogFileSize=s"... > Since I don't see any reason to have these double quotes in the original > code; I propose they're removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
