[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796725#action_12796725 ] Hudson commented on MAPREDUCE-1301: --- Integrated in Hadoop-Mapreduce-trunk #196 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/196/]) > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301-1.txt, patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793942#action_12793942 ] Hemanth Yamijala commented on MAPREDUCE-1301: - +1. > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301-1.txt, patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793584#action_12793584 ] Amareshwari Sriramadasu commented on MAPREDUCE-1301: bq. -1 contrib tests. Is due to MAPREDUCE-1311 and MAPREDUCE-1312 > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301-1.txt, patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793550#action_12793550 ] Hadoop QA commented on MAPREDUCE-1301: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428695/patch-1301-1.txt against trunk revision 893055. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/233/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/233/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/233/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/233/console This message is automatically generated. > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301-1.txt, patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793517#action_12793517 ] Amareshwari Sriramadasu commented on MAPREDUCE-1301: I ran all the LinuxTaskController tests. Ran TestTrackerDistributedCacheManagerWithLinuxTaskController after applying the available patch on MAPREDUCE-1186. All of them passed except TestStreamingAsDifferentUser (due to MAPREDUCE-1322). > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301-1.txt, patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793139#action_12793139 ] Amareshwari Sriramadasu commented on MAPREDUCE-1301: Shall we put setting up permission directory and files in a static block to achieve the above, instead of doing it in a method? > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792428#action_12792428 ] Hemanth Yamijala commented on MAPREDUCE-1301: - I tried to see why we failed to catch this in MAPREDUCE-879. The core issue here is that there are two APIs in TestTaskTrackerLocalization - checkFilePermissions and setupPermissionScriptDir(File) which are related to each other. I.e. the former requires the latter to have been called. But they are static and thus hide this dependency. In the review, it didn't occur to me that I should check for callers of checkFilePermissions and verify this dependency is satisfied by other callers (like TestDebugScriptWithLinuxTaskController), as the API was not touched in the patch. As a result of that, I am tending to think that others will make the same mistake in future as well. I.e, they may think there's no dependency between these APIs and call only checkFilePermissions without calling setupPermissionScriptDir. So, though the attached patch actually fixes the issue for this test case, I would like to see an approach that goes beyond the fix and prevents these problems in future as well. Makes sense ? > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791769#action_12791769 ] Sreekanth Ramakrishnan commented on MAPREDUCE-1301: --- The changes look fine to me. +1 to the patch. > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791761#action_12791761 ] Amareshwari Sriramadasu commented on MAPREDUCE-1301: Test failures are not related to the patch > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1301) TestDebugScriptWithLinuxTaskController fails
[ https://issues.apache.org/jira/browse/MAPREDUCE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791685#action_12791685 ] Hadoop QA commented on MAPREDUCE-1301: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428159/patch-1301.txt against trunk revision 89. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/204/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/204/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/204/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/204/console This message is automatically generated. > TestDebugScriptWithLinuxTaskController fails > - > > Key: MAPREDUCE-1301 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1301 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test >Affects Versions: 0.21.0 >Reporter: Amareshwari Sriramadasu > Fix For: 0.21.0 > > Attachments: patch-1301.txt > > > After MAPREDUCE:879, TestDebugScriptWithLinuxTaskController fails with > following exception : > java.lang.NullPointerException > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.getFilePermissionAttrs(TestTaskTrackerLocalization.java:274) > at > org.apache.hadoop.mapred.TestTaskTrackerLocalization.checkFilePermissions(TestTaskTrackerLocalization.java:294) > at > org.apache.hadoop.mapred.TestDebugScript.verifyDebugScriptOutput(TestDebugScript.java:162) > at > org.apache.hadoop.mapred.TestDebugScriptWithLinuxTaskController.testDebugScriptExecutionAsDifferentUser(TestDebugScriptWithLinuxTaskController.java:50) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
