[jira] Commented: (MAPREDUCE-1429) New ant target to run all and only the linux task-controller related tests
[ https://issues.apache.org/jira/browse/MAPREDUCE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844463#action_12844463 ] Amareshwari Sriramadasu commented on MAPREDUCE-1429: Can ant test-task-controller be added to this target ? New ant target to run all and only the linux task-controller related tests -- Key: MAPREDUCE-1429 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1429 Project: Hadoop Map/Reduce Issue Type: Bug Components: build, task-controller, test Reporter: Vinod K V Assignee: Vinod K V Attachments: MAPREDUCE-1429-20100120.txt The LinuxTaskController tests cannot be run automatically by Hudson and so we've missed several bugs in the past because of not running some of these tests explicitly ourselves. It's a real pain to run them manually one by one, we should have an ant target to run them all in one swoop. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1429) New ant target to run all and only the linux task-controller related tests
[ https://issues.apache.org/jira/browse/MAPREDUCE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12806286#action_12806286 ] Arun C Murthy commented on MAPREDUCE-1429: -- +1 New ant target to run all and only the linux task-controller related tests -- Key: MAPREDUCE-1429 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1429 Project: Hadoop Map/Reduce Issue Type: Bug Components: build, task-controller, test Reporter: Vinod K V The LinuxTaskController tests cannot be run automatically by Hudson and so we've missed several bugs in the past because of not running some of these tests explicitly ourselves. It's a real pain to run them manually one by one, we should have an ant target to run them all in one swoop. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1429) New ant target to run all and only the linux task-controller related tests
[ https://issues.apache.org/jira/browse/MAPREDUCE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12806351#action_12806351 ] Hadoop QA commented on MAPREDUCE-1429: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431766/MAPREDUCE-1429-20100120.txt against trunk revision 904397. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/417/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/417/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/417/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/417/console This message is automatically generated. New ant target to run all and only the linux task-controller related tests -- Key: MAPREDUCE-1429 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1429 Project: Hadoop Map/Reduce Issue Type: Bug Components: build, task-controller, test Reporter: Vinod K V Assignee: Vinod K V Attachments: MAPREDUCE-1429-20100120.txt The LinuxTaskController tests cannot be run automatically by Hudson and so we've missed several bugs in the past because of not running some of these tests explicitly ourselves. It's a real pain to run them manually one by one, we should have an ant target to run them all in one swoop. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1429) New ant target to run all and only the linux task-controller related tests
[ https://issues.apache.org/jira/browse/MAPREDUCE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12806423#action_12806423 ] Konstantin Boudnik commented on MAPREDUCE-1429: --- I wonder why these tests haven't been executed by Hudson before? They seem to be a normal kind of tests located within the larger 'mapred' test suite. Also, I kinda don't like the idea of have a top level target for a very narrow subset of tests. What current approach does, basically, is a creation of an exclusive subset from a larger set of tests and giving them a privilege of a test suite. Doesn't look right to me. If they are so truly special then they need to be moved into a top-level test suite like 'unit' or 'mapred', aren't they? New ant target to run all and only the linux task-controller related tests -- Key: MAPREDUCE-1429 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1429 Project: Hadoop Map/Reduce Issue Type: Bug Components: build, task-controller, test Reporter: Vinod K V Assignee: Vinod K V Attachments: MAPREDUCE-1429-20100120.txt The LinuxTaskController tests cannot be run automatically by Hudson and so we've missed several bugs in the past because of not running some of these tests explicitly ourselves. It's a real pain to run them manually one by one, we should have an ant target to run them all in one swoop. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1429) New ant target to run all and only the linux task-controller related tests
[ https://issues.apache.org/jira/browse/MAPREDUCE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12806633#action_12806633 ] Hemanth Yamijala commented on MAPREDUCE-1429: - Kos, these tests are a little different from usual tests in that they rely on a binary called task-controller which must be built and configured as a 'setuid' binary and permissions set to be owned by root. They also run tests as a different user from the one firing the ant test target. If you notice these tests take some special parameters - a path to a binary file and a user identity. HADOOP-5771 introduced these tests for the first time into the system. In the ant build scripts, we only build the task-controller binary, but the step of making it a setuid is manually done in environments which use this feature. We did not know of a good way to automate this process on Hudson. And the tests do not make sense without this binary and/or user identity. They essentially exist to make sure the task-controller function works correctly in being able to run tasks as another user. Rather than completely ignoring automated testing because of these various limitations, we thought of still providing a facility by which atleast developers working on these features can have a way of testing them in an automated fashion, even if they mean, they have to run it 'specially'. Essentially, having something was better than having nothing. All this said, we absolutely *hate* not being able to run these tests in the right way on Hudson. I would appreciate any help / suggestions you can offer to fix this issue. New ant target to run all and only the linux task-controller related tests -- Key: MAPREDUCE-1429 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1429 Project: Hadoop Map/Reduce Issue Type: Bug Components: build, task-controller, test Reporter: Vinod K V Assignee: Vinod K V Attachments: MAPREDUCE-1429-20100120.txt The LinuxTaskController tests cannot be run automatically by Hudson and so we've missed several bugs in the past because of not running some of these tests explicitly ourselves. It's a real pain to run them manually one by one, we should have an ant target to run them all in one swoop. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
