[jira] Commented: (MAPREDUCE-1864) PipeMapRed.java has uninitialized members log_ and LOGNAME
[ https://issues.apache.org/jira/browse/MAPREDUCE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883795#action_12883795 ] Amareshwari Sriramadasu commented on MAPREDUCE-1864: bq. -1 contrib tests. Test failure is due to MAPREDUCE-1834. bq. -1 tests included. The patch removes unused code. So, no new tests are added. PipeMapRed.java has uninitialized members log_ and LOGNAME --- Key: MAPREDUCE-1864 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1864 Project: Hadoop Map/Reduce Issue Type: Bug Components: contrib/streaming Reporter: Amareshwari Sriramadasu Assignee: Amareshwari Sriramadasu Fix For: 0.22.0 Attachments: patch-1864.txt PipeMapRed.java has members log_ and LOGNAME, which are never initialized and they are used in code for logging in several places. They should be removed and PipeMapRed should use commons LogFactory and Log for logging. This would improve code maintainability. Also, as per [comment | https://issues.apache.org/jira/browse/MAPREDUCE-1851?focusedCommentId=12878530page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12878530], stream.joblog_ configuration property can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1864) PipeMapRed.java has uninitialized members log_ and LOGNAME
[ https://issues.apache.org/jira/browse/MAPREDUCE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883805#action_12883805 ] Ravi Gummadi commented on MAPREDUCE-1864: - Patch looks good. +1 PipeMapRed.java has uninitialized members log_ and LOGNAME --- Key: MAPREDUCE-1864 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1864 Project: Hadoop Map/Reduce Issue Type: Bug Components: contrib/streaming Reporter: Amareshwari Sriramadasu Assignee: Amareshwari Sriramadasu Fix For: 0.22.0 Attachments: patch-1864.txt PipeMapRed.java has members log_ and LOGNAME, which are never initialized and they are used in code for logging in several places. They should be removed and PipeMapRed should use commons LogFactory and Log for logging. This would improve code maintainability. Also, as per [comment | https://issues.apache.org/jira/browse/MAPREDUCE-1851?focusedCommentId=12878530page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12878530], stream.joblog_ configuration property can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1864) PipeMapRed.java has uninitialized members log_ and LOGNAME
[ https://issues.apache.org/jira/browse/MAPREDUCE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883592#action_12883592 ] Hadoop QA commented on MAPREDUCE-1864: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447931/patch-1864.txt against trunk revision 958902. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/273/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/273/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/273/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/273/console This message is automatically generated. PipeMapRed.java has uninitialized members log_ and LOGNAME --- Key: MAPREDUCE-1864 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1864 Project: Hadoop Map/Reduce Issue Type: Bug Components: contrib/streaming Reporter: Amareshwari Sriramadasu Assignee: Amareshwari Sriramadasu Fix For: 0.22.0 Attachments: patch-1864.txt PipeMapRed.java has members log_ and LOGNAME, which are never initialized and they are used in code for logging in several places. They should be removed and PipeMapRed should use commons LogFactory and Log for logging. This would improve code maintainability. Also, as per [comment | https://issues.apache.org/jira/browse/MAPREDUCE-1851?focusedCommentId=12878530page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12878530], stream.joblog_ configuration property can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1864) PipeMapRed.java has uninitialized members log_ and LOGNAME
[ https://issues.apache.org/jira/browse/MAPREDUCE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12882243#action_12882243 ] Hadoop QA commented on MAPREDUCE-1864: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447931/patch-1864.txt against trunk revision 957437. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/586/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/586/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/586/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/586/console This message is automatically generated. PipeMapRed.java has uninitialized members log_ and LOGNAME --- Key: MAPREDUCE-1864 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1864 Project: Hadoop Map/Reduce Issue Type: Bug Components: contrib/streaming Reporter: Amareshwari Sriramadasu Assignee: Amareshwari Sriramadasu Fix For: 0.22.0 Attachments: patch-1864.txt PipeMapRed.java has members log_ and LOGNAME, which are never initialized and they are used in code for logging in several places. They should be removed and PipeMapRed should use commons LogFactory and Log for logging. This would improve code maintainability. Also, as per [comment | https://issues.apache.org/jira/browse/MAPREDUCE-1851?focusedCommentId=12878530page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12878530], stream.joblog_ configuration property can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1864) PipeMapRed.java has uninitialized members log_ and LOGNAME
[ https://issues.apache.org/jira/browse/MAPREDUCE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881614#action_12881614 ] Ravi Gummadi commented on MAPREDUCE-1864: - One more unused member is debugFailEarly_ PipeMapRed.java has uninitialized members log_ and LOGNAME --- Key: MAPREDUCE-1864 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1864 Project: Hadoop Map/Reduce Issue Type: Bug Components: contrib/streaming Reporter: Amareshwari Sriramadasu Assignee: Amareshwari Sriramadasu Fix For: 0.22.0 PipeMapRed.java has members log_ and LOGNAME, which are never initialized and they are used in code for logging in several places. They should be removed and PipeMapRed should use commons LogFactory and Log for logging. This would improve code maintainability. Also, as per [comment | https://issues.apache.org/jira/browse/MAPREDUCE-1851?focusedCommentId=12878530page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12878530], stream.joblog_ configuration property can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1864) PipeMapRed.java has uninitialized members log_ and LOGNAME
[
https://issues.apache.org/jira/browse/MAPREDUCE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881616#action_12881616
]
Ravi Gummadi commented on MAPREDUCE-1864:
-
Also, I don't see a real need for the following as part of code.
boolean debug_;
boolean debugFailEarly_;
boolean debugFailDuring_;
boolean debugFailLate_;
If some debug statements are needed, we could add them as
{code} if (LOG.isDebugEnabled()) {LOG.debug(..);} {code}
So should we remove these 4 variables also ?
PipeMapRed.java has uninitialized members log_ and LOGNAME
---
Key: MAPREDUCE-1864
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1864
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: contrib/streaming
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu
Fix For: 0.22.0
PipeMapRed.java has members log_ and LOGNAME, which are never initialized and
they are used in code for logging in several places.
They should be removed and PipeMapRed should use commons LogFactory and Log
for logging. This would improve code maintainability.
Also, as per [comment |
https://issues.apache.org/jira/browse/MAPREDUCE-1851?focusedCommentId=12878530page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12878530],
stream.joblog_ configuration property can be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1864) PipeMapRed.java has uninitialized members log_ and LOGNAME
[ https://issues.apache.org/jira/browse/MAPREDUCE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881619#action_12881619 ] Ravi Gummadi commented on MAPREDUCE-1864: - mapredKey_ is not set at all but referenced in getContext(). We need to set it appropriately. PipeMapRed.java has uninitialized members log_ and LOGNAME --- Key: MAPREDUCE-1864 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1864 Project: Hadoop Map/Reduce Issue Type: Bug Components: contrib/streaming Reporter: Amareshwari Sriramadasu Assignee: Amareshwari Sriramadasu Fix For: 0.22.0 PipeMapRed.java has members log_ and LOGNAME, which are never initialized and they are used in code for logging in several places. They should be removed and PipeMapRed should use commons LogFactory and Log for logging. This would improve code maintainability. Also, as per [comment | https://issues.apache.org/jira/browse/MAPREDUCE-1851?focusedCommentId=12878530page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12878530], stream.joblog_ configuration property can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
