[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom White updated MAPREDUCE-1146:
-
Resolution: Fixed
Fix Version/s: 0.22.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Aaron!
(There were actually no release audit warnings introduced by this patch. Also,
the test failures were unrelated.)
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.3.patch,
> MAPREDUCE-1146.4.patch, MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Attachment: MAPREDUCE-1146.4.patch
New patch that rewrites CompilationManager to use {{javax.tools.JavaCompiler}}
and friends. This should eliminate the hard dependency on Sun's tools.jar and
solve this issue.
No new tests because the existing unit tests cover the use of
CompilationManager.
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.3.patch,
> MAPREDUCE-1146.4.patch, MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Status: Patch Available (was: Open)
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.3.patch,
> MAPREDUCE-1146.4.patch, MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Douglas updated MAPREDUCE-1146:
-
Status: Open (was: Patch Available)
bq. This patch uses the text replace feature as is done with the @PROJECT@
variable to substitute in the path from the user's $JAVA_HOME environment
variable [...]
It's a pretty elaborate extension of that hack. Is there any harm in adding
{{$JAVA_HOME/lib/tools.jar}} to the classpath when it doesn't exist on OSX? I'm
not an eclipse user; what's broken, here?
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.3.patch,
> MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Attachment: MAPREDUCE-1146.3.patch
New patch that handles OS X as well. On most operating systems, the javac
compiler is exposed through {{tools.jar}} in the JDK's lib/ directory. In OS X,
this is rolled into the monolithic {{classes.jar}} that is already implicitly
on the classpath. This version of the patch checks {{${os.name}}} to see
whether it's on OS X or not. If so, it comments out the tools.jar classpath
entry, otherwise, it includes it. This is some unfortunately hairy ant-fu, but
I'm not sure if there's a cleaner way to do it.
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.3.patch,
> MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Status: Patch Available (was: Open)
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.3.patch,
> MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Status: Open (was: Patch Available)
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Status: Patch Available (was: Open)
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Attachment: MAPREDUCE-1146.2.patch
New patch generated with {{\-\-no-prefix}} this time
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Status: Open (was: Patch Available)
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.2.patch, MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Attachment: MAPREDUCE-1146.patch
Attaching a patch that fixes the issue. There's not an easy way to get a
reference to the current JDK's tools.jar inside Eclipse itself. (Nor, if the
user is compiling with ecj, is there necessarily a compatible tools.jar
available.)
This patch uses the text replace feature as is done with the {...@project@}}
variable to substitute in the path from the user's {{$JAVA_HOME}} environment
variable. Eclipse file generation will fail if this does not point to a
suitable JDK. (The path may be specified by supplying ant with {{-Djdk.home}})
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1146) Sqoop dependencies break Ecpilse build on Linux
[
https://issues.apache.org/jira/browse/MAPREDUCE-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Kimball updated MAPREDUCE-1146:
-
Status: Patch Available (was: Open)
> Sqoop dependencies break Ecpilse build on Linux
> ---
>
> Key: MAPREDUCE-1146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/sqoop
> Environment: Linux, Sun JDK6
>Reporter: Konstantin Boudnik
>Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1146.patch
>
>
> Under Linux there's the error in the Eclipse "Problems" view:
> {noformat}
> - "com.sun.tools cannot be resolved" at line 166 of
> org.apache.hadoop.sqoop.orm.CompilationManager
> {noformat}
> The problem doesn't appear on MacOS though
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
