[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2010-01-07 Thread Chris Douglas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated MAPREDUCE-1287:
-

Status: Open  (was: Patch Available)

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Assignee: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: M1287-4.patch, M1287-5.patch, MAPREDUCE-1287.2.patch, 
> MAPREDUCE-1287.3.patch, MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2010-01-07 Thread Chris Douglas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated MAPREDUCE-1287:
-

Attachment: M1287-5.patch

Sorry, I forgot to put a watch on this issue.

bq. Any reason that the old partitioner uses 1 - numPartitions and the new one 
uses partitions - 1?

No, that was careless; thanks. Updated patch.

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Assignee: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: M1287-4.patch, M1287-5.patch, MAPREDUCE-1287.2.patch, 
> MAPREDUCE-1287.3.patch, MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2010-01-07 Thread Chris Douglas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated MAPREDUCE-1287:
-

Status: Patch Available  (was: Open)

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Assignee: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: M1287-4.patch, M1287-5.patch, MAPREDUCE-1287.2.patch, 
> MAPREDUCE-1287.3.patch, MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-18 Thread Chris Douglas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated MAPREDUCE-1287:
-

Attachment: M1287-4.patch

I agree with Tom; this belongs in the framework if it's a legal optimization.

Should this be marked as an incompatible change, since the partitioner is 
always called now? Clearly, any application that depends on the partitioner for 
correctness can be rewritten, but is it worth calling out?

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Assignee: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: M1287-4.patch, MAPREDUCE-1287.2.patch, 
> MAPREDUCE-1287.3.patch, MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-18 Thread Chris Douglas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated MAPREDUCE-1287:
-

Status: Open  (was: Patch Available)

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Assignee: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: M1287-4.patch, MAPREDUCE-1287.2.patch, 
> MAPREDUCE-1287.3.patch, MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-18 Thread Chris Douglas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated MAPREDUCE-1287:
-

Status: Patch Available  (was: Open)

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Assignee: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: M1287-4.patch, MAPREDUCE-1287.2.patch, 
> MAPREDUCE-1287.3.patch, MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-09 Thread Ed Mazur (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Mazur updated MAPREDUCE-1287:


Status: Open  (was: Patch Available)

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1287.2.patch, MAPREDUCE-1287.3.patch, 
> MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-09 Thread Ed Mazur (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Mazur updated MAPREDUCE-1287:


Attachment: MAPREDUCE-1287.3.patch

Forgot about the space after "if".

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1287.2.patch, MAPREDUCE-1287.3.patch, 
> MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-09 Thread Ed Mazur (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Mazur updated MAPREDUCE-1287:


Status: Patch Available  (was: Open)

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1287.2.patch, MAPREDUCE-1287.3.patch, 
> MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-09 Thread Ed Mazur (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Mazur updated MAPREDUCE-1287:


Status: Patch Available  (was: Open)

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1287.2.patch, MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-09 Thread Ed Mazur (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Mazur updated MAPREDUCE-1287:


Attachment: MAPREDUCE-1287.2.patch

- Changes old API HashPartitioner as well
- Corrected formatting

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1287.2.patch, MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-09 Thread Ed Mazur (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Mazur updated MAPREDUCE-1287:


Status: Open  (was: Patch Available)

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-09 Thread Ed Mazur (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Mazur updated MAPREDUCE-1287:


Status: Patch Available  (was: Open)

Trivial patch. Checks for the simple case of 1 reducer.

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-1287) HashPartitioner calls hashCode() when there is only 1 reducer

2009-12-09 Thread Ed Mazur (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Mazur updated MAPREDUCE-1287:


Attachment: MAPREDUCE-1287.patch

> HashPartitioner calls hashCode() when there is only 1 reducer
> -
>
> Key: MAPREDUCE-1287
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1287
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ed Mazur
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1287.patch
>
>
> HashPartitioner could be optimized to not call the key's hashCode() if there 
> is only 1 reducer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.