[jira] Updated: (MAPREDUCE-2238) Undeletable build directories
[ https://issues.apache.org/jira/browse/MAPREDUCE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated MAPREDUCE-2238: --- Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed to trunk and branch, thanks for review Eli, and thanks to Greg for helping brainstorm. > Undeletable build directories > -- > > Key: MAPREDUCE-2238 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2238 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: build, test >Affects Versions: 0.22.0 >Reporter: Eli Collins >Assignee: Todd Lipcon >Priority: Critical > Fix For: 0.22.0 > > Attachments: mapreduce-2238.txt, mapreduce-2238.txt, > mapreduce-2238.txt > > > The MR hudson job is failing, looks like it's due to a test chmod'ing a build > directory so the checkout can't clean the build dir. > https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/549/console > Building remotely on hadoop7 > hudson.util.IOException2: remote file operation failed: > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk at > hudson.remoting.Channel@2545938c:hadoop7 > at hudson.FilePath.act(FilePath.java:749) > at hudson.FilePath.act(FilePath.java:735) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:589) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:537) > at hudson.model.AbstractProject.checkout(AbstractProject.java:1116) > at > hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:479) > at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:411) > at hudson.model.Run.run(Run.java:1324) > at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) > at hudson.model.ResourceController.execute(ResourceController.java:88) > at hudson.model.Executor.run(Executor.java:139) > Caused by: java.io.IOException: Unable to delete > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk/trunk/build/test/logs/userlogs/job_20101230131139886_0001/attempt_20101230131139886_0001_m_00_0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2238) Undeletable build directories
[ https://issues.apache.org/jira/browse/MAPREDUCE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated MAPREDUCE-2238: --- Attachment: mapreduce-2238.txt Previous patch had a slight change where the Job ACL file was 600 instead of 700. Not clear why it should be 700 (it's not executable!) but it shouldn't be fixed as part of this JIRA (caused some localization tests to fail). Will resubmit this new patch for tests and open a new JIRA to fix permissions there to make more sense. > Undeletable build directories > -- > > Key: MAPREDUCE-2238 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2238 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: build, test >Affects Versions: 0.22.0 >Reporter: Eli Collins >Assignee: Todd Lipcon >Priority: Critical > Fix For: 0.22.0 > > Attachments: mapreduce-2238.txt, mapreduce-2238.txt, > mapreduce-2238.txt > > > The MR hudson job is failing, looks like it's due to a test chmod'ing a build > directory so the checkout can't clean the build dir. > https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/549/console > Building remotely on hadoop7 > hudson.util.IOException2: remote file operation failed: > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk at > hudson.remoting.Channel@2545938c:hadoop7 > at hudson.FilePath.act(FilePath.java:749) > at hudson.FilePath.act(FilePath.java:735) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:589) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:537) > at hudson.model.AbstractProject.checkout(AbstractProject.java:1116) > at > hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:479) > at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:411) > at hudson.model.Run.run(Run.java:1324) > at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) > at hudson.model.ResourceController.execute(ResourceController.java:88) > at hudson.model.Executor.run(Executor.java:139) > Caused by: java.io.IOException: Unable to delete > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk/trunk/build/test/logs/userlogs/job_20101230131139886_0001/attempt_20101230131139886_0001_m_00_0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2238) Undeletable build directories
[ https://issues.apache.org/jira/browse/MAPREDUCE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated MAPREDUCE-2238: --- Status: Patch Available (was: Open) > Undeletable build directories > -- > > Key: MAPREDUCE-2238 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2238 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: build, test >Affects Versions: 0.22.0 >Reporter: Eli Collins >Assignee: Todd Lipcon >Priority: Critical > Fix For: 0.22.0 > > Attachments: mapreduce-2238.txt, mapreduce-2238.txt, > mapreduce-2238.txt > > > The MR hudson job is failing, looks like it's due to a test chmod'ing a build > directory so the checkout can't clean the build dir. > https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/549/console > Building remotely on hadoop7 > hudson.util.IOException2: remote file operation failed: > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk at > hudson.remoting.Channel@2545938c:hadoop7 > at hudson.FilePath.act(FilePath.java:749) > at hudson.FilePath.act(FilePath.java:735) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:589) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:537) > at hudson.model.AbstractProject.checkout(AbstractProject.java:1116) > at > hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:479) > at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:411) > at hudson.model.Run.run(Run.java:1324) > at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) > at hudson.model.ResourceController.execute(ResourceController.java:88) > at hudson.model.Executor.run(Executor.java:139) > Caused by: java.io.IOException: Unable to delete > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk/trunk/build/test/logs/userlogs/job_20101230131139886_0001/attempt_20101230131139886_0001_m_00_0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2238) Undeletable build directories
[ https://issues.apache.org/jira/browse/MAPREDUCE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated MAPREDUCE-2238: --- Attachment: mapreduce-2238.txt Here's a patch which gets rid of the racy PermissionsHandler code and replaces it with calls to LocalFileSystem.setPermission. When combined with HADOOP-7110 this will actually be *more* efficient and also avoid the bug described in this JIRA. > Undeletable build directories > -- > > Key: MAPREDUCE-2238 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2238 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: build, test >Affects Versions: 0.22.0 >Reporter: Eli Collins >Assignee: Todd Lipcon > Fix For: 0.22.0 > > Attachments: mapreduce-2238.txt, mapreduce-2238.txt > > > The MR hudson job is failing, looks like it's due to a test chmod'ing a build > directory so the checkout can't clean the build dir. > https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/549/console > Building remotely on hadoop7 > hudson.util.IOException2: remote file operation failed: > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk at > hudson.remoting.Channel@2545938c:hadoop7 > at hudson.FilePath.act(FilePath.java:749) > at hudson.FilePath.act(FilePath.java:735) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:589) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:537) > at hudson.model.AbstractProject.checkout(AbstractProject.java:1116) > at > hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:479) > at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:411) > at hudson.model.Run.run(Run.java:1324) > at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) > at hudson.model.ResourceController.execute(ResourceController.java:88) > at hudson.model.Executor.run(Executor.java:139) > Caused by: java.io.IOException: Unable to delete > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk/trunk/build/test/logs/userlogs/job_20101230131139886_0001/attempt_20101230131139886_0001_m_00_0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2238) Undeletable build directories
[ https://issues.apache.org/jira/browse/MAPREDUCE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated MAPREDUCE-2238: --- Priority: Critical (was: Major) Affects Version/s: (was: 0.23.0) 0.22.0 Fix Version/s: 0.22.0 Changing to critical for 0.22, since the bug is now understood, and it ends up killing Hudson on a regular basis > Undeletable build directories > -- > > Key: MAPREDUCE-2238 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2238 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: build, test >Affects Versions: 0.22.0 >Reporter: Eli Collins >Assignee: Todd Lipcon >Priority: Critical > Fix For: 0.22.0 > > Attachments: mapreduce-2238.txt, mapreduce-2238.txt > > > The MR hudson job is failing, looks like it's due to a test chmod'ing a build > directory so the checkout can't clean the build dir. > https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/549/console > Building remotely on hadoop7 > hudson.util.IOException2: remote file operation failed: > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk at > hudson.remoting.Channel@2545938c:hadoop7 > at hudson.FilePath.act(FilePath.java:749) > at hudson.FilePath.act(FilePath.java:735) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:589) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:537) > at hudson.model.AbstractProject.checkout(AbstractProject.java:1116) > at > hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:479) > at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:411) > at hudson.model.Run.run(Run.java:1324) > at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) > at hudson.model.ResourceController.execute(ResourceController.java:88) > at hudson.model.Executor.run(Executor.java:139) > Caused by: java.io.IOException: Unable to delete > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk/trunk/build/test/logs/userlogs/job_20101230131139886_0001/attempt_20101230131139886_0001_m_00_0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2238) Undeletable build directories
[ https://issues.apache.org/jira/browse/MAPREDUCE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated MAPREDUCE-2238: --- Attachment: mapreduce-2238.txt I don't know that this is the issue, but the new setPermissions code is definitely prone to races. If two threads tried to setPermissions on the same directory at once, it could definitely end up with an incorrect result. This patch makes setPermissions threadsafe at least against other invocations of the same method. Worth a shot to apply this and see if the problems go away? > Undeletable build directories > -- > > Key: MAPREDUCE-2238 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2238 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: build, test >Affects Versions: 0.23.0 >Reporter: Eli Collins > Attachments: mapreduce-2238.txt > > > The MR hudson job is failing, looks like it's due to a test chmod'ing a build > directory so the checkout can't clean the build dir. > https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/549/console > Building remotely on hadoop7 > hudson.util.IOException2: remote file operation failed: > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk at > hudson.remoting.Channel@2545938c:hadoop7 > at hudson.FilePath.act(FilePath.java:749) > at hudson.FilePath.act(FilePath.java:735) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:589) > at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:537) > at hudson.model.AbstractProject.checkout(AbstractProject.java:1116) > at > hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:479) > at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:411) > at hudson.model.Run.run(Run.java:1324) > at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) > at hudson.model.ResourceController.execute(ResourceController.java:88) > at hudson.model.Executor.run(Executor.java:139) > Caused by: java.io.IOException: Unable to delete > /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk/trunk/build/test/logs/userlogs/job_20101230131139886_0001/attempt_20101230131139886_0001_m_00_0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
