[jira] [Updated] (MAPREDUCE-2381) JobTracker instrumentation not consistent about error handling
[ https://issues.apache.org/jira/browse/MAPREDUCE-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated MAPREDUCE-2381: - Resolution: Fixed Fix Version/s: 0.23.0 Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I've just committed this. Thanks, Philip! JobTracker instrumentation not consistent about error handling -- Key: MAPREDUCE-2381 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2381 Project: Hadoop Map/Reduce Issue Type: Improvement Reporter: Philip Zeyliger Assignee: Philip Zeyliger Fix For: 0.23.0 Attachments: MAPREDUCE-2381.patch.txt In the current code, if the class specified by the JobTracker instrumentation config property is not there, the JobTracker fails to start with a ClassNotFound. If it's there, but it can't load for whatever reason, the JobTracker continues with the default. Having two different error-handling routes is a bit confusing; I propose to move one line so that it's consistent. (On the TaskTracker instrumentation side, if any of the multiple instrumentations aren't available, the default is used.) The attached patch merely moves a line inside of the try block that's already there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2381) JobTracker instrumentation not consistent about error handling
[ https://issues.apache.org/jira/browse/MAPREDUCE-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Zeyliger updated MAPREDUCE-2381: --- Attachment: MAPREDUCE-2381.patch.txt JobTracker instrumentation not consistent about error handling -- Key: MAPREDUCE-2381 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2381 Project: Hadoop Map/Reduce Issue Type: Improvement Reporter: Philip Zeyliger Attachments: MAPREDUCE-2381.patch.txt In the current code, if the class specified by the JobTracker instrumentation config property is not there, the JobTracker fails to start with a ClassNotFound. If it's there, but it can't load for whatever reason, the JobTracker continues with the default. Having two different error-handling routes is a bit confusing; I propose to move one line so that it's consistent. (On the TaskTracker instrumentation side, if any of the multiple instrumentations aren't available, the default is used.) The attached patch merely moves a line inside of the try block that's already there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2381) JobTracker instrumentation not consistent about error handling
[ https://issues.apache.org/jira/browse/MAPREDUCE-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Zeyliger updated MAPREDUCE-2381: --- Assignee: Philip Zeyliger Status: Patch Available (was: Open) JobTracker instrumentation not consistent about error handling -- Key: MAPREDUCE-2381 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2381 Project: Hadoop Map/Reduce Issue Type: Improvement Reporter: Philip Zeyliger Assignee: Philip Zeyliger Attachments: MAPREDUCE-2381.patch.txt In the current code, if the class specified by the JobTracker instrumentation config property is not there, the JobTracker fails to start with a ClassNotFound. If it's there, but it can't load for whatever reason, the JobTracker continues with the default. Having two different error-handling routes is a bit confusing; I propose to move one line so that it's consistent. (On the TaskTracker instrumentation side, if any of the multiple instrumentations aren't available, the default is used.) The attached patch merely moves a line inside of the try block that's already there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
