[jira] Updated: (MAPREDUCE-826) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception
[ https://issues.apache.org/jira/browse/MAPREDUCE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated MAPREDUCE-826: Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. thanks koji harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception - Key: MAPREDUCE-826 URL: https://issues.apache.org/jira/browse/MAPREDUCE-826 Project: Hadoop Map/Reduce Issue Type: Bug Components: harchive Reporter: Koji Noguchi Assignee: Koji Noguchi Priority: Trivial Fix For: 0.21.0 Attachments: mapreduce-826-1.patch, mapreduce-826-2.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-826) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception
[ https://issues.apache.org/jira/browse/MAPREDUCE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Noguchi updated MAPREDUCE-826: --- Attachment: mapreduce-826-2.patch Thanks Mahadev. Made the change. Since this is a patch around main, didn't find a straight forward way to do a unit test. One manual test. Before the patch. $ hadoop archive -archiveName myhar.har -p /tmp/somenonexistdir somedir /user/knoguchi null $ echo $? 0 After the patch, $ hadoop archive -archiveName myhar.har -p /tmp/somenonexistdir somedir /user/knoguchi Exception in archives null lieliftbean-lm:trunk knoguchi$ echo $? 1 I guess we should also fix the NPE when src doesn't exist. I'm leaving it for now since this was a good manual test case. harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception - Key: MAPREDUCE-826 URL: https://issues.apache.org/jira/browse/MAPREDUCE-826 Project: Hadoop Map/Reduce Issue Type: Bug Components: harchive Reporter: Koji Noguchi Assignee: Koji Noguchi Priority: Trivial Fix For: 0.21.0 Attachments: mapreduce-826-1.patch, mapreduce-826-2.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-826) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception
[ https://issues.apache.org/jira/browse/MAPREDUCE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated MAPREDUCE-826: Status: Open (was: Patch Available) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception - Key: MAPREDUCE-826 URL: https://issues.apache.org/jira/browse/MAPREDUCE-826 Project: Hadoop Map/Reduce Issue Type: Bug Components: harchive Reporter: Koji Noguchi Assignee: Koji Noguchi Priority: Trivial Fix For: 0.21.0 Attachments: mapreduce-826-1.patch, mapreduce-826-2.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-826) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception
[ https://issues.apache.org/jira/browse/MAPREDUCE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated MAPREDUCE-826: Hadoop Flags: [Reviewed] Status: Patch Available (was: Open) +1 looks good... harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception - Key: MAPREDUCE-826 URL: https://issues.apache.org/jira/browse/MAPREDUCE-826 Project: Hadoop Map/Reduce Issue Type: Bug Components: harchive Reporter: Koji Noguchi Assignee: Koji Noguchi Priority: Trivial Fix For: 0.21.0 Attachments: mapreduce-826-1.patch, mapreduce-826-2.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-826) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception
[ https://issues.apache.org/jira/browse/MAPREDUCE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated MAPREDUCE-826: Fix Version/s: 0.21.0 Assignee: Koji Noguchi harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception - Key: MAPREDUCE-826 URL: https://issues.apache.org/jira/browse/MAPREDUCE-826 Project: Hadoop Map/Reduce Issue Type: Bug Components: harchive Reporter: Koji Noguchi Assignee: Koji Noguchi Priority: Trivial Fix For: 0.21.0 Attachments: mapreduce-826-1.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-826) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception
[ https://issues.apache.org/jira/browse/MAPREDUCE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated MAPREDUCE-826: Status: Patch Available (was: Open) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception - Key: MAPREDUCE-826 URL: https://issues.apache.org/jira/browse/MAPREDUCE-826 Project: Hadoop Map/Reduce Issue Type: Bug Components: harchive Reporter: Koji Noguchi Assignee: Koji Noguchi Priority: Trivial Fix For: 0.21.0 Attachments: mapreduce-826-1.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-826) harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception
[ https://issues.apache.org/jira/browse/MAPREDUCE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Noguchi updated MAPREDUCE-826: --- Attachment: mapreduce-826-1.patch 1) Calls ToolRunner.run 2) Took out catch(Excepttion e) and let main fail with stack dump. At least return value would be non-zero. harchive doesn't use ToolRunner / harchive returns 0 even if the job fails with exception - Key: MAPREDUCE-826 URL: https://issues.apache.org/jira/browse/MAPREDUCE-826 Project: Hadoop Map/Reduce Issue Type: Bug Components: harchive Reporter: Koji Noguchi Priority: Trivial Attachments: mapreduce-826-1.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.