[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in JobContext never return null

2009-10-18 Thread Chris Douglas (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated MAPREDUCE-990:


Status: Open  (was: Patch Available)

The patch is stale

 Making distributed cache getters in JobContext never return null
 

 Key: MAPREDUCE-990
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
 Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt


 MAPREDUCE-898 moved distributed cache setters and getters into Job and 
 JobContext.  Since the API is new, I'd like to propose that those getters 
 never return null, but instead always return an array, even if it's empty.
 If people don't like this change, I can instead merely update the javadoc to 
 reflect the fact that null may be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in JobContext never return null

2009-09-18 Thread Tom White (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated MAPREDUCE-990:


Attachment: MAPREDUCE-990.patch

New patch that removes the timestamp methods.

 Making distributed cache getters in JobContext never return null
 

 Key: MAPREDUCE-990
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
 Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt


 MAPREDUCE-898 moved distributed cache setters and getters into Job and 
 JobContext.  Since the API is new, I'd like to propose that those getters 
 never return null, but instead always return an array, even if it's empty.
 If people don't like this change, I can instead merely update the javadoc to 
 reflect the fact that null may be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in JobContext never return null

2009-09-18 Thread Tom White (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated MAPREDUCE-990:


Status: Open  (was: Patch Available)

 Making distributed cache getters in JobContext never return null
 

 Key: MAPREDUCE-990
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
 Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt


 MAPREDUCE-898 moved distributed cache setters and getters into Job and 
 JobContext.  Since the API is new, I'd like to propose that those getters 
 never return null, but instead always return an array, even if it's empty.
 If people don't like this change, I can instead merely update the javadoc to 
 reflect the fact that null may be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in JobContext never return null

2009-09-18 Thread Tom White (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated MAPREDUCE-990:


Status: Patch Available  (was: Open)

 Making distributed cache getters in JobContext never return null
 

 Key: MAPREDUCE-990
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
 Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt


 MAPREDUCE-898 moved distributed cache setters and getters into Job and 
 JobContext.  Since the API is new, I'd like to propose that those getters 
 never return null, but instead always return an array, even if it's empty.
 If people don't like this change, I can instead merely update the javadoc to 
 reflect the fact that null may be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in JobContext never return null

2009-09-16 Thread Philip Zeyliger (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Zeyliger updated MAPREDUCE-990:
--

Attachment: MAPREDUCE-990.patch.txt

This changes javadocs and implementations of accessors to never return null.

I've also made getFileTimestamps and getArchiveTimestamps package private.  
Ideally those interfaces aren't leaked to the user at all--the only person who 
accesses them is the mapreduce framework itself, so they should remain an 
implementation detail.

 Making distributed cache getters in JobContext never return null
 

 Key: MAPREDUCE-990
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
 Attachments: MAPREDUCE-990.patch.txt


 MAPREDUCE-898 moved distributed cache setters and getters into Job and 
 JobContext.  Since the API is new, I'd like to propose that those getters 
 never return null, but instead always return an array, even if it's empty.
 If people don't like this change, I can instead merely update the javadoc to 
 reflect the fact that null may be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in JobContext never return null

2009-09-16 Thread Philip Zeyliger (JIRA)

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Zeyliger updated MAPREDUCE-990:
--

Status: Patch Available  (was: Open)

 Making distributed cache getters in JobContext never return null
 

 Key: MAPREDUCE-990
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
 Attachments: MAPREDUCE-990.patch.txt


 MAPREDUCE-898 moved distributed cache setters and getters into Job and 
 JobContext.  Since the API is new, I'd like to propose that those getters 
 never return null, but instead always return an array, even if it's empty.
 If people don't like this change, I can instead merely update the javadoc to 
 reflect the fact that null may be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.