Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

[Steve Lime]

This is my fault... The intention was to localize those bounds checks in a
benign manner. However, I should have known that restricting angle to 0-360
might catch someone off guard and loosened that for the 7.6 backport. Those
changes had been in the 8.0 branch for many months with zero negative
feedback. We could issue a 7.6.6 release with a -360 to 360 range. I've not
heard of any other related issues with that change.

--Steve

On Tue, May 30, 2023 at 7:45 AM Rahkonen Jukka <
jukka.rahko...@maanmittauslaitos.fi> wrote:

> Hi,
>
>
>
> It looks like Steve Lime was reading the text in the paragraph and not the
> line the defines the synopsis and thought that the documentation was
> explicit
> https://github.com/MapServer/MapServer/issues/6463#issuecomment-1025938850
>
> “since style-level angle documentation refers specifically to 0-360 I
> think we should limit from 0-360 if there are no objections”. Or maybe he
> was remembering what he was thinking when writing the original code?
>
> Please make a pull request for improving the documentation, for my mind it
> is vague now.
>
>
>
> -Jukka Rahkonen-
>
>
>
>
>
>
>
> *Lähettäjä:* Oliver Christen 
> *Lähetetty:* tiistai 30. toukokuuta 2023 15.21
> *Vastaanottaja:* Rahkonen Jukka 
> *Kopio:* mapserver-users@lists.osgeo.org
> *Aihe:* Re: [MapServer-users] breaking changes in branch-7-6 after commit
> of experimental changes from branch-8-0
>
>
>
> before that commit, the following code was working:
>
>
>
> STYLE
>   COLOR 255 255 255
>   SYMBOL "rectangle3"
>   ANGLE -45
>   SIZE 8
>   GAP 10
> END
>
>
>
> after that commit, it no longer works, as ANGLE -45 is not accepted
> anymore, instead it had to be changed to
>
>
>
> STYLE
>   COLOR 255 255 255
>   SYMBOL "rectangle3"
>   ANGLE 315
>   SIZE 8
>   GAP 10
> END
>
>
>
> the documentation https://mapserver.org/mapfile/style.html say it must be
> of type DOUBLE, but double can be negative and nothing say explicitly in
> the documentation that the value can not be negative.
>
>
>
> I see this discussion here:
> https://github.com/MapServer/MapServer/issues/6463
>
> but no comment if something was done or agreed on about this.
>
> A note should be added to the documentation to make that clear, as it was
> done for label size (see below).
>
> I can do a PR if that would be acceptable ?
>
>
>
> for label size, I see that a note was added saying the value must be
> greater than zero on 26 january 2022, so I guess this is on me for not
> noticing it (but im not alone not noticing it so I guess it wasnt clearly
> stated/announced either)
>
>
>
> Best regards
>
> Oliver
>
>
>
>
>
>
>
>
>
>
>
>
>
> On Tue, May 30, 2023 at 1:27 PM Rahkonen Jukka <
> jukka.rahko...@maanmittauslaitos.fi> wrote:
>
> Hi,
>
>
>
> Maybe the commit could be adjusted in Mapserver 7. Out of curiosity, what
> is the use case for zero sized labels and symbols? To disable them, or?
> About the angle, by the Mapserver 7.0 documentation, doesn’t it feel like
> negative angles were not thought to work ever?
>
>
> “Angle, given in degrees, to rotate the symbol (counter clockwise).
> Default is 0 (no rotation). If you have an attribute that specifies angles
> in a clockwise direction (compass direction), you have to adjust the angle
> attribute values before they reach MapServer (360-ANGLE), as it is not
> possible to use a mathematical expression for ANGLE.”
>
>
>
> -Jukka Rahkonen-
>
>
>
> *Lähettäjä:* MapServer-users  
> *Puolesta
> *Oliver Christen
> *Lähetetty:* tiistai 30. toukokuuta 2023 13.59
> *Vastaanottaja:* mapserver-users@lists.osgeo.org
> *Aihe:* [MapServer-users] breaking changes in branch-7-6 after commit of
> experimental changes from branch-8-0
>
>
>
> Dear Mapserver commiters
>
>
>
> this commit there:
>
> https://github.com/MapServer/MapServer/pull/6818
>
>
>
> broke a lot of things,
>
> like style angles not supporting negative values anymore or label size
> mandatorily greater than zero (also possibly for symbol)
>
>
>
> Im not against changes, but changes should be:
>
> a) documented
>
> b) announced with preferably a deprecation period
>
>
>
> so, please revert that commit or provide adequate change/documentation for
> all the breaking changes.
>
>
>
> Thank you
>
> Best regards
>
> Oliver Christen
>
>
>
> --
>
>
>
>
> <https://www.camptocamp.com/en/news-events/camptocamp-flagship-office-bussigny>
>
> *New address from 1st September 2022*
>
>
>
> *Camptocamp SA*
>
> Route de la Chaux 4
>
> 1030 Bussigny
>
> Suisse
>
> ___
> MapServer-users mailing list
> MapServer-users@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/mapserver-users
>
___
MapServer-users mailing list
MapServer-users@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-users

Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

[Rahkonen Jukka]

Hi,

It looks like Steve Lime was reading the text in the paragraph and not the line 
the defines the synopsis and thought that the documentation was explicit  
https://github.com/MapServer/MapServer/issues/6463#issuecomment-1025938850
“since style-level angle documentation refers specifically to 0-360 I think we 
should limit from 0-360 if there are no objections”. Or maybe he was 
remembering what he was thinking when writing the original code?

Please make a pull request for improving the documentation, for my mind it is 
vague now.

-Jukka Rahkonen-



Lähettäjä: Oliver Christen 
Lähetetty: tiistai 30. toukokuuta 2023 15.21
Vastaanottaja: Rahkonen Jukka 
Kopio: mapserver-users@lists.osgeo.org
Aihe: Re: [MapServer-users] breaking changes in branch-7-6 after commit of 
experimental changes from branch-8-0

before that commit, the following code was working:

STYLE
  COLOR 255 255 255
  SYMBOL "rectangle3"
  ANGLE -45
  SIZE 8
  GAP 10
END

after that commit, it no longer works, as ANGLE -45 is not accepted anymore, 
instead it had to be changed to

STYLE
  COLOR 255 255 255
  SYMBOL "rectangle3"
  ANGLE 315
  SIZE 8
  GAP 10
END

the documentation https://mapserver.org/mapfile/style.html say it must be of 
type DOUBLE, but double can be negative and nothing say explicitly in the 
documentation that the value can not be negative.

I see this discussion here:
https://github.com/MapServer/MapServer/issues/6463
but no comment if something was done or agreed on about this.
A note should be added to the documentation to make that clear, as it was done 
for label size (see below).
I can do a PR if that would be acceptable ?

for label size, I see that a note was added saying the value must be greater 
than zero on 26 january 2022, so I guess this is on me for not noticing it (but 
im not alone not noticing it so I guess it wasnt clearly stated/announced 
either)

Best regards
Oliver






On Tue, May 30, 2023 at 1:27 PM Rahkonen Jukka 
mailto:jukka.rahko...@maanmittauslaitos.fi>>
 wrote:
Hi,

Maybe the commit could be adjusted in Mapserver 7. Out of curiosity, what is 
the use case for zero sized labels and symbols? To disable them, or? About the 
angle, by the Mapserver 7.0 documentation, doesn’t it feel like negative angles 
were not thought to work ever?

“Angle, given in degrees, to rotate the symbol (counter clockwise). Default is 
0 (no rotation). If you have an attribute that specifies angles in a clockwise 
direction (compass direction), you have to adjust the angle attribute values 
before they reach MapServer (360-ANGLE), as it is not possible to use a 
mathematical expression for ANGLE.”

-Jukka Rahkonen-

Lähettäjä: MapServer-users 
mailto:mapserver-users-boun...@lists.osgeo.org>>
 Puolesta Oliver Christen
Lähetetty: tiistai 30. toukokuuta 2023 13.59
Vastaanottaja: 
mapserver-users@lists.osgeo.org<mailto:mapserver-users@lists.osgeo.org>
Aihe: [MapServer-users] breaking changes in branch-7-6 after commit of 
experimental changes from branch-8-0

Dear Mapserver commiters

this commit there:
https://github.com/MapServer/MapServer/pull/6818

broke a lot of things,
like style angles not supporting negative values anymore or label size 
mandatorily greater than zero (also possibly for symbol)

Im not against changes, but changes should be:
a) documented
b) announced with preferably a deprecation period

so, please revert that commit or provide adequate change/documentation for all 
the breaking changes.

Thank you
Best regards
Oliver Christen

--


[https://lh5.googleusercontent.com/4RpzNqlUvMoqWPtwuUWigz1_dKPkUN4OQOKshy_zixf9Gi6JzQJRjs3oHwxYaiADK7htQjUTodRa-OUr4YEKbgs9SsmqPG6QYjqKj3wbXoQ6snhaqq2eEJTeB1FZHKK7SApWcSZk45Fe3w4grA]<https://www.camptocamp.com/en/news-events/camptocamp-flagship-office-bussigny>

New address from 1st September 2022


Camptocamp SA

Route de la Chaux 4

1030 Bussigny

Suisse
___
MapServer-users mailing list
MapServer-users@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-users

Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

[Jeff McKenna]

Hi Oliver, a pull request in the documentation repository would be 
warmly received: https://github.com/MapServer/MapServer-documentation 
Thank-you for catching this.  -jeff







--
Jeff McKenna
GatewayGeo: Developers of MS4W, MapServer Consulting and Training
co-founder of FOSS4G
http://gatewaygeo.com/




On 2023-05-30 9:20 a.m., Oliver Christen wrote:

before that commit, the following code was working:

     STYLE
       COLOR 255 255 255
       SYMBOL "rectangle3"
       ANGLE -45
       SIZE 8
       GAP 10
     END

after that commit, it no longer works, as ANGLE -45 is not accepted 
anymore, instead it had to be changed to


STYLE
       COLOR 255 255 255
       SYMBOL "rectangle3"
       ANGLE 315
       SIZE 8
       GAP 10
     END

the documentation https://mapserver.org/mapfile/style.html 
 say it must be of type 
DOUBLE, but double can be negative and nothing say explicitly in the 
documentation that the value can not be negative.


I see this discussion here:
https://github.com/MapServer/MapServer/issues/6463 


but no comment if something was done or agreed on about this.
A note should be added to the documentation to make that clear, as it 
was done for label size (see below).

I can do a PR if that would be acceptable ?

for label size, I see that a note was added saying the value must be 
greater than zero on 26 january 2022, so I guess this is on me for not 
noticing it (but im not alone not noticing it so I guess it wasnt 
clearly stated/announced either)


Best regards
Oliver





On Tue, May 30, 2023 at 1:27 PM Rahkonen Jukka 
> wrote:


Hi,

__ __

Maybe the commit could be adjusted in Mapserver 7. Out of curiosity,
what is the use case for zero sized labels and symbols? To disable
them, or? About the angle, by the Mapserver 7.0 documentation,
doesn’t it feel like negative angles were not thought to work ever?


“Angle, given in degrees, to rotate the symbol (counter clockwise).
Default is 0 (no rotation). If you have an attribute that specifies
angles in a clockwise direction (compass direction), you have to
adjust the angle attribute values before they reach MapServer
(360-ANGLE), as it is not possible to use a mathematical expression
for ANGLE.”

__ __

-Jukka Rahkonen-

__ __

*Lähettäjä:*MapServer-users mailto:mapserver-users-boun...@lists.osgeo.org>> *Puolesta *Oliver
Christen
*Lähetetty:* tiistai 30. toukokuuta 2023 13.59
*Vastaanottaja:* mapserver-users@lists.osgeo.org

*Aihe:* [MapServer-users] breaking changes in branch-7-6 after
commit of experimental changes from branch-8-0

__ __

Dear Mapserver commiters

__ __

this commit there:

https://github.com/MapServer/MapServer/pull/6818


__ __

broke a lot of things, 

like style angles not supporting negative values anymore or label
size mandatorily greater than zero (also possibly for symbol)

__ __

Im not against changes, but changes should be: 

a) documented 

b) announced with preferably a deprecation period

__ __

so, please revert that commit or provide adequate
change/documentation for all the breaking changes.


___
MapServer-users mailing list
MapServer-users@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-users

Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

[Oliver Christen]

before that commit, the following code was working:

STYLE
  COLOR 255 255 255
  SYMBOL "rectangle3"
  ANGLE -45
  SIZE 8
  GAP 10
END

after that commit, it no longer works, as ANGLE -45 is not accepted
anymore, instead it had to be changed to

STYLE
  COLOR 255 255 255
  SYMBOL "rectangle3"
  ANGLE 315
  SIZE 8
  GAP 10
END

the documentation https://mapserver.org/mapfile/style.html say it must be
of type DOUBLE, but double can be negative and nothing say explicitly in
the documentation that the value can not be negative.

I see this discussion here:
https://github.com/MapServer/MapServer/issues/6463
but no comment if something was done or agreed on about this.
A note should be added to the documentation to make that clear, as it was
done for label size (see below).
I can do a PR if that would be acceptable ?

for label size, I see that a note was added saying the value must be
greater than zero on 26 january 2022, so I guess this is on me for not
noticing it (but im not alone not noticing it so I guess it wasnt clearly
stated/announced either)

Best regards
Oliver






On Tue, May 30, 2023 at 1:27 PM Rahkonen Jukka <
jukka.rahko...@maanmittauslaitos.fi> wrote:

> Hi,
>
>
>
> Maybe the commit could be adjusted in Mapserver 7. Out of curiosity, what
> is the use case for zero sized labels and symbols? To disable them, or?
> About the angle, by the Mapserver 7.0 documentation, doesn’t it feel like
> negative angles were not thought to work ever?
>
>
> “Angle, given in degrees, to rotate the symbol (counter clockwise).
> Default is 0 (no rotation). If you have an attribute that specifies angles
> in a clockwise direction (compass direction), you have to adjust the angle
> attribute values before they reach MapServer (360-ANGLE), as it is not
> possible to use a mathematical expression for ANGLE.”
>
>
>
> -Jukka Rahkonen-
>
>
>
> *Lähettäjä:* MapServer-users  
> *Puolesta
> *Oliver Christen
> *Lähetetty:* tiistai 30. toukokuuta 2023 13.59
> *Vastaanottaja:* mapserver-users@lists.osgeo.org
> *Aihe:* [MapServer-users] breaking changes in branch-7-6 after commit of
> experimental changes from branch-8-0
>
>
>
> Dear Mapserver commiters
>
>
>
> this commit there:
>
> https://github.com/MapServer/MapServer/pull/6818
>
>
>
> broke a lot of things,
>
> like style angles not supporting negative values anymore or label size
> mandatorily greater than zero (also possibly for symbol)
>
>
>
> Im not against changes, but changes should be:
>
> a) documented
>
> b) announced with preferably a deprecation period
>
>
>
> so, please revert that commit or provide adequate change/documentation for
> all the breaking changes.
>
>
>
> Thank you
>
> Best regards
>
> Oliver Christen
>
>
>
> --
>
>
>
>
> 
>
> *New address from 1st September 2022*
>
>
>
> *Camptocamp SA*
>
> Route de la Chaux 4
>
> 1030 Bussigny
>
> Suisse
>
___
MapServer-users mailing list
MapServer-users@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-users

Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

[Rahkonen Jukka]

Hi,

Maybe the commit could be adjusted in Mapserver 7. Out of curiosity, what is 
the use case for zero sized labels and symbols? To disable them, or? About the 
angle, by the Mapserver 7.0 documentation, doesn't it feel like negative angles 
were not thought to work ever?

"Angle, given in degrees, to rotate the symbol (counter clockwise). Default is 
0 (no rotation). If you have an attribute that specifies angles in a clockwise 
direction (compass direction), you have to adjust the angle attribute values 
before they reach MapServer (360-ANGLE), as it is not possible to use a 
mathematical expression for ANGLE."

-Jukka Rahkonen-

Lähettäjä: MapServer-users  Puolesta 
Oliver Christen
Lähetetty: tiistai 30. toukokuuta 2023 13.59
Vastaanottaja: mapserver-users@lists.osgeo.org
Aihe: [MapServer-users] breaking changes in branch-7-6 after commit of 
experimental changes from branch-8-0

Dear Mapserver commiters

this commit there:
https://github.com/MapServer/MapServer/pull/6818

broke a lot of things,
like style angles not supporting negative values anymore or label size 
mandatorily greater than zero (also possibly for symbol)

Im not against changes, but changes should be:
a) documented
b) announced with preferably a deprecation period

so, please revert that commit or provide adequate change/documentation for all 
the breaking changes.

Thank you
Best regards
Oliver Christen

--


[https://lh5.googleusercontent.com/4RpzNqlUvMoqWPtwuUWigz1_dKPkUN4OQOKshy_zixf9Gi6JzQJRjs3oHwxYaiADK7htQjUTodRa-OUr4YEKbgs9SsmqPG6QYjqKj3wbXoQ6snhaqq2eEJTeB1FZHKK7SApWcSZk45Fe3w4grA]

New address from 1st September 2022


Camptocamp SA

Route de la Chaux 4

1030 Bussigny

Suisse
___
MapServer-users mailing list
MapServer-users@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-users