Re: [Maria-developers] MDEV-4472 Audit-plugin. Server-related part of the task

[Alexey Botchkov]

07.09.2013 16:14, Sergei Golubchik wrote:

Hi, Holyfoot!
+  //local_mysql_data_home= (char *)GetProcAddress(0, mysql_data_home);
+//#else
+  //local_mysql_data_home= mysql_data_home;
+//#endif /*_WIN32*/
I think you can completely remove this and the #ifndef above.
For your MySQL plugin you can simply #include this in the plugin body


Right.
I actually meant it but something went wrong with my file versions. Sorry.
The correct patch was resent.



int result;
I believe you've added recently a test to disable rotation if number of
rotations is 0?




Yes.
Though that was added in the SERVER AUDIT tree.
But since i'm recommitting, i moved the change here.

See the new patch here:
http://lists.askmonty.org/pipermail/commits/2013-September/005355.html

Best regards.
HF


___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Maria-developers] Rev 3883: MDEV-4472 Audit-plugin. Server-related part of the task

[Sergei Golubchik]

Hi, Holyfoot!

Just one question, see below.
Otherwise ok.

On Sep 08, holyf...@askmonty.org wrote:
 revno: 3883
 revision-id: holyf...@askmonty.org-20130908092209-xar471jadl7lmwzo
 parent: ser...@pisem.net-20130907203634-htu89dqmwe5gqwy5
 committer: Alexey Botchkov holyf...@askmonty.org
 branch nick: 55-4472
 timestamp: Sun 2013-09-08 14:22:09 +0500
 message:
   MDEV-4472 Audit-plugin.  Server-related part of the task.
file_logger became the service.
Data like query_id now are sent to the audit plugin.
Fix for MDEV-4770 ported from 10.0.
Fix added for the read_maria_plugin_info().
Log rotation can be disabled with 'set rotations=0'.

 === renamed file 'plugin/sql_errlog/sql_logger.cc' = 'mysys/file_logger.c'
 --- a/plugin/sql_errlog/sql_logger.cc 2013-06-22 12:02:03 +
 +++ b/mysys/file_logger.c 2013-09-08 09:22:09 +
 @@ -16,7 +16,7 @@
  
  #include my_global.h
  #include my_sys.h
 -#include service_logger.h
 +#include mysql/service_logger.h
  #include my_pthread.h
  
  extern MYSQL_PLUGIN_IMPORT char  *mysql_data_home;

I believe we agreed to keep file_logger.c completely clean from
dynamic-plugin-related code. Did you forget to remove the line above?

Regards,
Sergei


___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help   : https://help.launchpad.net/ListHelp