Re: [Maria-developers] XtraDB commit
Vadim Tkachenko writes: > I did yesterday commit to lp:maria where I replaced InnoDB by XtraDB, > but I do not see message with commit to > maria-develop...@lists.launchpad.net. > > Is there something special I need to do that commit is sent to mail-list ? Yes. You need to install the mysql plugin for bzr. I think you just place the mysql_plugins/ directory under ~/.bazaar/plugins/ But where to get the mysql_plugins? They are GPL'ed (according to the license in the directory), but it does not appear to be publicly available anywhere at this point. I asked Monty Taylor (who wrote the plugins with Chad Miller), and he said he would check if it was possible to get them released publicly. After installing the plugins, configure them in ~/.bazaar/bazaar.conf [DEFAULT] launchpad_username = knielsen allow_remote_options = mysql email = kniel...@knielsen-hq.org per_file_commits = On post_commit_mailer = smtplib modified for personal circumstances. And finally, make sure that local mail sending works. That should be it. Hopefully, Monty Taylor will get the mysql plugins released. But otherwise, he told me that the commit mails are based on bzr-email, so we could probably switch to using that without too much trouble. - Kristian. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
Re: [Maria-developers] XtraDB commit
Kristian, Ok, Got it. While mysql_plugin is not available is it OK if I send changeset for review manually ? Though it is rather big, as there a lot of changes InnoDB -> InnoDB plugin. I may push to another three and propose for merge, in this case you also will be able to review changeset. Best, Vadim Kristian Nielsen wrote: > Vadim Tkachenko writes: > >> I did yesterday commit to lp:maria where I replaced InnoDB by XtraDB, >> but I do not see message with commit to >> maria-develop...@lists.launchpad.net. >> >> Is there something special I need to do that commit is sent to mail-list ? > > Yes. > > You need to install the mysql plugin for bzr. I think you just place the > mysql_plugins/ directory under ~/.bazaar/plugins/ > > But where to get the mysql_plugins? They are GPL'ed (according to the license > in the directory), but it does not appear to be publicly available anywhere at > this point. I asked Monty Taylor (who wrote the plugins with Chad Miller), and > he said he would check if it was possible to get them released publicly. > > After installing the plugins, configure them in ~/.bazaar/bazaar.conf > > [DEFAULT] > launchpad_username = knielsen > allow_remote_options = mysql > email = kniel...@knielsen-hq.org > per_file_commits = On > post_commit_mailer = smtplib > > modified for personal circumstances. > > And finally, make sure that local mail sending works. That should be it. > > Hopefully, Monty Taylor will get the mysql plugins released. But otherwise, he > told me that the commit mails are based on bzr-email, so we could probably > switch to using that without too much trouble. > > - Kristian. > -- Vadim Tkachenko, CTO Percona Inc. ICQ: 369-510-335, Skype: vadimtk153, Phone +1-888-401-3403 MySQL Performance Blog - http://www.mysqlperformanceblog.com MySQL Consulting http://www.percona.com/ Attend the 2009 Percona Performance Conference April 22-23 - http://conferences.percona.com/ ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
Re: [Maria-developers] XtraDB commit
Vadim Tkachenko writes: > Ok, Got it. While mysql_plugin is not available is it OK if I send > changeset for review manually ? Though it is rather big, as there a lot > of changes InnoDB -> InnoDB plugin. I think that is fine, please do. Though if it is bigger than 10 Mb or so it may be rejected by some mail systems. > I may push to another three and propose for merge, in this case you also > will be able to review changeset. Feel free to do this as well. We are not really using the Launchpad model of pushing to own branch and make merge request. But it would be good to get some experience with it in case it could work better for us. Though it seems to not produce diffs in the mails, which does not fit the current review model. It does make it much easier for people to try/use the code (as opposed to just the patch). If you upgrade your local bzr repository to version 1.9 (and use bzr >1.9 obviously), launchpad uses 'stacked branches', which means that when you push a new branch to launchpad it only has to transfer the new changeset. This makes creating new branches quite cheap (though xtradb may still take some bandwidth I assume ;-). - Kristian. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
