Hi, Alexey!
On Apr 22, Alexey Botchkov wrote:
> revision-id: ce222a71bf75b2125cc588371a3debb3e4a22d7f
> (mariadb-10.3.6-34-gce222a7)
> parent(s): 9f84451d87ba1924539b7d2ab69619b71d0155b9
> committer: Alexey Botchkov
> timestamp: 2018-04-22 16:01:18 +0400
> message:
>
> MDEV-15915 Add Feature_json status variable.
>
> ---
> mysql-test/main/status.test | 7 +++
> sql/item_create.cc | 26 ++
> sql/mysqld.cc | 1 +
> sql/sql_class.h | 1 +
> 4 files changed, 35 insertions(+)
>
> diff --git a/sql/item_create.cc b/sql/item_create.cc
> index 901dfa0..8b8476b 100644
> --- a/sql/item_create.cc
> +++ b/sql/item_create.cc
> @@ -5118,6 +5118,7 @@ Create_func_json_exists
> Create_func_json_exists::s_singleton;
> Item*
> Create_func_json_exists::create_2_arg(THD *thd, Item *arg1, Item *arg2)
> {
> + status_var_increment(current_thd->status_var.feature_json);
>return new (thd->mem_root) Item_func_json_exists(thd, arg1, arg2);
I believe you've added that to all JSON functions, I didn't try to
double-check that :)
> }
>
> diff --git a/sql/mysqld.cc b/sql/mysqld.cc
> index 6e1a599..ae14c80 100644
> --- a/sql/mysqld.cc
> +++ b/sql/mysqld.cc
> @@ -8553,6 +8553,7 @@ SHOW_VAR status_vars[]= {
>{"Feature_fulltext", (char*) offsetof(STATUS_VAR,
> feature_fulltext), SHOW_LONG_STATUS},
>{"Feature_gis", (char*) offsetof(STATUS_VAR, feature_gis),
> SHOW_LONG_STATUS},
>{"Feature_invisible_columns", (char*) offsetof(STATUS_VAR,
> feature_invisible_columns), SHOW_LONG_STATUS},
> + {"Feature_json", (char*) offsetof(STATUS_VAR, feature_json),
> SHOW_LONG_STATUS},
>{"Feature_locale", (char*) offsetof(STATUS_VAR, feature_locale),
> SHOW_LONG_STATUS},
>{"Feature_subquery", (char*) offsetof(STATUS_VAR,
> feature_subquery), SHOW_LONG_STATUS},
>{"Feature_timezone", (char*) offsetof(STATUS_VAR,
> feature_timezone), SHOW_LONG_STATUS},
Elena commented in MDEV about "Feature_json" being possibly confusing.
Does your using "Feature_json" name mean that
* you considered it and intentionally kept the old name, thinking it's fine
or
* you didn't see the comment, and now you might reconsider?
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
