Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-03 Thread John Hunter
On 3/3/07, Jouni K. Seppänen <[EMAIL PROTECTED]> wrote:

> I replaced most of the kwargs by a **kwargs dict in svn revision 3037.
> This does change the behavior for people who were giving positional
> arguments to barh, but they do get an error message.

Since this changes the API, albeit minimally, make sure these changes
are documented in the API_CHANGES file.  Thanks for working on this.

JDH

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel


Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-03 Thread Jouni K . Seppänen
"John Hunter" <[EMAIL PROTECTED]> writes:

>> I replaced most of the kwargs by a **kwargs dict in svn revision 3037.
>
> Since this changes the API, albeit minimally, make sure these changes
> are documented in the API_CHANGES file.  Thanks for working on this.

Done. Should the function signature in the docstring of barh be
changed as well? I think listing the possible keyword arguments and
their defaults is valuable in the help text, but the signature could
make people think they can use positional arguments.

-- 
Jouni K. Seppänen
http://www.iki.fi/jks


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel


Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-03 Thread John Hunter
On 3/3/07, Jouni K. Seppänen <[EMAIL PROTECTED]> wrote:

> Done. Should the function signature in the docstring of barh be
> changed as well? I think listing the possible keyword arguments and
> their defaults is valuable in the help text, but the signature could
> make people think they can use positional arguments.

The call signature in the docstring should certainly be changed to
match the new signature.  Also, take a look at the kwdocd stuff we
have to see if you can make that work for the keyword args.  See
Axes.plot for an example, where we interpolate the Line2D keyword arg
docstring into the __doc__ attribute.

Thanks,
JDH

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel


Re: [matplotlib-devel] building with python-2.3

2007-03-03 Thread John Hunter
On 2/23/07, Andrew Straw <[EMAIL PROTECTED]> wrote:

> 2) make our own distutils monkeypatch a la setuptools. Looking at
> setuptools/dist.py, this doesn't look trivial -- certainly beyond my
> free bandwidth capacity.

This is fine by me -- I actually was forced to think about this this
morning as I tried to upgrade my powerbook to the latest svn.  I'm
still on python2.3, and when I tried to install I hit the setuptools
import.  I figured I would be a good crash test dummy to see how easy
it was to install setuptools, so I poked around and found the ez_setup
and am off to the races.  I added a friendly exception to setup.py to
make it easier for the next guy

if major==2 and minor1<=3:
# setuptools monkeypatches distutils.core.Distribution to support
# package_data
try: import setuptools
except ImportError:
raise SystemExit("""\
matplotlib requires setuptools for installation.  Please download
http://peak.telecommunity.com/dist/ez_setup.py and run it (as su if
you are doing a system wide install) to install the proper version of
setuptools for your system""")

Darren, do you still have the html docs building on your system?  If
so, perhaps you could update the installing page to mention the
requirement (an perhaps the user's guide).  I updated the README in
the src distro.  I still haven't got my build pipeline for the htdocs
and user's guide going on my laptop after my old build computer died,
a good indication that both are too complicated

JDH

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel


Re: [matplotlib-devel] building with python-2.3

2007-03-03 Thread Darren Dale
On Saturday 03 March 2007 12:43:53 pm you wrote:
> On 2/23/07, Andrew Straw <[EMAIL PROTECTED]> wrote:
> > 2) make our own distutils monkeypatch a la setuptools. Looking at
> > setuptools/dist.py, this doesn't look trivial -- certainly beyond my
> > free bandwidth capacity.
>
> This is fine by me -- I actually was forced to think about this this
> morning as I tried to upgrade my powerbook to the latest svn.  I'm
> still on python2.3, and when I tried to install I hit the setuptools
> import.  I figured I would be a good crash test dummy to see how easy
> it was to install setuptools, so I poked around and found the ez_setup
> and am off to the races.  I added a friendly exception to setup.py to
> make it easier for the next guy
>
> if major==2 and minor1<=3:
>     # setuptools monkeypatches distutils.core.Distribution to support
>     # package_data
>     try: import setuptools
>     except ImportError:
>         raise SystemExit("""\
> matplotlib requires setuptools for installation.  Please download
> http://peak.telecommunity.com/dist/ez_setup.py and run it (as su if
> you are doing a system wide install) to install the proper version of
> setuptools for your system""")

Excellent, I was going to add a warning like this myself if the setuptools 
approach was accepted.

> Darren, do you still have the html docs building on your system?  If
> so, perhaps you could update the installing page to mention the
> requirement (an perhaps the user's guide).  I updated the README in
> the src distro.  I still haven't got my build pipeline for the htdocs
> and user's guide going on my laptop after my old build computer died,
> a good indication that both are too complicated

Yes, I am set up to build the html docs (in fact, I have been working a bit on 
the users guide this morning.) I'll update the webpage this afternoon.

Darren

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel