[matplotlib-devel] XAxis/YAxis set_ticks_position() behaviour

2010-07-15 Thread Ben North
Hi,

Firstly, excellent to see matplotlib reach its 1.0 release!

I came across an inconsistency in the way XAxis and YAxis behave in the
set_ticks_position() method.  If you remove the X-axis ticks with

my_axes.xaxis.set_ticks_position('none')

it leaves the labels alone, whereas if you do the same on the Y-axis:

my_axes.yaxis.set_ticks_position('none')

it removes both sets of labels.  The docstring for the X-axis method
says "'none' and 'both' affect only the ticks, not the labels", and
although the Y-axis docstring doesn't have this phrase, I guess it's
probably intended that the labels are left alone there too.  The patch
below does this.

Thanks,

Ben.



--- ORIG--axis.py   2010-07-15 10:37:08.68000 +0100
+++ axis.py 2010-07-15 10:43:14.000195000 +0100
@@ -1906,8 +1906,8 @@
 self.set_tick_params(which='both', right=True,
  left=True)
 elif position == 'none':
-self.set_tick_params(which='both', right=False, labelright=False,
- left=False, labelleft=False)
+self.set_tick_params(which='both', right=False,
+ left=False)
 elif position == 'default':
 self.set_tick_params(which='both', right=True, labelright=False,
  left=True, labelleft=True)

--
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
___
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel


Re: [matplotlib-devel] XAxis/YAxis set_ticks_position() behaviour

2010-07-15 Thread Eric Firing
On 07/14/2010 11:46 PM, Ben North wrote:
> Hi,
>
> Firstly, excellent to see matplotlib reach its 1.0 release!
>
> I came across an inconsistency in the way XAxis and YAxis behave in the
> set_ticks_position() method.  If you remove the X-axis ticks with
>
>  my_axes.xaxis.set_ticks_position('none')
>
> it leaves the labels alone, whereas if you do the same on the Y-axis:
>
>  my_axes.yaxis.set_ticks_position('none')
>
> it removes both sets of labels.  The docstring for the X-axis method
> says "'none' and 'both' affect only the ticks, not the labels", and
> although the Y-axis docstring doesn't have this phrase, I guess it's
> probably intended that the labels are left alone there too.  The patch
> below does this.

Ben,

Thank you.  Behavior and docstring are fixed in 8554, 8555.

Eric

>
> Thanks,
>
> Ben.
>
>
>
> --- ORIG--axis.py   2010-07-15 10:37:08.68000 +0100
> +++ axis.py 2010-07-15 10:43:14.000195000 +0100
> @@ -1906,8 +1906,8 @@
>   self.set_tick_params(which='both', right=True,
>left=True)
>   elif position == 'none':
> -self.set_tick_params(which='both', right=False, labelright=False,
> - left=False, labelleft=False)
> +self.set_tick_params(which='both', right=False,
> + left=False)
>   elif position == 'default':
>   self.set_tick_params(which='both', right=True, labelright=False,
>left=True, labelleft=True)
>
> --
> This SF.net email is sponsored by Sprint
> What will you do first with EVO, the first 4G phone?
> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
> ___
> Matplotlib-devel mailing list
> Matplotlib-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel


--
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
___
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel