Re: [matplotlib-devel] make.osx: should it set --prefix=$PREFIX ?
Fine by me as well. Maybe modify the documentation to point to
mpl_install_std. How should we proceed?
-- Fernando
On Fri, Mar 4, 2011 at 23:55, Eric Firing wrote:
> On 03/04/2011 09:09 PM, Jouni K. Seppänen wrote:
> > Eric Firing writes:
> >
> >> What is the rationale for removing the --prefix argument? It doesn't
> >> prevent one from installing in the standard location.
> >
> > The $PREFIX variables is used by make.osx for two different purposes:
> > (1) the dependencies are installed under $PREFIX and the extensions are
> > compiled to use them from there, in order to avoid version mismatches
> > with libraries in /usr, /opt, etc.; (2) the "setup.py install" command
> > is given --prefix $PREFIX as an argument so that matplotlib gets
> > installed in a non-standard location.
> >
> > I like just (1), so to install matplotlib I do "make -n mpl_install"
> > and edit the command to remove the prefix. Or, actually, edit it to be
> > "setupegg.py develop". The Makefile sets a bunch of environment
> > variables that are needed for the compilation to succeed with the
> > downloaded dependencies.
> >
> > How about putting the environment assignments in just one place and
> > creating multiple installation targets, maybe like this:
> >
> >
> > run_cmd:
> > export PKG_CONFIG_PATH=${PKG_CONFIG_PATH} \
> > (etc) \
> > ${PYTHON} ${CMD}
> >
> > mpl_build:
> > run_cmd CMD="setup.py build"
> >
> > mpl_install:
> > run_cmd CMD="setup.py install --prefix=${PREFIX}"
> >
> > mpl_install_std:
> > run_cmd CMD="setup.py install"
> >
> > mpl_develop:
> > run_cmd CMD="setupegg.py develop"
> >
> >
>
> That looks to me like a good solution.
>
> Eric
>
>
>
>
> --
> What You Don't Know About Data Connectivity CAN Hurt You
> This paper provides an overview of data connectivity, details
> its effect on application quality, and explores various alternative
> solutions. http://p.sf.net/sfu/progress-d2d
> ___
> Matplotlib-devel mailing list
> Matplotlib-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>
--
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d___
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] make.osx: should it set --prefix=$PREFIX ?
Fernando Garcia Bermudez writes: > Fine by me as well. Maybe modify the documentation to point to > mpl_install_std. How should we proceed? I'll make some other cleanups and create some commits that you can include in your pull request. -- Jouni K. Seppänen http://www.iki.fi/jks -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] make.osx: should it set --prefix=$PREFIX ?
Jouni K. Seppänen writes: > Fernando Garcia Bermudez writes: > >> Fine by me as well. Maybe modify the documentation to point to >> mpl_install_std. How should we proceed? > > I'll make some other cleanups and create some commits that you can > include in your pull request. I did this now and created a pull request for you, so if you pull it into your branch, it should update your pull request. I realized it's unnecessary to have all those shell commands to export the variables, since make can export them for us. I tried out the other targets, but I couldn't get "binaries" to work. The bdist_mpkg plugin complains something about a lacking 64-bit wxpython. Could someone who has previously been able to create the installer try it on my make.osx branch? (That is, git add remote jkseppan git://github.com/jkseppan/matplotlib.git git fetch jkseppan git checkout jkseppan/make.osx make -f make.osx clean deps mpl_build binaries PYVERSION=2.6 PREFIX=...) This change will likely not merge cleanly into master; if people agree to merge this into the maintenance branch, I can do the merge into master. -- Jouni K. Seppänen http://www.iki.fi/jks -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] make.osx: should it set --prefix=$PREFIX ?
On 03/05/2011 12:03 AM, Jouni K. Seppänen wrote: > Jouni K. Seppänen writes: > >> Fernando Garcia Bermudez writes: >> >>> Fine by me as well. Maybe modify the documentation to point to >>> mpl_install_std. How should we proceed? >> >> I'll make some other cleanups and create some commits that you can >> include in your pull request. > > I did this now and created a pull request for you, so if you pull it > into your branch, it should update your pull request. I realized it's > unnecessary to have all those shell commands to export the variables, > since make can export them for us. > > I tried out the other targets, but I couldn't get "binaries" to > work. The bdist_mpkg plugin complains something about a lacking 64-bit > wxpython. Could someone who has previously been able to create the > installer try it on my make.osx branch? (That is, > >git add remote jkseppan git://github.com/jkseppan/matplotlib.git >git fetch jkseppan >git checkout jkseppan/make.osx >make -f make.osx clean deps mpl_build binaries PYVERSION=2.6 PREFIX=...) > > This change will likely not merge cleanly into master; if people agree > to merge this into the maintenance branch, I can do the merge into > master. > Jouni, While in the middle of overhauling make.osx, I think it makes sense to go ahead and fix the ARCH_FLAGS variable, and then use it throughout in place of the hardwired ARCH_FLAGS. That will make it easier to use the makefile on a range of OS X and Xcode versions. It is also simply a cleaner design. Newer versions of the libraries can also be used, although this is not critical. v1.0.x still needs the 1.2 series of libpng, but master can now handle ZLIBVERSION=1.2.5 PNGVERSION=1.5.1 FREETYPEVERSION=2.4.4 Eric -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] make.osx: should it set --prefix=$PREFIX ?
I tested your changes (up to mpl_install_std) and merged the pull request. Upon solving the binaries issue we could probably close this pull request. Or we could open an issue for that particular matter. -- Fernando On Sat, Mar 5, 2011 at 02:03, Jouni K. Seppänen wrote: > Jouni K. Seppänen writes: > > > Fernando Garcia Bermudez writes: > > > >> Fine by me as well. Maybe modify the documentation to point to > >> mpl_install_std. How should we proceed? > > > > I'll make some other cleanups and create some commits that you can > > include in your pull request. > > I did this now and created a pull request for you, so if you pull it > into your branch, it should update your pull request. I realized it's > unnecessary to have all those shell commands to export the variables, > since make can export them for us. > > I tried out the other targets, but I couldn't get "binaries" to > work. The bdist_mpkg plugin complains something about a lacking 64-bit > wxpython. Could someone who has previously been able to create the > installer try it on my make.osx branch? (That is, > > git add remote jkseppan git://github.com/jkseppan/matplotlib.git > git fetch jkseppan > git checkout jkseppan/make.osx > make -f make.osx clean deps mpl_build binaries PYVERSION=2.6 PREFIX=...) > > This change will likely not merge cleanly into master; if people agree > to merge this into the maintenance branch, I can do the merge into > master. > > -- > Jouni K. Seppänen > http://www.iki.fi/jks > > > > -- > What You Don't Know About Data Connectivity CAN Hurt You > This paper provides an overview of data connectivity, details > its effect on application quality, and explores various alternative > solutions. http://p.sf.net/sfu/progress-d2d > ___ > Matplotlib-devel mailing list > Matplotlib-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel > -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] make.osx: should it set --prefix=$PREFIX ?
On Sat, Mar 5, 2011 at 10:34, Eric Firing wrote: > Newer versions of the libraries can also be used, although this is not > critical. v1.0.x still needs the 1.2 series of libpng, but master can > now handle > > ZLIBVERSION=1.2.5 > PNGVERSION=1.5.1 > FREETYPEVERSION=2.4.4 > We have to make sure to check/update the urls to the new versions of these dependencies. I'm unsure whether having variables for the versions makes sense when the urls change over time (e.g.: the libpng currently in use in make.osx was moved into the older-releases folder of the libpng repo, prompting the need for this pull request in the first place). -- Fernando -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
[matplotlib-devel] csd demo image clipped
Hi, Definitely a minor issue but I see the csd demo image a bit clipped from the left and the top subplot mixed with the bottom one on http://matplotlib.sourceforge.net/api/pyplot_api.html#matplotlib.pyplot.csd Looks fine when I locally run the csd_demo.py example. -- Gökhan -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] make.osx: should it set --prefix=$PREFIX ?
Eric Firing writes: > While in the middle of overhauling make.osx, I think it makes sense to > go ahead and fix the ARCH_FLAGS variable, and then use it throughout in > place of the hardwired ARCH_FLAGS. That will make it easier to use the > makefile on a range of OS X and Xcode versions. It is also simply a > cleaner design. I think I fixed this - my commit is now part of https://github.com/matplotlib/matplotlib/pull/17 > Newer versions of the libraries can also be used, although this is not > critical. v1.0.x still needs the 1.2 series of libpng, but master can > now handle > > ZLIBVERSION=1.2.5 > PNGVERSION=1.5.1 > FREETYPEVERSION=2.4.4 I think we should keep the changes to v1.0.x minimal - in master it makes sense to upgrade to the newest versions. I'll make a separate pull request for master. -- Jouni K. Seppänen http://www.iki.fi/jks -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] make.osx: should it set --prefix=$PREFIX ?
Fernando Garcia Bermudez writes: > I tested your changes (up to mpl_install_std) and merged the pull request. > Upon solving the binaries issue we could probably close this pull request. > Or we could open an issue for that particular matter. Thanks; pull request #17 is IMHO ready for merging into v1.0.x, but let's wait to see if anyone has further comments. I created pull request #30 for merging into master; that one also has newer dependency versions as suggested by Eric. On master, I was able to almost run "make binaries", except somehow bdist_mpkg didn't agree with the makefile about all the version numbers in the mpkg filename, so hdiutil failed due to a missing input file. I do think that problem is unrelated to these changes. -- Jouni K. Seppänen http://www.iki.fi/jks -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
