Re: Help testing release candidate / mc-4.8.27-rc1
I ran the following and still have lots of warnings during make. ``` ╭─reagle@hom ~/tmp/mc-4.8.27-pre1 ╰─➤ CFLAGS="-target arm64-apple-macos11" \ 130 ↵ ./configure \ --host=aarch64-apple-darwin \ --target=aarch64-apple-darwin \ --build=aarch64-apple-darwin ``` ___ mc mailing list https://mail.gnome.org/mailman/listinfo/mc
Re: Help testing release candidate / mc-4.8.27-rc1
Hi there, TLDR; I would appreciate if you could please test the following tarball on your systems and report any blocker regressions as compared to the previous 4.8.26 release: https://www.midnight-commander.org/nopaste/tarball/mc-4.8.27-pre1.tar.xz $ sha256sum mc-4.8.27-pre1.tar.xz d922e4175a20779549c4a9746bbe169d4acd2a83b2e14d1d6dfd2cbec32eb12b mc-4.8.27-pre1.tar.xz I've built this tarball out of the latest master with translations from Transifex pulled in on a fresh Fedora 33 VM, which I'm also going to use to build the final release in about a week from now if nothing serious comes up. Many thanks! ___ mc mailing list https://mail.gnome.org/mailman/listinfo/mc Hi, i tried and endet up with: make[3]: Verzeichnis „/home/joe/test/mc/mc-4.8.27-pre1/lib/tty“ wird betreten CC tty-slang.lo tty-slang.c: In function ‘do_define_key’: tty-slang.c:206:26: error: ‘SLFUTURE_CONST’ undeclared (first use in this function); did you mean ‘SLCONST’? seq = SLtt_tgetstr ((SLFUTURE_CONST char *) strcap); ^~ SLCONST tty-slang.c:206:26: note: each undeclared identifier is reported only once for each function it appears in tty-slang.c:206:41: error: expected ‘)’ before ‘char’ seq = SLtt_tgetstr ((SLFUTURE_CONST char *) strcap); ^~~~ tty-slang.c:206:49: error: expected ‘)’ before ‘strcap’ seq = SLtt_tgetstr ((SLFUTURE_CONST char *) strcap); ^~ tty-slang.c:202:38: warning: unused parameter ‘strcap’ [-Wunused-parameter] do_define_key (int code, const char *strcap) ^~ tty-slang.c: In function ‘tty_shutdown’: tty-slang.c:358:29: error: ‘SLFUTURE_CONST’ undeclared (first use in this function); did you mean ‘SLCONST’? op_cap = SLtt_tgetstr ((SLFUTURE_CONST char *) "op"); ^~ SLCONST tty-slang.c:358:44: error: expected ‘)’ before ‘char’ op_cap = SLtt_tgetstr ((SLFUTURE_CONST char *) "op"); ^~~~ tty-slang.c:358:52: error: expected ‘)’ before string constant op_cap = SLtt_tgetstr ((SLFUTURE_CONST char *) "op"); ^~~~ tty-slang.c: In function ‘tty_keypad’: tty-slang.c:455:36: error: ‘SLFUTURE_CONST’ undeclared (first use in this function); did you mean ‘SLCONST’? keypad_string = SLtt_tgetstr ((SLFUTURE_CONST char *) (set ? "ks" : "ke")); ^~ SLCONST tty-slang.c:455:51: error: expected ‘)’ before ‘char’ keypad_string = SLtt_tgetstr ((SLFUTURE_CONST char *) (set ? "ks" : "ke")); ^~~~ tty-slang.c: In function ‘tty_tgetstr’: tty-slang.c:760:27: error: ‘SLFUTURE_CONST’ undeclared (first use in this function); did you mean ‘SLCONST’? return SLtt_tgetstr ((SLFUTURE_CONST char *) cap); ^~ SLCONST tty-slang.c:760:42: error: expected ‘)’ before ‘char’ return SLtt_tgetstr ((SLFUTURE_CONST char *) cap); ^~~~ tty-slang.c:760:50: error: expected ‘)’ before ‘cap’ return SLtt_tgetstr ((SLFUTURE_CONST char *) cap); ^~~ tty-slang.c:758:26: warning: unused parameter ‘cap’ [-Wunused-parameter] tty_tgetstr (const char *cap) ^~~ tty-slang.c:761:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ make[3]: *** [Makefile:549: tty-slang.lo] Fehler 1 Opensuse 15.1 Kernel 4.12.14-lp151.28.91-default running here gcc is gcc7 glibc is 2.26 libslang2 is 2.3 don't waste any time on this if it's onyl my fault or too old system / libs running here... -- cu jth ___ mc mailing list https://mail.gnome.org/mailman/listinfo/mc
Re: Help testing release candidate / mc-4.8.27-rc1
On Tue, 3 Aug 2021, Andreas wrote: This can happen if configure and build step run with different compiler. At configure step (exactly at mc-cflags.m4) compiler flags are tested against compiler support, if supported it will added to build/make config. Thanks for the tip! Maybe setting the compiler in my command is actually not necessary and only causes those warnings? Joseph, could you please try a clean build without setting "CC"? Thanks! -- Sincerely yours, Yury V. Zaytsev ___ mc mailing list https://mail.gnome.org/mailman/listinfo/mc
Re: Help testing release candidate / mc-4.8.27-rc1
On Tue, 3 Aug 2021, Andreas wrote: This can happen if configure and build step run with different compiler. At configure step (exactly at mc-cflags.m4) compiler flags are tested against compiler support, if supported it will added to build/make config. Thanks for the tip! Maybe setting the compiler in my command is actually not necessary and only causes those warnings? Joseph, could you please try a clean build without setting "CC"? Thanks! -- Sincerely yours, Yury V. Zaytsev ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.27-rc1
út 3. 8. 2021 v 12:22 odesílatel Yury V. Zaytsev napsal: > On Mon, 2 Aug 2021, Joseph Reagle wrote: > > > (It doesn't include panel scrollbars from #4256?). > > Unfortunately, the author disappeared as suddenly as he appeared and the > patch was left unfinished - thus it will not make it in this release. > I'm the author of that unfinished scrollbars patch. Sorry about the delays but the proper implementation with the widget group was not so easy as I expected. It just takes more time, I'm still on that. On top of that, it is a vacations season. So it should be in a month or so but not in this release. But I like that someone misses my patch :-) Aleš Janda ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.27-rc1
út 3. 8. 2021 v 12:22 odesílatel Yury V. Zaytsev napsal: > On Mon, 2 Aug 2021, Joseph Reagle wrote: > > > (It doesn't include panel scrollbars from #4256?). > > Unfortunately, the author disappeared as suddenly as he appeared and the > patch was left unfinished - thus it will not make it in this release. > I'm the author of that unfinished scrollbars patch. Sorry about the delays but the proper implementation with the widget group was not so easy as I expected. It just takes more time, I'm still on that. On top of that, it is a vacations season. So it should be in a month or so but not in this release. But I like that someone misses my patch :-) Aleš Janda ___ mc mailing list https://mail.gnome.org/mailman/listinfo/mc
Re: Help testing release candidate / mc-4.8.27-rc1
On Mon, 2 Aug 2021, Joseph Reagle wrote: I ran the command you suggested and the make, make install, creates a binary in /usr/local/bin (though using homebrew arm64 commands in /opt/homebrew) and it seems to work fine. Thanks for the confirmation! Then specifying triplets manually on Apple Silicon will be the workaround I will put in the release notes, until we get proper autotools support (hopefully) with the next release. If you are unhappy with /usr/local, you can always specify custom prefix with --prefix=$HOME/opt/mc or so. (It doesn't include panel scrollbars from #4256?). Unfortunately, the author disappeared as suddenly as he appeared and the patch was left unfinished - thus it will not make it in this release. BTW: During make, I get tons of warnings: warning: unknown warning option '-Wformat-signedness' [-Wunknown-warning-option] warning: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Wunknown-warning-option] warning: unknown warning option '-Wmissing-parameter-type' [-Wunknown-warning-option] warning: unknown warning option '-Wunused-but-set-variable'; did you mean '-Wunused-const-variable'? I've put our chief warning officer on CC, hopefully he can say something about that - apparently our compiler flag detection is not working correctly and warning flags are supplied even though they are not supported by the compiler... Could you please post the complete build log as a compressed attachment? -- Sincerely yours, Yury V. Zaytsev ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.27-rc1
On Mon, 2 Aug 2021, Joseph Reagle wrote: I ran the command you suggested and the make, make install, creates a binary in /usr/local/bin (though using homebrew arm64 commands in /opt/homebrew) and it seems to work fine. Thanks for the confirmation! Then specifying triplets manually on Apple Silicon will be the workaround I will put in the release notes, until we get proper autotools support (hopefully) with the next release. If you are unhappy with /usr/local, you can always specify custom prefix with --prefix=$HOME/opt/mc or so. (It doesn't include panel scrollbars from #4256?). Unfortunately, the author disappeared as suddenly as he appeared and the patch was left unfinished - thus it will not make it in this release. BTW: During make, I get tons of warnings: warning: unknown warning option '-Wformat-signedness' [-Wunknown-warning-option] warning: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Wunknown-warning-option] warning: unknown warning option '-Wmissing-parameter-type' [-Wunknown-warning-option] warning: unknown warning option '-Wunused-but-set-variable'; did you mean '-Wunused-const-variable'? I've put our chief warning officer on CC, hopefully he can say something about that - apparently our compiler flag detection is not working correctly and warning flags are supplied even though they are not supported by the compiler... Could you please post the complete build log as a compressed attachment? -- Sincerely yours, Yury V. Zaytsev ___ mc mailing list https://mail.gnome.org/mailman/listinfo/mc
