Re: Help: meaning of the panelize command in left/right menus

2017-02-17 Thread Cristian Rigamonti
On Thu, Feb 16, 2017 at 01:25:22PM +1300, William Kimber wrote:
> Briefly,  if you do a search over several directories you can put all those
> files into a single panel. Not withstanding that they are from different
> directories.

I'm not sure I understand what you mean here; anyway I noticed that if you do a
search using the "Find file" (M-?) command, choose "Panelize" (at the bottom
of the "Find File" popup window), then change to some other directory (thus
exiting from panelized mode), if you now choose Left -> Panelize, you can recall
the panelized view of the last "Find file" results. Is this what you mean?

However this seems to work only with panelized results coming from the
"Find file" command, not with results from the "External panelize" command:
if I change directory, and then choose Left -> Panelize I get an empty panel.
Is this a bug?

Cri

___
mc mailing list
https://mail.gnome.org/mailman/listinfo/mc


Re: Help: meaning of the panelize command in left/right menus

2017-02-15 Thread cri
On Wed, Feb 15, 2017 at 04:27:42AM +0200, Mooffie wrote:
> 
> I believe you opened a ticket for this. Please also link to the ticket

Well, yes: http://midnight-commander.org/ticket/3767

> or we'll have two crowds discussing this independently and therefore
> wasting their time.

In fact, that was more a help request than a bug report: I really can't make 
sense
of that menu item, so I think there's nothing much to "discuss", rather to 
explain
what the menu command is supposed to do.

Anyway, I did my homework and had a look at the source. 

The menu item is defined in src/filemanager/midnight.c and calls CK_Panelize,
which calls cd_panelize_cmd(), defined in src/filemanager/panelize.c,
which calls do_panelize_cd() (defined in the same file).

Unfortunately I don't know enough C and the mc codebase to understand what
do_panelize_cd() actually does, and there are no comments in the source code. :(

So I browsed the trac history of src/filemanager/panelize.c and found that
do_panelize_cd() was introduced in this commit:

  
http://midnight-commander.org/changeset/5c252726f1b52863a75b0118603a0e053923eded

which claims to fix this bug:

  http://midnight-commander.org/ticket/275

The discussion in the ticket deals almost uniquely with adding a ".." entry to 
the
panelized panel list, to get out of panelized mode; no references to the 
"Panelize"
Left/Right menu entry.

The commit message for the commit linked above in fact claims:

  "added menu entry Left\Panelize, to restore panelized panel"

but I still can't understand what "restore panelized panel" means
(indeed: all that command seems to do is to show an empty panelized panel).

So that's all the information I could squeeze from the source and trac.

I hope some developer can have a look at
http://midnight-commander.org/browser/src/filemanager/panelize.c
and explain what cd_panelize_cmd() and do_panelize_cd() do.

Cri
___
mc mailing list
https://mail.gnome.org/mailman/listinfo/mc


Re: Help: meaning of the panelize command in left/right menus

2017-02-14 Thread Mooffie
On 2/15/17, c...@linux.it  wrote:
> Hi, I can't find any information in the internal help, or man page, or
> wiki,
> about the "Panelize" command in the "Left" or "Right" menu.
>
> I suspect it is related to the (well documented) "External panelize"
> command,
> but when I select it, I'm left clueless with an empty panel.
> Now what?

I believe you opened a ticket for this. Please also link to the ticket
or we'll have two crowds discussing this independently and therefore
wasting their time.
___
mc mailing list
https://mail.gnome.org/mailman/listinfo/mc


Help: meaning of the panelize command in left/right menus

2017-02-14 Thread cri
Hi, I can't find any information in the internal help, or man page, or wiki,
about the "Panelize" command in the "Left" or "Right" menu.

I suspect it is related to the (well documented) "External panelize" command,
but when I select it, I'm left clueless with an empty panel.
Now what?

Cri
___
mc mailing list
https://mail.gnome.org/mailman/listinfo/mc