Re: [patch] fishfs bugs

2003-02-16 Thread Arpi
Hi,

  the first chunk is trivial: you check for got_interrupt but it is always a
  non-zero number, actually the address of teh got_interrupt() function :))
  you probably noticed that it doesn't work so that ! was removed :)
  
  the second part is probably bug, i see no sense of checking for
  got_interrupt() if interrupt check is disabled...
 
 First part is okay, but I have doubts about second

what?

 one. disable_interrupt_key() has something to do ^c, IIRC.

exactly.
disable_interrupt_key disables the SIGINT (ctrl^c) handler,
enable_interrupt_key enables it.
got_interrupt() returns 1 if ctrl^c was pressed since last call.
(the SIGINT handler (enabled by enable_interrupt_key) sets a flag
when user press ctrl^c, and this flag is query-able with got_interrupt)
it only works if ctrl^c is enabled at all (enable_interrupt_key),
so calling it after disable_interrupt_key has no sense.
RTFS...


A'rpi / Astral  ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
However, many people beg for its inclusion in Debian. Why? - Gabucino
  Because having new software in Debian is good. - Josselin Mouette
Because having good software in Debian is new. - Gabucino
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel



Fixing resolve_symlink() in ftpfs.c

2003-02-16 Thread Arpi
Hi,

Is anyone working on teh $SUBJ ? I guess no :(
(that few-pages long code between #ifdef FIXME_LATER since ages)
I've started it today, but after many hours of grepping and patching i feel
lost. Could someone please explain the transition from bucket+dcache
(4.1.35) to me+super+dir (4.6.0) structures?
Is the directory cache (at least for the current directory, just filled in
dir_load()) accessible (searchable/readable) from ftpfs.c at all?


A'rpi / Astral  ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
However, many people beg for its inclusion in Debian. Why? - Gabucino
  Because having new software in Debian is good. - Josselin Mouette
Because having good software in Debian is new. - Gabucino
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel