Re: Restoring the functionality of Alt-o
Hello Miguel, Sunday, January 30, 2005, 9:40:03 AM, you wrote: MdI A long time ago I added Alt-o as a binding that would help in MdI navigating directories. The idea is that in one panel you press Alt-o, MdI and if the selection is on a directory, it will load the contents of the MdI highlighted directory into the other panel. If no directory was MdI selected, this was a no-op. MdI At some point this behavior was removed from mc, and now instead it MdI just loads the current directory on the other panel, which is not very MdI useful for navigating anything. http://mail.gnome.org/archives/mc-devel/2002-November/msg00039.html MdI I remember having this discussion with Pavel but I forget the MdI rationale for it. I would like to get this change reverted in CVS. Any MdI objections? I'm agreed with you. Old behavior of ALT-O is more good. -- Best regards, Pavelmailto:[EMAIL PROTECTED] ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Restoring the functionality of Alt-o
Hello Miguel, Pavel Sunday, January 30, 2005, 9:40:03 AM, you wrote: MdI A long time ago I added Alt-o as a binding that would help in MdI navigating directories. The idea is that in one panel you press Alt-o, MdI and if the selection is on a directory, it will load the contents of the MdI highlighted directory into the other panel. If no directory was MdI selected, this was a no-op. MdI At some point this behavior was removed from mc, and now instead it MdI just loads the current directory on the other panel, which is not very MdI useful for navigating anything. http://mail.gnome.org/archives/mc-devel/2002-November/msg00039.html MdI I remember having this discussion with Pavel but I forget the MdI rationale for it. I would like to get this change reverted in CVS. Any MdI objections? I'm agreed with you. Old behavior of ALT-O is more good. And now it seems it was some harry move to remove '..' from directory listing. -- Regards, Andrew V. Samoilov GET INTERNET ACCESS FROM BCS! http://www.bcs.zp.ua Join BCS today! For your FREE webmail, visit: http://email.zp.ua/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Restoring the functionality of Alt-o
Hello, On Mon, 31 Jan 2005, Jindrich Novy wrote: 2) Create an alternate keyboard shortcut such as Alt-i that acts like the old Alt-o. 3) Keep Alt-o shortcut and switch between old/new Alt-o in Options/Configuration. Personally I vote for 2) because mc won't lose any of its functionality and it won't need too much work IMHO. I vote for solution number 3. I never was aware of the old Alt + O functionality but I frequently use the new behaviour. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Restoring the functionality of Alt-o
Hello, Let me propose some possibilities: 1) Revert Alt-o - annoyed users because Alt-o suddenly changes. 2) Create an alternate keyboard shortcut such as Alt-i that acts like the old Alt-o. 3) Keep Alt-o shortcut and switch between old/new Alt-o in Options/Configuration. Personally I vote for 2) because mc won't lose any of its functionality and it won't need too much work IMHO. May be 2) and 3) both? To avoid discrimination of old-style (or new-style) users... You guys raise good points. I will make it a configuration feature, and restore the old behavior by default. Miguel. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: start time
Hello, Miguel, I am glad to see you here again.
I have applied this patch to the CVS repository with a few changes
(configure.in checks, plus made sure that the style matched the rest of
the code).
I think this patch is reasonable.
BTW, I did not add ChangeLog entries for these getgrouplist() patches.
--
Regards,
Andrew V. Samoilov
GET INTERNET ACCESS FROM BCS! http://www.bcs.zp.ua
Join BCS today! For your FREE webmail, visit: http://email.zp.ua/
src/ChangeLog:
* utilunix.c (init_groups): Use glib memory allocation functions.
--- utilunix.c~ Mon Jan 31 09:28:11 2005
+++ utilunix.c Mon Jan 31 15:44:24 2005
@@ -94,33 +94,32 @@ void init_groups (void)
#ifdef HAVE_GETGROUPLIST
{
-gid_t *groups = NULL;
-int ng = 1;
-//struct group *grp;
-gid_t *newgroups = NULL;
-
-groups = (gid_t *) malloc(ng * sizeof(gid_t));
+ gid_t *groups = g_new (gid_t, 1);
+ int ng = 1;
+ gid_t *newgroups = NULL;
-if (getgrouplist(pwd-pw_name, pwd-pw_gid, groups, ng) == -1) {
-newgroups = (gid_t *) malloc(ng * sizeof(gid_t));
-if (newgroups != NULL) {
-free (groups);
-groups = newgroups;
-getgrouplist (pwd-pw_name, pwd-pw_gid, groups, ng);
-} else
- ng = 1;
-}
+ if (getgrouplist (pwd-pw_name, pwd-pw_gid, groups, ng) == -1) {
+ newgroups = g_new (gid_t, ng);
+ if (newgroups != NULL) {
+ g_free (groups);
+ groups = newgroups;
+ getgrouplist (pwd-pw_name, pwd-pw_gid, groups, ng);
+ } else
+ ng = 1;
+ }
-for (i = 0; i ng; i++) {
-grp = getgrgid(groups[i]);
-if (grp != NULL !g_tree_lookup (current_user_gid,
GUINT_TO_POINTER ((int) grp-gr_gid))) {
-g_tree_insert (current_user_gid,
- GUINT_TO_POINTER ((int) grp-gr_gid),
- g_strdup (grp-gr_name));
-}
-}
+ for (i = 0; i ng; i++) {
+ grp = getgrgid (groups[i]);
+ if (grp != NULL
+!g_tree_lookup (current_user_gid,
+ GUINT_TO_POINTER ((int) grp-gr_gid))) {
+ g_tree_insert (current_user_gid,
+ GUINT_TO_POINTER ((int) grp-gr_gid),
+ g_strdup (grp-gr_name));
+ }
+ }
- free(groups);
+ g_free (groups);
}
#else
setgrent ();
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Debian security advisory
Hi Andrew, On Mon, 2005-01-31 at 09:20, Andrew V. Samoilov wrote: Yup. Andrew, could you please also post these patches for CAN vulnerabilities here? That would come in handy :) . Well, all of these are backports from our CVS. It seems it was noticed in the description. Sure, I am aware of that. However posting these to the list can be very useful for people involved with legacy systems, like myself for Fedora Legacy. It wasn't that hard to extract the relevant patches from the patch set, but still... :) Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: start time
Hey, I have applied this patch to the CVS repository with a few changes (configure.in checks, plus made sure that the style matched the rest of the code). I think this patch is reasonable. BTW, I did not add ChangeLog entries for these getgrouplist() patches. This patch looks good, could you commit? Miguel ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
