Re: Fwd: some problems with do_*_ca_mode()
Hi Andrey, Leonard, On Fri, 2005-11-18 at 14:26 +0100, Leonard den Ottolander wrote: Hi Andrey, On Fri, 2005-11-18 at 11:03 +0700, Andrey V. Malyshev wrote: I can not test it under the real xterm console (with X), I have not one. I think it is nessessary before commiting, can everyone do it? Maybe somebody will beat me to it. Otherwise I'll do. Even though your explanation sounds senisible I'd like to hear some other peoples opinion though. I agree with Andrey here, that we should use ti and te sequences acquired from termcap database instead of hardcoded ones. The problem is that Andrey uses direct putp() calls. The putp() belongs to ncurses and it doesn't seem to work when slang support is enabled. I propose this way to write termcap sequences to the terminal what should work even with slang: #ifdef HAVE_SLANG SLtt_write_string (ti_cap); #else putp (ti_cap); #endif and similarly for the te_cap. The question is whether not to call SLtt_initialize () and friends in case of slang instead as slang takes care of setting proper ti/te sequences itself. Jindrich -- Jindrich Novy [EMAIL PROTECTED], http://people.redhat.com/jnovy/ (o_ _o) //\ The worst evil in the world is refusal to think. //\ V_/_ _\_V ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[PATCH] mini status bar unaligned
Hi mc-devel,
the main panel in the default Full file list is unaligned with mini
status bar, to reproduce:
1) go to Left/Listing mode...
2) enable Full file list (likely enabled by default)
3) enable user Mini status
you see:
Size and MTime field is unaligned with Size/Perm field in mini status
bar what is just ugly.
ChangeLog:
2005-11-23 Jindrich Novy [EMAIL PROTECTED]
* view.c (struct formats): Align mini status with the main
panel.
Jindrich
--
Jindrich Novy [EMAIL PROTECTED], http://people.redhat.com/jnovy/
(o_ _o)
//\ The worst evil in the world is refusal to think. //\
V_/_ _\_V
--- mc-4.6.1a/src/screen.c.ministatus 2005-11-17 22:01:32.0 +0100
+++ mc-4.6.1a/src/screen.c 2005-11-17 22:02:31.0 +0100
@@ -471,7 +471,7 @@ static struct {
{ mtime, 12, 0, J_RIGHT, N_(MTime), 1, string_file_mtime, (sortfn *) sort_time },
{ atime, 12, 0, J_RIGHT, N_(ATime), 1, string_file_atime, (sortfn *) sort_atime },
{ ctime, 12, 0, J_RIGHT, N_(CTime), 1, string_file_ctime, (sortfn *) sort_ctime },
-{ perm, 10, 0, J_LEFT, N_(Permission),1,string_file_permission, NULL },
+{ perm, 12, 0, J_CENTER, N_(Permission),1,string_file_permission, NULL },
{ mode, 6, 0, J_RIGHT, N_(Perm), 1, string_file_perm_octal, NULL },
{ nlink, 2, 0, J_RIGHT, N_(Nl), 1, string_file_nlinks, (sortfn *) sort_links },
{ inode, 5, 0, J_RIGHT, N_(Inode), 1, string_inode, (sortfn *) sort_inode },
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] mini status bar unaligned
Hello Pavel, On Wed, 2005-11-23 at 15:35 -0500, Pavel Roskin wrote: If you want alignment, use perm:12 instead of perm in the mini-status line. Thanks for the workaround, the patch is not needed then if the width can be specified on the format line explicitely. Jindrich -- Jindrich Novy [EMAIL PROTECTED], http://people.redhat.com/jnovy/ (o_ _o) //\ The worst evil in the world is refusal to think. //\ V_/_ _\_V ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[PATCH] spec.syntax misses %check
Hello mc-devel, spec.syntax ignores the %check macro. The following patch adds highlighting of it in spec files. Thanks, Jindrich -- Jindrich Novy [EMAIL PROTECTED], http://people.redhat.com/jnovy/ (o_ _o) //\ The worst evil in the world is refusal to think. //\ V_/_ _\_V --- mc-4.6.1a/syntax/spec.syntax.rpmsyntax 2004-12-28 14:23:34.0 +0100 +++ mc-4.6.1a/syntax/spec.syntax 2005-09-05 21:47:03.0 +0200 @@ -41,6 +41,7 @@ keyword whole Url: green keyword whole linestart %build red +keyword whole linestart %check red keyword whole linestart %clean red keyword whole linestart %changelog red keyword whole linestart %description red ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] spec.syntax misses %check
On Wed, 2005-11-23 at 22:05 +0100, Jindrich Novy wrote: Hello mc-devel, spec.syntax ignores the %check macro. The following patch adds highlighting of it in spec files. Applied. Thank you! -- Regards, Pavel Roskin ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: some problems with do_*_ca_mode()
Hello, Jindrich! You wrote to Leonard den Ottolander [EMAIL PROTECTED] on Wed, 23 Nov 2005 20:23:37 +0100: JN I agree with Andrey here, that we should use ti and te sequences JN acquired from termcap database instead of hardcoded ones. The problem JN is that Andrey uses direct putp() calls. The putp() belongs to ncurses JN and it doesn't seem to work when slang support is enabled. JN I propose this way to write termcap sequences to the terminal what JN should work even with slang: JN #ifdef HAVE_SLANG JN SLtt_write_string (ti_cap); JN #else JN putp (ti_cap); JN #endif JN and similarly for the te_cap. I argee, of course. Modified patch is attached. JN The question is whether not to call SLtt_initialize () and friends in JN case of slang instead as slang takes care of setting proper ti/te JN sequences itself. Hmm. For now we combine this approaches: we call SLtt_initialize (), we let slang to take care of init itselt and prepare the SLtt_tgetstr() to work. And then we use it to obtain ti/te sequences using proper slang mechanisms. And the same in ncurses case, BTW. The main points are: from main(): #ifdef HAVE_SLANG (1)slang_init () - [ SLtt_get_terminfo() - SLtt_initialize() - Term_Init_Str = SLtt_tgetstr (ti) ] #else (2)init_curses () - [ initscr() - setupterm() ] #endif init_xterm_support (); Using [] brackets I've marked slang internal code at (1) and ncurses internal code at (2). The Term_Init_Str is internal slang variable, and it is unavailable for us in common case. This is correct for current mcslang and libslang-1.4.9 both. So, what prevents us from calling the same SLtt_tgetstr (ti) routine from init_xterm_support() under #ifdef HAVE_SLANG? -- With best regards, Andrey V. Malyshev. E-mail: [EMAIL PROTECTED] patch-xterm-ca-mode.gz Description: Binary data ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
