Re: [RFE] [PATCH] star vfs and xattr feature request

2006-01-31 Thread Pavel Tsekov
On Mon, 30 Jan 2006, Curtis Doty wrote:

 Hi, I'm the original poster of this patch to the redhat bugzilla. Where
 it was closed summarily. However, I really thing adding support for
 tarball extended attributes is increasingly valuable on selinux systems.

 And star seems to be the best tool for the job. Are there other ways of
 safely extracting files from a tarball with these extensions? I'm happy
 to rebuild the patch against the mc cvs if there is positive feedback.

 another reference:
 http://cdrecord.berlios.de/old/private/star.html

Since star archives are esentially tar archives with extended information
I don't see why a extfs solution is necessary. We can just update the
tar code to support the required extension keywords. It's just a matter of
parsing a few strings.

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: syntax switching

2006-01-31 Thread Leonard den Ottolander
Hello Andy,

On Mon, 2006-01-30 at 13:55 +0200, Andy Shevchenko wrote:
 Arny (one of developers of MPlayer) made patch for mc old version. I 
 catch the syntax highlighting toggle feature from it and adopt to a last 
 FC package. I hope, the switcher of syntax highlightind is a usefull 
 feature and should like to be added to mainstream.

I would prefer it if this patch could be integrated with the new Syntax
Highlighting dialog in the Options menu. A checkbox that respects this
toggle and an Ok button need to be added to that dialog. Maybe the
aforementioned developer could complete his patch in this respect?

Note that you can already toggle the syntax highlighting by choosing
unknown in that dialog. (This is not meant as an argument against a
global toggle.)

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: accelerators

2006-01-31 Thread Leonard den Ottolander
Hello Oswald,

On Mon, 2006-01-30 at 23:37 +0100, Oswald Buddenhagen wrote:
 ah, in the line edit. darn, that's not discoverable.

I had to had it pointed out to me as well ;) . Changed the hotkey for
that option from R to P and had to change it to M after all. 

 that's probably the
 reason why in real guis alt-something is always bound to visible
 accelerators while the clever shortcuts are hidden behind ctrl
 combinations. not that it would make them more discoverable, but at
 least there is a clean separation and no unobvious conflicts.

I've commented this in the code (edit_replace_dialog()). Not that this
makes it obvious for the user that (s)he can use Alt-p but it avoids a
developer accidently trying to change the hotkeys in a conflicting way.
I might need to add a similar comment for Alt-n and possible elsewhere
in the docs.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: syntax switching

2006-01-31 Thread Pavel Tsekov
On Tue, 31 Jan 2006, Leonard den Ottolander wrote:

 Hello Andy,

 On Mon, 2006-01-30 at 13:55 +0200, Andy Shevchenko wrote:
  Arny (one of developers of MPlayer) made patch for mc old version. I
  catch the syntax highlighting toggle feature from it and adopt to a last
  FC package. I hope, the switcher of syntax highlightind is a usefull
  feature and should like to be added to mainstream.

 I would prefer it if this patch could be integrated with the new Syntax
 Highlighting dialog in the Options menu. A checkbox that respects this
 toggle and an Ok button need to be added to that dialog. Maybe the
 aforementioned developer could complete his patch in this respect?

There is such toggle already in the editor configuration dialog box.
The point of this patch is to let the user quickly switch syntax
highlighting on and of (IMO).

 Note that you can already toggle the syntax highlighting by choosing
 unknown in that dialog. (This is not meant as an argument against a
 global toggle.)

But that is not as fast as a single key press.

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


[patch #1042] hotkeys and other improvements in hotlist

2006-01-31 Thread Pavel Tsekov

Follow-up Comment #10, patch #1042 (project mc):

Hello Bulia,

I'm about to review your patch . Unfortunately the patch contains html codes
- I guess something got messed up when you uploaded it to savannah. Can you
post the patch here under a new name ?

Thanks!

___

Reply to this item at:

  http://savannah.gnu.org/patch/?func=detailitemitem_id=1042

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


[patch #1042] hotkeys and other improvements in hotlist

2006-01-31 Thread bulia byak

Follow-up Comment #11, patch #1042 (project mc):

Done. Note that it's very old and probably won't apply to current codebase
without extensive tweaking. Please let me know if you have any problems.
___

Additional Item Attachment:

File name: hotlist.diff   Size:38 KB
patch resubmitted without quot;
http://savannah.gnu.org/patch/download.php?item_id=1042item_file_id=5852

___

Reply to this item at:

  http://savannah.gnu.org/patch/?func=detailitemitem_id=1042

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: [RFE] [PATCH] star vfs and xattr feature request

2006-01-31 Thread Curtis Doty




Pavel Tsekov wrote:

  On Mon, 30 Jan 2006, Curtis Doty wrote:

  
  
Hi, I'm the original poster of this patch to the redhat bugzilla. Where
it was closed summarily. However, I really thing adding support for
tarball extended attributes is increasingly valuable on selinux systems.

And star seems to be the best tool for the job. Are there other ways of
safely extracting files from a tarball with these extensions? I'm happy
to rebuild the patch against the mc cvs if there is positive feedback.

another reference:
http://cdrecord.berlios.de/old/private/star.html

  
  
Since star archives are esentially tar archives with extended information
I don't see why a extfs solution is necessary. We can just update the
tar code to support the required extension keywords. It's just a matter of
parsing a few strings.
  

Hrmm, maybe I'm over-thinking the problem, but according to this
http://cvs.fedora.redhat.com/viewcvs/devel/star/star-1.5-selinux.patch
it had to be compiled against the selinux headers. Is that an
appropriate direction for mc/vfs/tar.c?

../C


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


[patch #1042] hotkeys and other improvements in hotlist

2006-01-31 Thread Pavel Tsekov

Follow-up Comment #12, patch #1042 (project mc):

No problem - I'll deal with that.

___

Reply to this item at:

  http://savannah.gnu.org/patch/?func=detailitemitem_id=1042

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel