[patch #1042] hotkeys and other improvements in hotlist
Follow-up Comment #14, patch #1042 (project mc): Sure, please feel free to use a different dotdot patch. I'm not saying mine is the best. I just want this functionality to be in. As for my patch, I wasn't such an experienced programmer back then (three years ago!). I just reworked that entire file and made a diff. I was not sure it will be accepted, and in fact it was indeed ignored for years. I can do better patches now, if I know they have a good chance to be accepted. By the way, currently I still run my own patched version of pre-4.6.0, because my patches are more important for me than the progress in the main codebase. If this patch is accepted or at least used so that the functionality is in, I may consider submitting other patches from my own version for including. And if they are accepted too I will be able to move to using the latest CVS, and therefore participate in the development more actively. ___ Reply to this item at: http://savannah.gnu.org/patch/?func=detailitemitem_id=1042 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: syntax switching
Hi Pavel, On Thu, 2006-02-02 at 17:55 +0200, Pavel Tsekov wrote: The patch isn't working quite as I'd expect it. If syntax highlighting is off when opening a file - it is not possible to switch it on (i.e. see the file coloured after Ctrl + S) because the syntax rules are not loaded yet. If this is the expected behaviour i.e. the patch honours the syntax highlighting switch then I'd expect it not to change that switch on editor exit i.e. if I close the editor with syntax off it should not remember that. Ok. I'll see if I can fix it. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Segfault on loading of non existent syntax file
Hi, Ran mc from a temporary build dir and copied Syntax to ~/.mc/cedit/ . Tried editing a file and saw a segfault when the non existent syntax file is attempted to be loaded. #0 edit_get_rule (edit=0x92e8dc0, byte_index=-1) at syntax.c:285 #1 0x080a4161 in edit_free_syntax_rules (edit=0x92e8dc0) at syntax.c:977 #2 0x080a55ff in edit_load_syntax (edit=0x92e8dc0, pnames=0x0, type=0x0) at syntax.c:1201 #3 0x08097ff9 in edit_init (edit=0x92e8dc0, lines=38, columns=80, filename=0x92e06b8 Makefile.am, line=0) at edit.c:547 #4 0x080a00ca in edit_file (_file=0x92e06b8 Makefile.am, line=0) at editwidget.c:194 #5 0x0805c3ce in do_edit_at_line (what=0x92e06b8 Makefile.am, start_line=0) at cmd.c:270 #6 0x0805c41a in do_edit (what=Variable what is not available. ) at cmd.c:289 #7 0x0809347f in buttonbar_call (bb=Variable bb is not available. ) at widget.c:2282 #8 0x0809366d in buttonbar_callback (w=0x92e89b8, msg=WIDGET_HOTKEY, parm=1004) at widget.c:2304 #9 0x08061d77 in dlg_process_event (h=0x92d2b50, key=1004, event=0xbfe6b404) at dialog.c:614 #10 0x08062134 in run_dlg (h=0x92d2b50) at dialog.c:785 #11 0x08076a5b in main (argc=1, argv=0xbfe6c5c4) at main.c:1680 Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #13500] Feature request: .. entry in directory hotlist subgroups
Follow-up Comment #4, bug #13500 (project mc): Sorry, the previous patch was bad: 1) I forgot to add `..' entry when adding a new group from the hotlist dialog 2) The label and the destionation of the `..' entries were not g_strdup()-ed which caused MC to crash Please, give the update patch a try - it's should be fine. ___ Additional Item Attachment: File name: mc-hotlist-dotdot-updated.patch Size:3 KB http://savannah.gnu.org/bugs/download.php?item_id=13500item_file_id=3359 ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=13500 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[patch #1042] hotkeys and other improvements in hotlist
Follow-up Comment #13, patch #1042 (project mc): Hello Bulia, Please, take a look here: https://savannah.gnu.org/bugs/?func=detailitemitem_id=13500 I've created a patch which adds .. to the hotlist. I think the approach used there is cleaner than the one you have used in your own patch. What do you think ? In any case your original work helped me alot to get in speed with the matter. Btw I've been looking at your patch for a while and I must tell it is hard to read. You mix new features, fixes and plain formatting fixes together which makes the patch harder to read. Still I am going to review this one, but ... please, next time split the patch in smaller pieces and avoid mixing source code formatting changes with actual changes to the code. Thanks! ___ Reply to this item at: http://savannah.gnu.org/patch/?func=detailitemitem_id=1042 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Crash on hexediting empty file
On Wed, 1 Feb 2006, Leonard den Ottolander wrote:
Hi,
Try F3 - F4 - F2 on an empty file. Boom, ouch. (Might be that if you
still are in edit mode you need to try after getting back in view mode.)
Patch is attached. I'll not commit this before Roland comments . There are
multiple ways to fix this and I think this one is ok but ...Index: src/view.c
===
RCS file: /cvsroot/mc/mc/src/view.c,v
retrieving revision 1.353
diff -u -p -r1.353 view.c
--- src/view.c 1 Feb 2006 15:59:21 - 1.353
+++ src/view.c 2 Feb 2006 08:49:45 -
@@ -2901,7 +2901,7 @@ view_labels (WView *view)
my_define (h, 2, Q_(ButtonBar|Edit),
view_toggle_hexedit_mode_cmd, view);
} else {
- my_define (h, 2, , NULL, view);
+ buttonbar_clear_label (h, 2);
}
my_define (h, 6, Q_(ButtonBar|Save),
view_hexedit_save_changes_cmd, view);
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [patch?] recent ftpfs ERRNOR fix broke uploading
Pavel Tsekov wrote: On Thu, 2 Feb 2006, Pavel Tsekov wrote: On Wed, 1 Feb 2006, Jindrich Makovicka wrote: after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c (ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try uploading directories recursively. Changing the return value from -1 to 0 seems to fix the problem. I've just uploaded a small tree successfully on a remote ftp server. Right now I am pushing the whole MC tree onto the same server - I'll let you know when I am done (so far no crash). I couldn't make it crash :( Can you give some more details ? Sorry... It actually happens only when uploading to a directory without read permissions. In my case, the server was vsftpd with anon_world_readable_only=yes so the newly uploaded directories are unreadable. Here is the backtrace: #0 0x080b319b in vfs_s_generate_entry (me=0x80e0e20, name=0x81955bd Entries, parent=0x0, mode=135139168) at direntry.c:179 #1 0x080b40ae in vfs_s_open (me=0x80e0e20, file=0x0, flags=577, mode=384) at direntry.c:755 #2 0x080b7768 in mc_open (filename=0x80e0f60 , flags=577) at vfs.c:342 #3 0x08066563 in copy_file_file (ctx=0x8180928, src_path=0x8194bf0 /home/henry/build/mc/ftp3/mc/src/CVS/Entries, dst_path=0x8195810 /#ftp:holly/incoming/CVS/Entries, ask_overwrite=1, progress_count=0xbf9d3958, progress_bytes=0xbf9d3950, is_toplevel_file=135139168) at file.c:613 #4 0x0806736c in copy_dir_dir (ctx=0x8180928, s=0x817d4f8 /home/henry/build/mc/ftp3/mc/src/CVS, d=0x818b068 /#ftp:holly/incoming/CVS, toplevel=1, move_over=0, delete=0, parent_dirs=0x0, progress_count=0xbf9d3958, progress_bytes=0xbf9d3950) at file.c:975 #5 0x08068fcb in panel_operate (source_panel=0x8169298, operation=OP_COPY, force_single=0) at file.c:1887 #6 0x0805b094 in copy_cmd () at cmd.c:310 #7 0x08099554 in buttonbar_call (bb=0x80e0f60, i=value optimized out) at widget.c:2282 #8 0x080996bd in buttonbar_callback (w=0x818c1f8, msg=WIDGET_HOTKEY, parm=1005) at widget.c:2304 #9 0x08061821 in dlg_process_event (h=0x81682b0, key=1005, event=0xbf9d3a34) at dialog.c:614 #10 0x08061a10 in run_dlg (h=0x81682b0) at dialog.c:785 #11 0x0807925d in main (argc=135139168, argv=0xbf9d4bd4) at main.c:1680 Regards, -- Jindrich Makovicka ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: current CVS mc isn't compilable
Pavel Tsekov wrote: Fixed. Oops and thanks. :) Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [patch?] recent ftpfs ERRNOR fix broke uploading
On Wed, 1 Feb 2006, Jindrich Makovicka wrote: after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c (ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try uploading directories recursively. Changing the return value from -1 to 0 seems to fix the problem. I've just uploaded a small tree successfully on a remote ftp server. Right now I am pushing the whole MC tree onto the same server - I'll let you know when I am done (so far no crash). ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[patch #1042] hotkeys and other improvements in hotlist
Follow-up Comment #15, patch #1042 (project mc): There is a good chance that your patches will be reviewed if you submit them. In fact I'd ask you to do so if you have patches that are of general interest. ___ Reply to this item at: http://savannah.gnu.org/patch/?func=detailitemitem_id=1042 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #13500] Feature request: .. entry in directory hotlist subgroups
Follow-up Comment #3, bug #13500 (project mc): Patch attached. ___ Additional Item Attachment: File name: mc-hotlist-dotdot.patchSize:3 KB Add .. entry to hotlist subgroups http://savannah.gnu.org/bugs/download.php?item_id=13500item_file_id=3355 ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=13500 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: syntax switching
Hi Pavel, On Thu, 2006-02-02 at 17:55 +0200, Pavel Tsekov wrote: The patch isn't working quite as I'd expect it. If syntax highlighting is off when opening a file - it is not possible to switch it on (i.e. see the file coloured after Ctrl + S) because the syntax rules are not loaded yet. If this is the expected behaviour i.e. the patch honours the syntax highlighting switch then I'd expect it not to change that switch on editor exit i.e. if I close the editor with syntax off it should not remember that. Fixed. I reload the syntax on toggle to on. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: syntax switching
On Wed, 1 Feb 2006, Leonard den Ottolander wrote: On Mon, 2006-01-30 at 13:55 +0200, Andy Shevchenko wrote: Arny (one of developers of MPlayer) made patch for mc old version. I catch the syntax highlighting toggle feature from it and adopt to a last FC package. I hope, the switcher of syntax highlightind is a usefull feature and should like to be added to mainstream. Patch has been committed. We might use a different hotkey than Ctrl-S in the future. The patch isn't working quite as I'd expect it. If syntax highlighting is off when opening a file - it is not possible to switch it on (i.e. see the file coloured after Ctrl + S) because the syntax rules are not loaded yet. If this is the expected behaviour i.e. the patch honours the syntax highlighting switch then I'd expect it not to change that switch on editor exit i.e. if I close the editor with syntax off it should not remember that. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #13731] confirm deleting from directory hotlist
Follow-up Comment #9, bug #13731 (project mc): Please, close. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=13731 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #15412] gpmsupport on console doesn't work
Follow-up Comment #2, bug #15412 (project mc): Please, close. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=15412 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [patch?] recent ftpfs ERRNOR fix broke uploading
On Wed, 1 Feb 2006, Jindrich Makovicka wrote: after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c (ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try uploading directories recursively. Changing the return value from -1 to 0 seems to fix the problem. I'll investigate. But in this particular case a backtrace would be more appropriate than a patch. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [patch?] recent ftpfs ERRNOR fix broke uploading
On Thu, 2 Feb 2006, Pavel Tsekov wrote: On Wed, 1 Feb 2006, Jindrich Makovicka wrote: after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c (ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try uploading directories recursively. Changing the return value from -1 to 0 seems to fix the problem. I've just uploaded a small tree successfully on a remote ftp server. Right now I am pushing the whole MC tree onto the same server - I'll let you know when I am done (so far no crash). I couldn't make it crash :( Can you give some more details ? ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Crash on hexediting empty file
Pavel Tsekov wrote:
Index: src/view.c
===
RCS file: /cvsroot/mc/mc/src/view.c,v
retrieving revision 1.353
diff -u -p -r1.353 view.c
--- src/view.c 1 Feb 2006 15:59:21 - 1.353
+++ src/view.c 2 Feb 2006 08:49:45 -
@@ -2901,7 +2901,7 @@ view_labels (WView *view)
my_define (h, 2, Q_(ButtonBar|Edit),
view_toggle_hexedit_mode_cmd, view);
} else {
- my_define (h, 2, , NULL, view);
+ buttonbar_clear_label (h, 2);
Looks great. Please commit.
Roland
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
