Re: Crash on hexediting empty file
On Fri, 3 Feb 2006, Roland Illig wrote:
Pavel Tsekov wrote:
Index: src/view.c
===
RCS file: /cvsroot/mc/mc/src/view.c,v
retrieving revision 1.353
diff -u -p -r1.353 view.c
--- src/view.c 1 Feb 2006 15:59:21 - 1.353
+++ src/view.c 2 Feb 2006 08:49:45 -
@@ -2901,7 +2901,7 @@ view_labels (WView *view)
my_define (h, 2, Q_(ButtonBar|Edit),
view_toggle_hexedit_mode_cmd, view);
} else {
- my_define (h, 2, , NULL, view);
+ buttonbar_clear_label (h, 2);
Looks great. Please commit.
Done.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [patch?] recent ftpfs ERRNOR fix broke uploading
On Thu, 2 Feb 2006, Jindrich Makovicka wrote:
after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c
(ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try
uploading directories recursively. Changing the return value from -1 to
0 seems to fix the problem.
I've just uploaded a small tree successfully on a remote ftp server. Right
now I am pushing the whole MC tree onto the same server - I'll let you
know when I am done (so far no crash).
I couldn't make it crash :( Can you give some more details ?
Sorry... It actually happens only when uploading to a directory without
read permissions. In my case, the server was vsftpd with
anon_world_readable_only=yes so the newly uploaded directories are
unreadable.
Ok. I was able to reproduce it... Initial analisys shows that the patch
you refer to just exposes a bug in MC.
The crash happens here:
struct vfs_s_entry *
vfs_s_generate_entry (struct vfs_class *me, const char *name, struct
vfs_s_inode *parent, mode_t mode)
{
struct vfs_s_inode *inode;
struct stat *st;
st = vfs_s_default_stat (me, mode);
inode = vfs_s_new_inode (me, parent-super, st);
In this particular setup parent is NULL. Consider directory
structure:
mc/CVS
and file Root inside it
Since no information can be retrieved for mc/CVS parent is NULL .
Unfortunately neither vfs_s_open() nor vfs_s_generate_entry()
cares to check that.
I am looking for a solution now. There are other unchecked calls btw
which lead to that crash - for example a mc_stat() call on the destination
in copy_dir_dir().
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [bug #15412] gpmsupport on console doesn't work
Hello Pavel, On Thu, 2006-02-02 at 16:48 +0200, Pavel Tsekov wrote: Please, close. Could Pavel get the right to close bugs please? Thanks. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #15576] Switching panels in long mode
Update of bug #15576 (project mc): Status:None = Confirmed ___ Follow-up Comment #1: Confirmed. I'll see what's wrong. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=15576 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: bugs, patches, stuff
Hi, On 24/01/06, Pavel Tsekov [EMAIL PROTECTED] wrote: I plan to change the current state of affairs now that I have cvs access. In [..] Some time ago I posted to the list, this patch for looping through the hotlisted directories: http://mail.gnome.org/archives/mc-devel/2005-May/msg3.html It's a small change but now that I'm using it for a long time already, it's turning out to be extremely handy in many situations. While you're at it, what do you think about the utlity of this and possibly adding the feature to MC? Regards, -- balrog 2oo6 Dear Outlook users: Please remove me from your address books http://www.newsforge.com/article.pl?sid=03/08/21/143258 ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [bug #15412] gpmsupport on console doesn't work
On Fri, 2006-02-03 at 16:33 +0100, Leonard den Ottolander wrote: Hello Pavel, On Thu, 2006-02-02 at 16:48 +0200, Pavel Tsekov wrote: Please, close. Could Pavel get the right to close bugs please? Thanks. Done. -- Regards, Pavel Roskin ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
