Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: ftpfs-allow-connect-interrupting.patch Let the user interrupt ftpfs in hostname lookup / connection state (for mistyped URL/IP or servers being shut down) Commited. Thanks! ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, On Sun, 5 Feb 2006, Arpi wrote: ftpfs-allow-connect-interrupting.patch Let the user interrupt ftpfs in hostname lookup / connection state (for mistyped URL/IP or servers being shut down) Commited. Thanks! thanks. what about the others? i'm interested in comments, reasons of refusing. there are a few i can accept being refused (like unesp support, although it's just a few lines, my syntax files, or the esc,shift+numbers mapping) but the others are IMHO clean and useful. A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: On Sun, 5 Feb 2006, Arpi wrote: ftpfs-allow-connect-interrupting.patch Let the user interrupt ftpfs in hostname lookup / connection state (for mistyped URL/IP or servers being shut down) Commited. Thanks! thanks. what about the others? i'm interested in comments, reasons of refusing. there are a few i can accept being refused (like unesp support, although it's just a few lines, my syntax files, or the esc,shift+numbers mapping) but the others are IMHO clean and useful. One at a time. I'll go trough all of them. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) Which terminal emulator generates those sequences ? I've just tried xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output anything on the screen. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Updated Lithuanian translation
Hello, I don't know whether this is the right place to send the translation, but here it is. -- Sincerely yours, Vaidrius Petrauskas lt.po.gz Description: GNU Zip compressed data ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Updated Lithuanian translation
On Sun, 5 Feb 2006, Vaidrius Petrauskas wrote: I don't know whether this is the right place to send the translation, but here it is. Commited. Thanks! ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, On Sun, 5 Feb 2006, Arpi wrote: more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) Which terminal emulator generates those sequences ? I've just tried xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output anything on the screen. iTerm on MAC OSX, it's xterm compatible anyway (at least it sets TERM=xterm and outputs the other codes same as xterm) anyway these codes has the same logic as the other modifier key seqs. A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: On Sun, 5 Feb 2006, Arpi wrote: more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) Which terminal emulator generates those sequences ? I've just tried xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output anything on the screen. iTerm on MAC OSX, it's xterm compatible anyway (at least it sets TERM=xterm and outputs the other codes same as xterm) anyway these codes has the same logic as the other modifier key seqs. Yeah, sure, however from the patch description it wasn't clear who emits those sequences. I was under the impression that it's xterm itself. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) Which terminal emulator generates those sequences ? I've just tried xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output anything on the screen. iTerm on MAC OSX, it's xterm compatible anyway (at least it sets TERM=xterm and outputs the other codes same as xterm) anyway these codes has the same logic as the other modifier key seqs. Yeah, sure, however from the patch description it wasn't clear who emits those sequences. I was under the impression that it's xterm itself. Sorry. I have added lots of such sequences long time ago to my AMC fork (made from 4.6.0, when my patches were ignored on this list 2 years ago), and now that i was trying to update my patches for current mc version, i found that most of them (except for this two) were already added by you, commented as 'xterm sequences'. i didnt care to test with xterm myself... Anyway i guess xterm should also emit these, if the keymaps are set up correctly, unless they are all hand-coded into xterm as hacks. (the codes show some logic, being constructed from 2 numbers, one refers to the key and the other to modifiers, so it could be handled generaly without listing any possible combinations - probably this is the reason why for example iTerm emits these too) A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote:
On Sun, 5 Feb 2006, Arpi wrote:
more-xterm-keycodes.patch
xterm codes for Shift + Pageup/Pagedown
and some cosmetics (grouping same keys with different modifiers
together)
Which terminal emulator generates those sequences ? I've just tried
xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output
anything on the screen.
iTerm on MAC OSX, it's xterm compatible anyway (at least it sets TERM=xterm
and outputs the other codes same as xterm)
anyway these codes has the same logic as the other modifier key seqs.
The following patch was commited:
Index: src/ChangeLog
===
RCS file: /cvsroot/mc/mc/src/ChangeLog,v
retrieving revision 1.1798
diff -u -p -r1.1798 ChangeLog
--- src/ChangeLog 4 Feb 2006 14:41:41 - 1.1798
+++ src/ChangeLog 5 Feb 2006 15:25:12 -
@@ -1,3 +1,7 @@
+2006-02-05 Arpad Gereoffy (A'rpi) [EMAIL PROTECTED]
+
+ * key.c (xterm_key_defines): Add sequences for iTerm.
+
2006-02-04 Roland Illig [EMAIL PROTECTED]
* find.c: Added make_fullname() to avoid code duplication.
Index: src/key.c
===
RCS file: /cvsroot/mc/mc/src/key.c,v
retrieving revision 1.86
diff -u -p -r1.86 key.c
--- src/key.c 7 Jan 2006 12:49:08 - 1.86
+++ src/key.c 5 Feb 2006 15:25:12 -
@@ -304,6 +304,10 @@ static key_define_t xterm_key_defines []
{ KEY_M_SHIFT | KEY_M_CTRL | KEY_RIGHT, ESC_STR O6C, MCKEY_NOACTION },
{ KEY_M_SHIFT | KEY_M_CTRL | KEY_LEFT, ESC_STR O6D, MCKEY_NOACTION },
+/* iTerm */
+{ KEY_M_SHIFT | KEY_PPAGE, ESC_STR [5;2~, MCKEY_NOACTION },
+{ KEY_M_SHIFT | KEY_NPAGE, ESC_STR [6;2~, MCKEY_NOACTION },
+
/* keypad keys */
{ KEY_IC, ESC_STR Op, MCKEY_NOACTION },
{ KEY_DC, ESC_STR On, MCKEY_NOACTION },
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: more-syntax-defs.patch Syntax highlight definition files for BAssPasC language, MHTML and JASM I don't see any obstacles to apply this one. But I'd rather let other people comment before I commit it since those languages are not widely used (IMO). swap-backslash-and-greyminus.patch map \ to directory-hotlist instead of unselect-files What's the rationale here ? Make MC behave like other file managers with regard to selecting/deselecting groups of files ? If this is the case we should at least keep the current shortcut for the directory hotlist. The drawback here is that users accustomed to MC may be unpleasantly surprised. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, On Sun, 5 Feb 2006, Arpi wrote: more-syntax-defs.patch Syntax highlight definition files for BAssPasC language, MHTML and JASM I don't see any obstacles to apply this one. But I'd rather let other people comment before I commit it since those languages are not widely used (IMO). Probably it's better to put this to the homepage's Contributed code that won't be included into the distribution section... or just ignore. They are big and very few people uses it... they can add them manualy, as did before... swap-backslash-and-greyminus.patch map \ to directory-hotlist instead of unselect-files What's the rationale here ? Make MC behave like other file managers with regard to selecting/deselecting groups of files ? If this is the case yes. every other FMs i used uses - for unselect, and + for select. \ is unusual... we should at least keep the current shortcut for the directory hotlist. The drawback here is that users accustomed to MC may be unpleasantly surprised. yes ;( but there is no revolution without surprise :) A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [bug #13146] make tabs and trailing spaces visible
Hi Oswald, On Sun, 2006-02-05 at 17:51 +0100, Oswald Buddenhagen wrote: i suppose the envisioned ctrl-s shortcut for toggling syntax highlighting should be non-persistent as well. The syntax highlighting toggle has already been committed (and fixed as per Pavel's remark) by me. That option could already be saved via the editor options dialog. If you refer to as not being persistent as being not persistent within the session there is the possibility to choose unknown in the syntax highlighting dialog. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
redundant code in ftpfs?
Hi,
While i was trying to implement first_cd_then_stor (no success yet,
that struct called 'super' seems to be needed for any command but isnt
available in the stor function - any idea?) i found that in
ftpfs_dir_load() function:
p = ftpfs_translate_path (me, super, remote_path);
if (ftpfs_chdir_internal (me, super, p) != COMPLETE) {
...
}
g_free (p);
the ftpfs_translate_path() call and the 'p' pointer are redundant here,
as ftpfs_translate_path is also called from inside ftpfs_chdir_internal()
on the p parameter. so now it's done twice, which is redundant, and
may be a problem too...
A'rpi
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi Arpi, On Sun, 2006-02-05 at 00:53 +0100, Arpi wrote: I've just ported (updated) my patch set for the today version of mc. I didnt attach for size, download if interested, packed together: http://www1.mplayerhq.hu/~arpi/amc-patches-2006-02-03-13.tgz I'm not sure this is the most convenient way to submit patches. I'll just comment on a few of them based on your comments (instead of the code) for now. avoid-mc-in-mc.patch Do NOT allow starting mc from inside mc (mc in mc causes conflicts and confusion when changing to subshell with ctrl+o) We already have a dialog that warns you if you attempt this. No need to make it impossible. deb-support-without-dpkg.patch For systems withoput dpkg (almost any non-debian OS). It handles .deb files as regular .ar archives, as they are in reality. Haven't looked at the code but this seems useful. esc+shift+numbers_as_shift+F-keys.patch Useful only with english keyboard map! Maps ESC,Shift+0..9 to Shift+F1..F10 keys, like ESC,0..9 are mapped to F1..F10 (useful on dumb terminals not handling F-key codes correctly) Does this feature an option that can be toggled in any of the dialogs? more-syntax-defs.patch Syntax highlight definition files for BAssPasC language, MHTML and JASM There seems to be a difference of opinion whether we should support every obscure syntax there is out there. As such I don't mind we support as many syntaxes as we can, but how do we approach extension conflicts? option_beep_when_fileop_finished.patch beep sound when file op (copy,. move etc) finished. optional. Should be togglable. Not everyone likes beeping consoles. option_ctrl-o_blocking.patch block Ctrl+O (switch back to panels from subshell) when there is something types in the subshell (to avoid the annoying 'Subshell is already running a command' wahrning coming soon) - optional Don't like this. We've fixed the warning for white space lines already. I like to toggle a lot (especially from inside mcedit). optional: do not allow subshell to change panel's cwd Not without a selectable option. wildcards_and_quoting_in_quick_cd.patch allows quoting (cd There\ are\ spaces\ in\ this\ path) and wildcards (cd Mar*) in quick-cd. Quoting is fine but wildcards make no sense for cd. Where is a cd * supposed to go? Use auto completion (esc tab) instead. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [bug #13146] make tabs and trailing spaces visible
On Sun, Feb 05, 2006 at 09:29:59PM +0100, Leonard den Ottolander wrote: On Sun, 2006-02-05 at 17:51 +0100, Oswald Buddenhagen wrote: i suppose the envisioned ctrl-s shortcut for toggling syntax highlighting should be non-persistent as well. The syntax highlighting toggle has already been committed [...] by me. huh, seems like i missed it in the recent flurry of commits. :) That option could already be saved via the editor options dialog. indeed, it just toggles the regular syntax highlighing option and is saved on editor exit ... If you refer to as not being persistent as being not persistent within the session there is the possibility to choose unknown in the syntax highlighting dialog. not exactly a fast toggle. :) i think the quick toggles should be additional variables that mask out certain features or feature groups and don't change the regular options behind them. the rationale is that if i have a certain preference, i can change the option in the config dialog and do not need it being quickly accessible. if i want to change it quickly otoh, i probably have an acute reason and would not want the setting to persist once i exit the editing session - after all, it is against my preference. -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
