[patch #4970] add label highlighting to c.syntax

[Oswald Buddenhagen]

Follow-up Comment #3, patch #4970 (project mc):

actually, this patch sucks - it breaks the highlighting of the default:
labels in switch statements.


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #4162] detach on quick-save

[Pavel Tsekov]

Update of patch #4162 (project mc):

  Status: In Progress => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

I've commited the patch.

Thanks!


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #4162] detach on quick-save

[Pavel Tsekov]

Follow-up Comment #3, patch #4162 (project mc):

Right! My bad. The logic was pretty twisted anyway. I'll fix the patch and
commit it.

I also noted that mc_open() is used to emulate stat() on at least one more
place but I didn't want to change it since I might miss something .



___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #4970] add label highlighting to c.syntax

[Oswald Buddenhagen]

Follow-up Comment #2, patch #4970 (project mc):

my labels are all unindented by half an indentation step (or one tab back,
two spaces forward), so i don't need additional coloring. also, the color has
less contrast, so i'm not terribly thrilled. but other than that i could not
care less ...


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #4162] detach on quick-save

[Oswald Buddenhagen]

Follow-up Comment #2, patch #4162 (project mc):

you put the mc_close() outside an else branch; you'll now close an arbitrary
handle if the file is not local; closing -1 is not too nice, either.
other than that it looks ok.

btw, edit_save_as_cmd() uses mc_open() to "fake" an mc_stat() - i think it
would make sense to change it.


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #4970] add label highlighting to c.syntax

[Pavel Tsekov]

Follow-up Comment #1, patch #4970 (project mc):

Any comments from the syntax gurus ?


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #4162] detach on quick-save

[Pavel Tsekov]

Update of patch #4162 (project mc):

Category:None => Editor 
  Status:None => In Progress
 Assigned to:None => ptsekov

___

Follow-up Comment #1:

Oswald,

I've reviewed your patch and changed it a bit. The hunk that delt with
unlocking both the modify and the save locks is already in CVS. I've changed
the rest of the patch mainly cosmetically (rearranged the code a bit,
formating, etc) but there is one _important_ (IMO) change - I changed the
code to stat the destination filename to determine whether it has hardlinks .
There are several reasons to do so - the most obvious one being editing a
hardlinked file an using Save As to save it under a new name which is not
hardlinked.

I am attaching the modified patch so that you can test/review it. I'll wait
for your comments before I commit this patch.

___

Additional Item Attachment:

File name: mc-detach-update.patch Size:3 KB



___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel