Glib or no glib - we need a decision
Hey, As there are some guys here which want to stick with glib and some who doesn't want this. As each sites have some good arguments pro or contra glib I'll write some thoughs here down and would like to ask you to add your arguments here and discuss then these arguments on the list. Please note that we really need a decision :) pro: - glib has many preformed functions and we don't have to think about many issues as they are solved inside glib. - ... contra: - glib is huge and we only use a very small amount of functions. Rewriting this functions would make mc smaller and faster. This is important at least for embedded devices. - ... Please discuss on this as I would like to have this solved/out-of-the-world for 4.7 Greetings Winnie -- .''`. Patrick Winnertz patrick.winne...@skolelinux.org : :' : GNU/Linux Debian-Edu Developer `. `'` http://www.der-winnie.de http://d.skolelinux.org/~winnie `- Debian - when you have better things to do than fixing systems ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #125: allocate and free memory via mc-wrappers
#125: allocate and free memory via mc-wrappers --+- Reporter: slavazanko | Owner: slavazanko Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: memory Blocking: | Blockedby: --+- Comment(by metux): meanwhile I've moved some steps further: some .h files with macros+inlines in the ./mhl/ subdir (micro helper library). for example mhl/memory.h provides things like mhl_mem_alloc_u(): alloc on heap, unitialized mhl_mem_alloc_z(): alloc on heap, zero'd mhl_mem_free(): free from heap mhl_stack_alloc(): allocate on stack (uninitialized) and mhl/string.h has eg: mhl_str_dup(): safe strdup() (NULL-) mhl_str_ndup(): safe strndup() mhl_str_concat_1(): cat 1 string onto some base str mhl_str_concat_2(): cat 2 strings onto some base str ... -- Ticket URL: www.midnight-commander.org/ticket/125#comment:6 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #151: Unitialized use of variable in edit.c
#151: Unitialized use of variable in edit.c --+- Reporter: metux| Owner: winnie Type: defect | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review,vote-metux Blocking: | Blockedby: --+- Changes (by metux): * keywords: review = review,vote-metux -- Ticket URL: www.midnight-commander.org/ticket/151#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #151: Unitialized use of variable in edit.c
#151: Unitialized use of variable in edit.c --+- Reporter: metux| Owner: winnie Type: defect | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: --+- Changes (by winnie): * keywords: = review * owner: = winnie * status: new = accepted Comment: I've added a small patch which should fix this warning Please review. -- Ticket URL: www.midnight-commander.org/ticket/151#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #125: allocate and free memory via mc-wrappers
#125: allocate and free memory via mc-wrappers --+- Reporter: slavazanko | Owner: slavazanko Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: memory Blocking: | Blockedby: --+- Comment(by slavazanko): I think, in future need to move into ./lib dir - more sense place for library... -- Ticket URL: www.midnight-commander.org/ticket/125#comment:7 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #133: [PATCH] fix use of obsolete autoconf macros
#133: [PATCH] fix use of obsolete autoconf macros
--+-
Reporter: metux| Owner: slavazanko
Type: defect | Status: accepted
Priority: minor| Milestone: 4.6.2
Component: mc-core | Version: 4.6.1
Resolution: |Keywords: review
Blocking: | Blockedby:
--+-
Comment(by slavazanko):
In /usr/share/autoconf/autoconf/specific.m4 (on my Fedora-10) next
definitions:
{{{
...
AU_DEFUN([AC_GNU_SOURCE], [AC_USE_SYSTEM_EXTENSIONS])
...
AU_DEFUN([AC_AIX], [AC_USE_SYSTEM_EXTENSIONS])
...
AU_DEFUN([AC_MINIX], [AC_USE_SYSTEM_EXTENSIONS])
...
}}}
As fact, these macros is an aliases for AC_USE_SYSTEM_EXTENSIONS
--
Ticket URL: www.midnight-commander.org/ticket/133#comment:5
Midnight Commander www.midnight-commander.org
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #94: Some fixups for large file support (64bit sizes) on 32bit systems
#94: Some fixups for large file support (64bit sizes) on 32bit systems -+-- Reporter: slavazanko | Owner: Type: defect | Status: new Priority: major | Milestone: Component: mc-core | Version: Resolution: |Keywords: rework Blocking: | Blockedby: 125 -+-- Changes (by slavazanko): * keywords: = rework * blockedby: = 125 -- Ticket URL: www.midnight-commander.org/ticket/94#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #134: [PATCH] some time formatting fixes
#134: [PATCH] some time formatting fixes +--- Reporter: Enrico Weigelt weig...@metux.de | Owner: Type: enhancement| Status: new Priority: major | Milestone: 4.7 Component: mc-core| Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: +--- Changes (by slavazanko): * type: defect = enhancement * milestone: 4.6.2 = 4.7 Comment: Enrico, where branch? :) Milestone changed to 4.7 because this patch is an enhancement, not bug fixing... IMHO. -- Ticket URL: www.midnight-commander.org/ticket/134#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #151: Unitialized use of variable in edit.c
#151: Unitialized use of variable in edit.c --+- Reporter: metux| Owner: winnie Type: defect | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: --+- Changes (by slavazanko): * keywords: review,vote-metux = review Comment: I run 'grep' over sources for search calls of edit_cursor_move() function. And not any case to checking return value of this function. As fact, this function will must non-return type ( void ). See patch fix_uninitalised_int-rev2.patch. Patch don't applyed to branch - I think that the rules of good manners: branch must change by developer, who created the branch. The rest (all those involved in the ticket, not just developers) is temporarily becoming subordinates, developer (branch-starter) is temporarily becoming team leader. If this idea good - need to update workflow ;) -- Ticket URL: www.midnight-commander.org/ticket/151#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #137: [PATCH] (git) Fixup homepage url
#137: [PATCH] (git) Fixup homepage url ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: metux Type: task | Status: assigned Priority: critical | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: review Blocking: | Blockedby: ---+ Comment(by slavazanko): Duplicate #138 -- Ticket URL: www.midnight-commander.org/ticket/137#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #10: savannah: copy from fish vfs stalls on symlinks
#10: savannah: copy from fish vfs stalls on symlinks -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: rework Blocking: | Blockedby: 147, 149 -+-- Changes (by slavazanko): * keywords: review,vote-metux = rework -- Ticket URL: www.midnight-commander.org/ticket/10#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #138: [PATCH] (4.6.1) Fixup homepage url
#138: [PATCH] (4.6.1) Fixup homepage url ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: slavazanko Type: defect | Status: testing Priority: critical | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: duplicate |Keywords: review Blocking: | Blockedby: ---+ Changes (by slavazanko): * status: accepted = testing * resolution: = duplicate Comment: Duplicate #137 -- Ticket URL: www.midnight-commander.org/ticket/138#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #138: [PATCH] (4.6.1) Fixup homepage url
#138: [PATCH] (4.6.1) Fixup homepage url ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: slavazanko Type: defect | Status: testing Priority: critical | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: duplicate |Keywords: Blocking: | Blockedby: ---+ Changes (by slavazanko): * keywords: review = -- Ticket URL: www.midnight-commander.org/ticket/138#comment:6 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #155: savannah: Remove of WANT_WIDGETS
#155: savannah: Remove of WANT_WIDGETS --+- Reporter: andrew_b | Owner: Type: defect| Status: new Priority: minor | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Keywords: review|Blocking: Blockedby:| --+- My old patch: remove of WANT_WIDGETS preprocessor directives. http://savannah.gnu.org/patch/?6267 -- Ticket URL: www.midnight-commander.org/ticket/155 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #155: savannah: Remove of WANT_WIDGETS
#155: savannah: Remove of WANT_WIDGETS --+- Reporter: andrew_b | Owner: slavazanko Type: enhancement | Status: accepted Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: --+- Changes (by slavazanko): * type: defect = enhancement -- Ticket URL: www.midnight-commander.org/ticket/155#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #155: savannah: Remove of WANT_WIDGETS
#155: savannah: Remove of WANT_WIDGETS
---+
Reporter: andrew_b | Owner:
Type: defect| Status: new
Priority: minor | Milestone: 4.6.2
Component: mc-core | Version: 4.6.1
Resolution:|Keywords: review
Blocking:| Blockedby:
---+
Description changed by slavazanko:
Old description:
My old patch: remove of WANT_WIDGETS preprocessor directives.
http://savannah.gnu.org/patch/?6267
New description:
My old patch: remove of WANT_WIDGETS preprocessor directives.
Original: http://savannah.gnu.org/patch/?6267
||Submitted by:||Andrew Borodin a_borodin||Submitted on:||Wed 14 Nov
2007 07:00:13 AM UTC||
||Category:||Core||Priority:||5 - Normal||
||Status:||None||Privacy:||Public||
||Assigned to:||None||Open/Closed:||Open||
Discussion:
{{{
Wed 14 Nov 2007 07:00:13 AM UTC, original submission:
What the WANT_WIDGETS define is need for? I propose to remove
WANT_WIDGETS at all. Patch is attached.
Changelog:
src/main.h: Remove #ifdef WANT_WIDGETS preprocessor directive.
src/filegui.c: Remove #define WANT_WIDGETS preprocessor directive.
src/layout.c: Likewise.
src/screen.c: Likewise.
}}}
--
--
Ticket URL: www.midnight-commander.org/ticket/155#comment:1
Midnight Commander www.midnight-commander.org
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #10: savannah: copy from fish vfs stalls on symlinks
#10: savannah: copy from fish vfs stalls on symlinks -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: rework Blocking: | Blockedby: 147, 149 -+-- Comment(by ossi): fwiw, kde's kio_fish can optionally use a perl-based stub which is faster and more reliable. given the availability of perl that might be more viable than special-casing shell code for more reliability. -- Ticket URL: www.midnight-commander.org/ticket/10#comment:9 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #155: savannah: Remove of WANT_WIDGETS
#155: savannah: Remove of WANT_WIDGETS --+- Reporter: andrew_b | Owner: slavazanko Type: enhancement | Status: accepted Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review, vote-winnie Blocking: | Blockedby: --+- Changes (by winnie): * keywords: review = review, vote-winnie Comment: Hey, As there is really no configure check for something I think we can safely remove this stuff as Pavel Roskin started to do this in 2005. (See 446c06ea0c6e5bcd107a94399c13affe8a2dfe38). Therefore a vote from me. Greetings -- Ticket URL: www.midnight-commander.org/ticket/155#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #137: [PATCH] (git) Fixup homepage url
#137: [PATCH] (git) Fixup homepage url ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: metux Type: task | Status: assigned Priority: critical | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: review vote-slavazanko vote-winnie Blocking: | Blockedby: ---+ Changes (by winnie): * keywords: review = review vote-slavazanko vote-winnie Comment: I add vote-slavazanko and vote-winnie as we already voted in the text for this patch. @metux: If you want I'll help you this evening in merging this patch now into the mc-4.6 branch okay? -- Ticket URL: www.midnight-commander.org/ticket/137#comment:9 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #137: [PATCH] (git) Fixup homepage url
#137: [PATCH] (git) Fixup homepage url ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: metux Type: task | Status: assigned Priority: critical | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: review vote-slavazanko vote-winnie approved Blocking: | Blockedby: ---+ Changes (by winnie): * keywords: review vote-slavazanko vote-winnie = review vote-slavazanko vote-winnie approved Comment: Forgot to add approved keyword -- Ticket URL: www.midnight-commander.org/ticket/137#comment:10 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #133: [PATCH] fix use of obsolete autoconf macros
#133: [PATCH] fix use of obsolete autoconf macros --+- Reporter: metux| Owner: Type: defect | Status: new Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: --+- Comment(by slavazanko): Relative to: [http://www.archivum.info/autoconf- patc...@gnu.org/2008-08/msg00015.html autoconf-patches at gnu.org] we must don't use AC_GNU_SOURCE, AC_AIX, AC_MINIX. created branch '133_obsolete_autoconf_macros' from branch 'mc-4.6' -- Ticket URL: www.midnight-commander.org/ticket/133#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #139: compatibility_move_mc_files() still needed ?
#139: compatibility_move_mc_files() still needed ? --+- Reporter: metux| Owner: slavazanko Type: task | Status: reopened Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: approved-metux, approved-winnie, approve_count=2 Blocking: | Blockedby: --+- Comment(by winnie): I would go for not moving the configuration file to .config/mc but instead leaving them where they are now. .. At least for the moment. -- Ticket URL: www.midnight-commander.org/ticket/139#comment:15 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #144: Add procmail syntax highlighting
#144: Add procmail syntax highlighting ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review, vote-slavazanko Blocking:| Blockedby: ---+ Changes (by slavazanko): * keywords: review = review, vote-slavazanko -- Ticket URL: www.midnight-commander.org/ticket/144#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #143: Updated sh syntax file
#143: Updated sh syntax file ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: enhancement | Status: testing Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: fixed |Keywords: review, vote-slavazanko Blocking:| Blockedby: ---+ Changes (by slavazanko): * keywords: review = review, vote-slavazanko -- Ticket URL: www.midnight-commander.org/ticket/143#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #133: [PATCH] fix use of obsolete autoconf macros
#133: [PATCH] fix use of obsolete autoconf macros --+- Reporter: metux| Owner: slavazanko Type: defect | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: --+- Changes (by slavazanko): * owner: = slavazanko * status: new = accepted -- Ticket URL: www.midnight-commander.org/ticket/133#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #137: [PATCH] (git) Fixup homepage url
#137: [PATCH] (git) Fixup homepage url ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: metux Type: task | Status: assigned Priority: critical | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: review vote-slavazanko vote-winnie approved Blocking: | Blockedby: ---+ Comment(by slavazanko): I add vote-slavazanko and vote-winnie as we already voted in the text for this patch. agree. -- Ticket URL: www.midnight-commander.org/ticket/137#comment:11 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Glib or no glib - we need a decision
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Patrick Winnertz wrote: Hey, As there are some guys here which want to stick with glib and some who doesn't want this. As each sites have some good arguments pro or contra glib I'll write some thoughs here down and would like to ask you to add your arguments here and discuss then these arguments on the list. Please note that we really need a decision :) pro: - glib has many preformed functions and we don't have to think about many issues as they are solved inside glib. - ... contra: - glib is huge and we only use a very small amount of functions. Rewriting this functions would make mc smaller and faster. This is important at least for embedded devices. - ... I want to propose third variant... As for me, no different what write: - - mc_malloc|free|new_array|... - - or g_malloc|free|new_array|... - - or simply malloc|free|own_func_for_work_with_array I want to write a standard, without chaos, without #ifdef...#endif in any source file... in one coding style... What I mean: need to create some wrapper... like my first step to this in http://www.midnight-commander.org/ticket/125 For now, wrapper may have #define'd via pseudo-functions... but in future (if someone from 'contra' want) will realize own library (call it as you want: mcglib, mccore, mclib.so,...), and will add in ./configure.ac option '--without-glib' WBR, Slavaz. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFJZ1Dfb3oGR6aVLpoRApR8AJ4iKV04LbaItVjfo03SsfwfPdYoaQCdEFJU EvcIDZlDL7qy9DycVtojZbI= =EsAi -END PGP SIGNATURE- ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #151: Unitialized use of variable in edit.c
* MC Ticket System tick...@midnight-commander.org schrieb: Patch don't applyed to branch - I think that the rules of good manners: branch must change by developer, who created the branch. The rest (all those involved in the ticket, not just developers) is temporarily becoming subordinates, developer (branch-starter) is temporarily becoming team leader. If this idea good - need to update workflow ;) Yes, each branch needs an owner, normally the one who created it or started working on its issue. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #133: [PATCH] fix use of obsolete autoconf macros
* MC Ticket System tick...@midnight-commander.org schrieb: Comment(by slavazanko): In /usr/share/autoconf/autoconf/specific.m4 (on my Fedora-10) next snip As fact, these macros is an aliases for AC_USE_SYSTEM_EXTENSIONS Confirmed on Gentoo. But autoconf spits out a fat warning that these macros are obsolete, so we should get rid of 'em. I'd like to hear your votes ;-p cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #134: [PATCH] some time formatting fixes
* MC Ticket System tick...@midnight-commander.org schrieb: Comment: Enrico, where branch? :) Milestone changed to 4.7 because this patch is an enhancement, not bug fixing... IMHO. No, the issue started with some fix for a bug which makes mc segfault when it sees invalid mtime's - I've just refined it. So, it should go into next release, IMHO. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Glib or no glib - we need a decision
* Patrick Winnertz win...@debian.org schrieb: contra: - glib is huge and we only use a very small amount of functions. Rewriting this functions would make mc smaller and faster. This is important at least for embedded devices. Note that there's many many places where the glib functions aren't needed at all. a) wrappers for (often inline'd) libc functions (g_strcasecmp(), etc) This actually costs resources, *at least* an extra far call up to loosing the chance of inline'ing. It's IMHO stupid to use glib here just to use it. b) unncessary string duplications c) often an static buffer on stack is cheaper d) g_strconcat(): unnecessarily expensive and unrobust (just forget the last NULL parameter and go straight to hell) - I've replaced it by several faster inlines in my branch e) many things can be expressed more clear, cheaper and more robust through a few little macros. f) some glib functions are simply broken and must be circumvented at all (eg. shell-escaping ...) So my vote is to at least get rid of the unncessary glib calls, then let's see what remains and wether it's worth to keep it just for that few things BTW: glib is far from being robust over several versions. Just look at the 1.*/2.* issue: they actually call the 2.* successor versions of 1.*, but they're totally different things that just happen to share the name and some ideas behind. And even within the 2.* line there've been major interface breaks. Keep that in mind! cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Glib or no glib - we need a decision
* Slava Zanko slavaza...@gmail.com schrieb: Hi, What I mean: need to create some wrapper... like my first step to this in http://www.midnight-commander.org/ticket/125 Inspired by your idea, I've started writing some minimalistic helper library (./mhl/* - micro helper library) which actually just provides a bunch of macros and inlines. Meanwhile I've moved the whole memory management, string handling and even hashtable handling (using libhash) there. For now, wrapper may have #define'd via pseudo-functions... but in future (if someone from 'contra' want) will realize own library (call it as you want: mcglib, mccore, mclib.so,...), and will add in ./configure.ac option '--without-glib' Yes, that would be easy. But as I already wrote own (glib-free) implementations for that stuff, I doubt why we should glib at all ;-o cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [MPORTANT]: Created new default query for tickets
* Patrick Winnertz win...@debian.org schrieb: snip is it possible to set up an query which shows patches to review, which wasn't already voted by $self and also isnt tagged for rework ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
