Re: tree view, more tweaking
Yury V. Zaytsev said: (by the date of Mon, 17 May 2010 14:24:08 +0200) On Fri, 2010-05-14 at 18:05 +0200, Janek Kozicki wrote: Hi, I was working to improve the tree view feature, please have a look at my video: http://janek.kozicki.pl/nn/mc-tree-view.mpg As a tangential note, what bothers me is the gray background. I think regular blue color scheme would be nicer. yes, it is bothering me too. I think I've seen somewhere the code that sets the color, I'll try to change it to blue background. -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: tree view, more tweaking
Andrew Borodin said: (by the date of Sat, 15 May 2010 09:35:22 +0400) On Fri, 14 May 2010 18:05:41 +0200 Janek Kozicki wrote: I was working to improve the tree view feature Thanks! It seems that Tree widget is almost unused by MC users therefore it exists as is without any developing and improving. Very nice! Thank you for your positive feedback :) Sorry for late response, typically I have very little time during the week. In fact that day when I produced that patch, I should have been doing something else, but that tree view in mc was bothering me so much, that I couldn't focus on my own work without fixing it ;) During the course I have learned a bit of how that tree-view code works, and I already have an idea how to optimize the current patch a little bit more. Depending on your patience you can either apply this patch or wait for the next one. Also I'm thinking about adding symlinked directories to the display, but I'm not sure if I'll achieve that. That is because in my dirtree I am extensively using symlinked directories. I would be extremely happy however if you would consider applying this patch, after your review (and some cleaning perhaps). Would you create a ticket at the www.midniht-commander.org? Thanks. I have just registered on the website. I'll try to investigate later how this trac system works, I never used it :) -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: tree view, more tweaking
On Tue, 2010-05-18 at 16:56 +0200, Janek Kozicki wrote: During the course I have learned a bit of how that tree-view code works, and I already have an idea how to optimize the current patch a little bit more. Depending on your patience you can either apply this patch or wait for the next one. That depends on how much time you would want to invest into this venture. Either you come up with a patch, attach it to the Trac ticket, we create a branch, review it and merge into the current master tree or you can checkout the latest source from git and then push your branch to github or somewhere else so that we can pull from you. In fact, rebasing to the latest master is recommended as we are now applying auto-indent to every file we touch so that hopefully the crazy ad hoc indentation will finally go away without causing too much conflicts. If you make a patch on top of an source file that has been subsequently auto-indented it will become essentially un-applicable for us. P.S. We all should probably be doing something else... :-) -- Sincerely yours, Yury V. Zaytsev ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: tree view, more tweaking
Janek Kozicki said: (by the date of Tue, 18 May 2010 16:56:31 +0200) Would you create a ticket at the www.midniht-commander.org? Thanks. I have just registered on the website. I'll try to investigate later how this trac system works, I never used it :) ok, trac ticket #2202 the optimizations I had in mind were about calling how_many_folded = tree_store_remove_entry (tree-selected_ptr-name,FALSE,FALSE); by using the same method that I later applied in does_it_have_subdirectories(..) by this method such call can be made a bit faster. But it's not for today. So I submitted the current patch. -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
