Midnight Commander not compiles on Debian Squeeze

[Andrey Tataranovich]

Hello,

While compiling e0c16d739926f194c72459f41124b161849e88a3 from
master branch I've got following error on Debian Squeeze host:

/bin/bash ../libtool  --tag=CC   --mode=link gcc -std=gnu99
-fdiagnostics-show-option -Wbad-function-cast -Wcomment
-Wdeclaration-after-statement -Wfloat-equal -Wformat -Wformat-security
-Wimplicit -Wignored-qualifiers -Wmissing-braces -Wmissing-declarations
-Wmissing-field-initializers -Wmissing-parameter-type
-Wmissing-prototypes -Wnested-externs -Wno-long-long
-Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign
-Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow
-Wsign-compare -Wstrict-prototypes -Wswitch -Wswitch-default
-Wtype-limits -Wundef -Wuninitialized -Wunreachable-code
-Wunused-function -Wunused-label -Wunused-parameter -Wunused-result
-Wunused-value -Wunused-variable -Wwrite-strings  -g -O2 -g -Wall -O2
-o mc main.o libinternal.la ../lib/libmc.la libtool: link: gcc
-std=gnu99 -fdiagnostics-show-option -Wbad-function-cast -Wcomment
-Wdeclaration-after-statement -Wfloat-equal -Wformat -Wformat-security
-Wimplicit -Wignored-qualifiers -Wmissing-braces -Wmissing-declarations
-Wmissing-field-initializers -Wmissing-parameter-type
-Wmissing-prototypes -Wnested-externs -Wno-long-long
-Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign
-Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow
-Wsign-compare -Wstrict-prototypes -Wswitch -Wswitch-default
-Wtype-limits -Wundef -Wuninitialized -Wunreachable-code
-Wunused-function -Wunused-label -Wunused-parameter -Wunused-result
-Wunused-value -Wunused-variable -Wwrite-strings -g -O2 -g -Wall -O2 -o
mc main.o  ./.libs/libinternal.a ../lib/.libs/libmc.a -lslang -lgpm
-lssh2 /usr/lib/libgmodule-2.0.so -lrt /usr/lib/libglib-2.0.so
-pthread ./.libs/libinternal.a(lt58-regex.o): In function
`mc_search__g_regex_match_full_safe': 
/tmp/buildd/mc-4.8.14~git20151019/lib/search/regex.c:268:
undefined reference to `g_regex_get_compile_flags' collect2: ld
returned 1 exit status make[4]: *** [mc] Error 1 make[4]: Leaving
directory `/tmp/buildd/mc-4.8.14~git20151019/src'

Debian Squeeze libc6 version is 2.11.3.

-- 
WBR, Andrey Tataranovich
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Midnight Commander not compiles on Debian Squeeze

[Egmont Koblinger]

Hi Andrey,

This was introduced by a recent patch created by me that fixes a
segfault (a critical bug in 4.8.14). libc6's version is irrelevant,
glib matters here. I think so far mc required a glib that's not older
than about 7 years if I remember correctly. This change makes it
require glib-2.26 which is 5 years old.

I'm personally absolutely okay with this requirement and wouldn't want
to replace with a more complex, more hackish solution to support old
systems. It's reasonable to expect that you can't update apps after a
while wihtout updating the core system, and 5 years is a very long
time in computer science.

The configure checks should, of course, be updated to explicitly fail
on glib version checking. I forgot to do this, and I'm asking
mainstream developers to do it for me.

Mainstream developers might disagree with me and find it important to
support older systems. In that case I'd leave it for them to fix it.
I'm happy to improve mc and make it a better product, looking towards
the future, and of course making sure it runs on reasonably new
systems. But I have no personal interest in making it run on 5 year
old boxes, sorry. If you're happy with a base system that's 5 years
old, I'm assuming you should be happy with an mc from those days too.

Anyway, thanks for the heads-up, I didn't pay attention to the age of
the library call I'm introducing, and I'd definitely find a workaround
if it was let's say a 2-year old feature. But with 5 years my
recommendation is to bump the required glib version by mc developers,
and for you to upgrade your system or manually "git revert" this
change for the time being (re-introducing the potential segfault for
yourself).

Thanks,
Egmont

On Mon, Oct 19, 2015 at 2:14 PM, Andrey Tataranovich
 wrote:
> Hello,
>
> While compiling e0c16d739926f194c72459f41124b161849e88a3 from
> master branch I've got following error on Debian Squeeze host:
>
> /bin/bash ../libtool  --tag=CC   --mode=link gcc -std=gnu99
> -fdiagnostics-show-option -Wbad-function-cast -Wcomment
> -Wdeclaration-after-statement -Wfloat-equal -Wformat -Wformat-security
> -Wimplicit -Wignored-qualifiers -Wmissing-braces -Wmissing-declarations
> -Wmissing-field-initializers -Wmissing-parameter-type
> -Wmissing-prototypes -Wnested-externs -Wno-long-long
> -Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign
> -Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow
> -Wsign-compare -Wstrict-prototypes -Wswitch -Wswitch-default
> -Wtype-limits -Wundef -Wuninitialized -Wunreachable-code
> -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result
> -Wunused-value -Wunused-variable -Wwrite-strings  -g -O2 -g -Wall -O2
> -o mc main.o libinternal.la ../lib/libmc.la libtool: link: gcc
> -std=gnu99 -fdiagnostics-show-option -Wbad-function-cast -Wcomment
> -Wdeclaration-after-statement -Wfloat-equal -Wformat -Wformat-security
> -Wimplicit -Wignored-qualifiers -Wmissing-braces -Wmissing-declarations
> -Wmissing-field-initializers -Wmissing-parameter-type
> -Wmissing-prototypes -Wnested-externs -Wno-long-long
> -Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign
> -Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow
> -Wsign-compare -Wstrict-prototypes -Wswitch -Wswitch-default
> -Wtype-limits -Wundef -Wuninitialized -Wunreachable-code
> -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result
> -Wunused-value -Wunused-variable -Wwrite-strings -g -O2 -g -Wall -O2 -o
> mc main.o  ./.libs/libinternal.a ../lib/.libs/libmc.a -lslang -lgpm
> -lssh2 /usr/lib/libgmodule-2.0.so -lrt /usr/lib/libglib-2.0.so
> -pthread ./.libs/libinternal.a(lt58-regex.o): In function
> `mc_search__g_regex_match_full_safe': 
> /tmp/buildd/mc-4.8.14~git20151019/lib/search/regex.c:268:
> undefined reference to `g_regex_get_compile_flags' collect2: ld
> returned 1 exit status make[4]: *** [mc] Error 1 make[4]: Leaving
> directory `/tmp/buildd/mc-4.8.14~git20151019/src'
>
> Debian Squeeze libc6 version is 2.11.3.
>
> --
> WBR, Andrey Tataranovich
> ___
> mc-devel mailing list
> https://mail.gnome.org/mailman/listinfo/mc-devel
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Midnight Commander not compiles on Debian Squeeze

[Egmont Koblinger]

Hi :)
I'm drunk now but i think i included the version number in the prev mail.
See the doc of g-regex-get-compole-flags to get it :)

Sent from mobile
On Oct 19, 2015 9:25 PM, "Yury V. Zaytsev"  wrote:

> On Mon, 2015-10-19 at 20:30 +0300, Andrey Tataranovich wrote:
> >
> > Glib version check should be introduced in this case. My opinion - if
> > configure completes without error, then compilation should go without
> > error too. Otherwise it is a FTBFS bug.
>
> Hi Andrey,
>
> If you can come up a one-liner patch to make it compatible with old
> glib, we can think of applying it; I have nothing against supporting
> older glib per se, unless it comes with too much of a maintenance
> cost... but I'm not really sure if it's worth it.
>
> Back when I was taking care of backporting mc to older RHELs, I simply
> used to build newer glib statically from within the package and link mc
> to it... that's the route I'd suggest you to go if you care about
> backporting mc to Squeeze.
>
> Hi Egmont,
>
> Could you please be so kind as to tell me what's the minimal version
> required now? I can look into bumping the version in the configure
> check... as soon as I manage to get to it :-/
>
> Thanks!
>
> --
> Sincerely yours,
> Yury V. Zaytsev
>
>
>
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Midnight Commander not compiles on Debian Squeeze

[Yury V. Zaytsev]

On Mon, 2015-10-19 at 20:30 +0300, Andrey Tataranovich wrote:
> 
> Glib version check should be introduced in this case. My opinion - if
> configure completes without error, then compilation should go without
> error too. Otherwise it is a FTBFS bug.

Hi Andrey,

If you can come up a one-liner patch to make it compatible with old
glib, we can think of applying it; I have nothing against supporting
older glib per se, unless it comes with too much of a maintenance
cost... but I'm not really sure if it's worth it.

Back when I was taking care of backporting mc to older RHELs, I simply
used to build newer glib statically from within the package and link mc
to it... that's the route I'd suggest you to go if you care about
backporting mc to Squeeze.

Hi Egmont,

Could you please be so kind as to tell me what's the minimal version
required now? I can look into bumping the version in the configure
check... as soon as I manage to get to it :-/

Thanks!

-- 
Sincerely yours,
Yury V. Zaytsev


___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Midnight Commander not compiles on Debian Squeeze

[Andrey Tataranovich]

Hello Egmont,

First of all - thanks for your efforts in MC development.

On Mon, 19 Oct 2015 15:56:40 +0200
Egmont Koblinger  wrote:

> This was introduced by a recent patch created by me that fixes a
> segfault (a critical bug in 4.8.14). libc6's version is irrelevant,
> glib matters here. I think so far mc required a glib that's not older
> than about 7 years if I remember correctly. This change makes it
> require glib-2.26 which is 5 years old.
> 
> I'm personally absolutely okay with this requirement and wouldn't want
> to replace with a more complex, more hackish solution to support old
> systems. It's reasonable to expect that you can't update apps after a
> while wihtout updating the core system, and 5 years is a very long
> time in computer science.
> 
> The configure checks should, of course, be updated to explicitly fail
> on glib version checking. I forgot to do this, and I'm asking
> mainstream developers to do it for me.

Glib version check should be introduced in this case. My opinion - if
configure completes without error, then compilation should go without
error too. Otherwise it is a FTBFS bug.

-- 
WBR, Andrey Tataranovich
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel