Re: Midnight Commander not compiles on Debian Squeeze

2015-10-20 Thread Andrey Tataranovich
On Mon, 19 Oct 2015 21:25:26 +0200
"Yury V. Zaytsev"  wrote:

> If you can come up a one-liner patch to make it compatible with old
> glib, we can think of applying it; I have nothing against supporting
> older glib per se, unless it comes with too much of a maintenance
> cost... but I'm not really sure if it's worth it.

Glib version check patch attached.

> Back when I was taking care of backporting mc to older RHELs, I simply
> used to build newer glib statically from within the package and link
> mc to it... that's the route I'd suggest you to go if you care about
> backporting mc to Squeeze.

I'm not interested in backporting MC to Debian Squeeze. I'm building MC
packages for Debian/Ubuntu actual releases (see
https://www.midnight-commander.org/wiki/Binaries) and Squeeze in this
list due to Debian Squeeze LTS.

If support "cost" for Debian Squeeze is going higher (higher than cost
of electricity which buildbot spend to build package) then I will drop
support for Debian Squeeze.

-- 
WBR, Andrey Tataranovich
diff --git a/m4.include/ac-glib.m4 b/m4.include/ac-glib.m4
index c7fd084..ff892c7 100644
--- a/m4.include/ac-glib.m4
+++ b/m4.include/ac-glib.m4
@@ -78,9 +78,9 @@ AC_DEFUN([AC_CHECK_GLIB], [
 AS_HELP_STRING([--with-glib-static], [Link glib statically @<:@no@:>@]))
 
 glib_found=no
-PKG_CHECK_MODULES(GLIB, [glib-2.0 >= 2.14], [glib_found=yes], [:])
+PKG_CHECK_MODULES(GLIB, [glib-2.0 >= 2.26], [glib_found=yes], [:])
 if test x"$glib_found" = xno; then
-AC_MSG_ERROR([glib-2.0 not found or version too old (must be >= 2.14)])
+AC_MSG_ERROR([glib-2.0 not found or version too old (must be >= 2.26)])
 fi
 
 ])
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel


Re: Midnight Commander not compiles on Debian Squeeze

2015-10-20 Thread Mooffie
On 10/20/15, Andrey Tataranovich  wrote:
> Glib version check patch attached.

You also need to update README, INSTALL, HACKING.
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel


Re: Midnight Commander not compiles on Debian Squeeze

2015-10-20 Thread Andrew Borodin
On Tue, 20 Oct 2015 19:54:45 +0200 "Yury V. Zaytsev" wrote:
> On Tue, 2015-10-20 at 14:48 +0300, Mooffie wrote:
> > 
> > You also need to update README, INSTALL, HACKING. 
> 
> Thanks! I would have forgotten about it.

What about forgotten

11 PKG_CHECK_MODULES(GMODULE, [gmodule-no-export-2.0 >= 2.14], 
[found_gmodule=yes], [:])
12 if test x"$found_gmodule" = xyes; then
13 g_module_supported="gmodule-no-export-2.0"
14 else
15 dnl try fallback to the generic gmodule
16 PKG_CHECK_MODULES(GMODULE, [gmodule-2.0 >= 2.14], 
[found_gmodule=yes], [:])

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel


Re: Midnight Commander not compiles on Debian Squeeze

2015-10-20 Thread Yury V. Zaytsev
On Tue, 2015-10-20 at 14:48 +0300, Mooffie wrote:
> 
> You also need to update README, INSTALL, HACKING. 

Thanks! I would have forgotten about it.

-- 
Sincerely yours,
Yury V. Zaytsev


___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel


Re: Midnight Commander not compiles on Debian Squeeze

2015-10-20 Thread Yury V. Zaytsev
On Tue, 2015-10-20 at 14:13 +0300, Andrey Tataranovich wrote:
> Glib version check patch attached.

Thank you for the patch! Just hit master.

-- 
Sincerely yours,
Yury V. Zaytsev


___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel