Re: fatal: The remote end hung up unexpectedly

[David Sterba]

hi,


va...@mosja:~/hacker> git clone ssh://midnight-commander.org:/git/mc.git


use 'git clone git://midnight-commander.org/git/mc.git'
(hey it's written on the first page of www.m-c.org! :)

if you have ssh access to mc.org, use
git clone ssh+git://...

hth,
dave
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Compilation error: some mhl_* remainders

[David Sterba]

Hi,

compilation of master @ cc69f5d2784ab253d795d9c842a2eeec6a187eb5
fails with

screen.o: In function `show_free_space':
/home/dsterba/_dev/mc-build/src/screen.c:783: undefined reference to 
`mhl_mem_free'
/home/dsterba/_dev/mc-build/src/screen.c:784: undefined reference to 
`mhl_str_dup'


looks like a remainder of mhl removal.

I was not sure which branch should be taken as the reference for latest 
development and tried origin/HEAD with same result. Patch below.


cheers,
dave

--

Fix compilation error
screen.o: In function `show_free_space':
/home/dsterba/_dev/mc-build/src/screen.c:783: undefined reference to
`mhl_mem_free'
/home/dsterba/_dev/mc-build/src/screen.c:784: undefined reference to
`mhl_str_dup'

Signed-off-by: David Sterba 

--
diff --git a/src/screen.c b/src/screen.c
index b069b17..0b8920e 100644
--- a/src/screen.c
+++ b/src/screen.c
@@ -780,8 +780,8 @@ show_free_space (WPanel *panel)
char rpath[PATH_MAX];

init_my_statfs ();
-   mhl_mem_free (old_cwd);
-   old_cwd = mhl_str_dup (panel->cwd);
+   g_free (old_cwd);
+   old_cwd = g_strdup (panel->cwd);

if (mc_realpath (panel->cwd, rpath) == NULL)
return;

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: GNU Midnight Commander 4.6.2-pre1

[David Sterba]

Hi,

On Fri, Sep 28, 2007 at 11:14:47PM +0200, Pavel Tsekov wrote:
> I am trying to extract and describe all those changes that happened
> between 4.6.1 and the current cvs version.

can you please write down the changes you've discovered into CVS/mc/NEWS
file ?  Partial list will be useful too.

Thanks,
dave
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #18129] sort users and groups in chown dialog

[David Sterba]

Additional Item Attachment, bug #18129 (project mc):

File name: 01-sorted-userlist.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Filename quoting on cmdline

[David Sterba]

Hi,

there seems to be inconsistency in cmdline filename quoting.
Ctrl+Enter puts quoted name into command, but tab completion
does not quote filenames.

So, I think, insert_text() (complete.c) should call name_quote() too.


David
--- complete.c
+++ complete.c
@@ -786,6 +786,8 @@ static int start, end;
 
 static int insert_text (WInput *in, char *text, int len)
 {
+text = name_quote (text, 1);
+
 len = min (len, strlen (text)) + start - end;
 if (strlen (in->buffer) + len >= in->current_max_len){
 /* Expand the buffer */
@@ -811,6 +813,8 @@ static int insert_text (WInput *in, char
 	update_input (in, 1);
 	end += len;
 }
+g_free (text);
+
 return len != 0;
 }
 

Re: [patch] change sort order with single keyboard shortcut

[David Sterba]

Hi,

> After applying my patch, following keys start
> to work:
>  Sort by name   Ctrl-F3
>  Sort by extension  Ctrl-F4
>  Sort by modification time  Ctrl-F5
>  Sort by size   Ctrl-F6
>  Keep unsorted  Ctrl-F7
>  Sort by creation time  Ctrl-F8
>  Sort by access timeCtrl-F9
Ctrl-Fx keys are predefined in KDE to switch desktop and most users
don't change it.
You should choose different unused key set. Yes, it may be difficult :-)


David


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [bug] three small bugs in mc (2003-06-25-17)

[David Sterba]

Hi,


> When I press F4 in search results box, edit the file and then exit the
> editor, i get back to the search result box (as expected), but instead of
> seeing file panels under the search result box as in old mc versions, i see
> the editor screen (just the current file on which the cursor is is redrawn,
> so it looks quite messy). On older mc's (4.5.55), entire active panel is
> redrawn (and the other half of screen is the editor). The same bug applies
> to invoking viewer
Are you running MC from screen?

> Small bug in internally handled 'cd' command:
> I have two directories:
> directory /a
> directory /a/mc-2003-06-25-17
> (and nothing more in /a)
> now if I type anywhere in bash 'cd /a/mc*' I get to directory
> '/a/mc-2003-06-25-17', since mc* is expanded to full name of the directory
> but if I type it into mc command line, I get nowhere and it says  '/a/mc*:
> no such directory' Also commands like 'cd
> /some/dir;some_command_to_launch_there' also don't work
If you want to use wildcards, ${expressions:-or such}, you should
use '$ eval cd /a/mc*'.

> Also sometimes when I'm searching in files and press 's' (even multiple
> times) the suspend does not work and the search continues on (it get
> through about five more files before finally stopping) Note - I have a 486,
> can it be caused by the CPU slowness?
This nappens on my P3 too :-)
Responsibility of file find dialog is in TODO, and a working patch exist.


David


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [bug] three small bugs in mc (2003-06-25-17)

[David Sterba]

Hi,


> When I press F4 in search results box, edit the file and then exit the
> editor, i get back to the search result box (as expected), but instead
of
> seeing file panels under the search result box as in old mc versions, i
see
> the editor screen (just the current file on which the cursor is is
redrawn,
> so it looks quite messy). On older mc's (4.5.55), entire active panel is
> redrawn (and the other half of screen is the editor). The same bug
applies
> to invoking viewer
Are you running MC from screen?

> Small bug in internally handled 'cd' command:
> I have two directories:
> directory /a
> directory /a/mc-2003-06-25-17
> (and nothing more in /a)
> now if I type anywhere in bash 'cd /a/mc*' I get to directory
> '/a/mc-2003-06-25-17', since mc* is expanded to full name of the
directory
> but if I type it into mc command line, I get nowhere and it says
'/a/mc*:
> no such directory' Also commands like 'cd
> /some/dir;some_command_to_launch_there' also don't work
If you want to use wildcards, ${expressions:-or such}, you should
use '$ eval cd /a/mc*'.

> Also sometimes when I'm searching in files and press 's' (even multiple
> times) the suspend does not work and the search continues on (it get
> through about five more files before finally stopping) Note - I have a
486,
> can it be caused by the CPU slowness?
This nappens on my P3 too :-)
Responsibility of file find dialog is in TODO, and a working patch exist.


David
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [patch] change sort order with single keyboard shortcut

[David Sterba]

Hi,

> After applying my patch, following keys start
> to work:
>  Sort by name   Ctrl-F3
>  Sort by extension  Ctrl-F4
>  Sort by modification time  Ctrl-F5
>  Sort by size   Ctrl-F6
>  Keep unsorted  Ctrl-F7
>  Sort by creation time  Ctrl-F8
>  Sort by access timeCtrl-F9
Ctrl-Fx keys are predefined in KDE to switch desktop and most users
don't change it.
You should choose different unused key set. Yes, it may be difficult :-)


David
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

[PATCH] convert C literals in File Find

[David Sterba]

Hi,

I'm sending a patch which adds a checkbox to File Find dialog,
wich determines whether to convert C literals in the content-search
pattern.

I came across some things that should be discussed.

Let's now describe what it does:
- basic "one-letter" escapes: \a \b \e \f \n \r \t
- \ooo - octal number, 0 <= o <= 7, at most 3 digits
- \xHH - hexa number, 0 <= H <= f, a-f, A-F, at most 2 digits
- lets untouched these regex escapes \( \) \[ \] \{ \} \$ \^ \* \.

and now what it does not
- convert double-backslash to single-backslash
  if it would then any backslash should be escaped twice,
  one for C conversion and once for regex

As regexps are matched on 1 line only, there is no reason to type
"\n" to pattern.


Daviddiff -X .diffignore -urNp mc/src/ChangeLog mc-clit/src/ChangeLog
--- mc/src/ChangeLogThu Jul  3 01:35:21 CEST 2003
+++ mc-clit/src/ChangeLog   Thu Jul  3 01:35:21 CEST 2003
@@ -0,0 +1,10 @@
+2003-07-03  David Sterba  <[EMAIL PROTECTED]>
+
+   * find.c: Add a 'convert C literals' checkbox to Find File dialog.
+   (convert_x_digit): New func.
+   (translate_c_literals): New func. Converts all C escape sequences
+   to chars. Lets escaped regex symbols untouched. See comment for
+   further details.
+   (find_parm_callback): If set, convert literals before regex search.
+   (find_parameters): Add checkbox, lower the buttons.
+
diff -X .diffignore -urNp mc/src/find.c mc-clit/src/find.c
--- mc/src/find.c   Wed Apr 16 17:26:29 2003
+++ mc-clit/src/find.c  Thu Jul  3 01:28:10 2003
@@ -46,7 +46,7 @@
 #include "../vfs/vfs.h"
 
 /* Size of the find parameters window */
-#define FIND_Y 14
+#define FIND_Y 15
 static int FIND_X = 50;
 
 /* Size of the find window */
@@ -71,6 +71,7 @@ static WInput *in_start;  /* Start path *
 static WInput *in_name;/* Pattern to search */
 static WInput *in_with;/* Text inside filename */
 static WCheck *case_sense; /* "case sensitive" checkbox */
+static WCheck *conv_literals;  /* "convert C literals" checkbox */
 
 static int running = 0;/* nice flag */
 static char *find_pattern; /* Pattern to search */
@@ -118,6 +119,122 @@ static void get_list_info (char **file, 
 static regex_t *r; /* Pointer to compiled content_pattern */
  
 static int case_sensitive = 1;
+static int convert_literals = 0;
+
+static int convert_x_digit (const char c);
+
+/* Translates C escape sequences to chars,
+ * result is allocated and should be freed.
+ *
+ * Notes:
+ * - "\\" is *not* translated to "\"
+ * - hexa constant is limited to 2 digits
+ * - octal constant is limited to 3 digits
+ * - the regex escapes go through: ()[]{}$^*.
+ * - "\n" has no sense because regexps are matched only on 1 line
+ */
+static char*
+translate_c_literals (const char *str)
+{
+char *result, *p;
+int val;
+
+/* Translation won't be longer than original */
+p = result = g_malloc (strlen (str) + 1);
+
+while (*str) {
+   if (*str != '\\') {
+   *p++ = *str++;
+   continue;
+   }
+
+   str++;
+   if (!*str) {
+   /* Malformed literal */
+   g_free (result);
+   return NULL;
+   }
+
+   /* Ocal number */
+   if ('0' <= *str && *str <= '7') {
+   val = *str++ - '0';
+
+   /* Second digit */
+   if ('0' <= *str && *str <= '7')
+   val = val * 8 + *str++ - '0';
+   else {
+   *p++ = val;
+   continue;
+   }
+
+   /* Last digit */
+   if ('0' <= *str && *str <= '7')
+   val = val * 8 + *str++ - '0';
+
+   *p++ = val;
+   continue;
+   }
+
+   switch (*str) {
+   case 'a': *p++ = '\a'; str++; break;
+   case 'b': *p++ = '\b'; str++; break;
+   case 'e': *p++ = '\e'; str++; break;
+   case 'f': *p++ = '\f'; str++; break;
+   case 'n': *p++ = '\n'; str++; break;
+   case 'r': *p++ = '\r'; str++; break;
+   case 't': *p++ = '\t'; str++; break;
+   case 'x':
+   /* Hexa number */
+   str++;
+   if (!*str || !isxdigit (*str)) {
+   g_free (result);
+   return NULL;
+   }
+
+   val = convert_x_digit (*str++);
+
+   /* Second digit */
+   if (isxdigit (*str))
+   val = val * 16 + convert_x_digit (*str++);
+
+   *p++ = val;
+   break;
+
+   /* Possible regexp */
+   case '(

Re: [PATCH] File search responsiveness

[David Sterba]

Hi,

I forgot to remove some debugging code and sent it with the patch.


 David

diff -X .diffignore -urNp mc/src/ChangeLog mc-find/src/ChangeLog
--- mc/src/ChangeLogThu Jul  3 01:39:14 CEST 2003
+++ mc-find/src/ChangeLog   Thu Jul  3 01:39:14 CEST 2003
@@ -0,0 +1,7 @@
+
+   * file.c: New enum for find progress state. Add context vars
+   for last position.
+   (check_find_events): New func.
+   (search_content): Resume operation and return status to the caller.
+   (run_process): Init.
+
diff -X .diffignore -urNp mc/src/find.c mc-find/src/find.c
--- mc/src/find.c   Wed Apr 16 17:26:29 2003
+++ mc-find/src/find.c  Thu Jul  3 01:39:10 2003
@@ -43,6 +43,7 @@
 #include "wtools.h"
 #include "cmd.h"   /* view_file_at_line */
 #include "boxes.h"
+#include "key.h"
 #include "../vfs/vfs.h"
 
 /* Size of the find parameters window */
@@ -64,6 +65,12 @@ enum {
 B_VIEW
 };
 
+typedef enum {
+FIND_CONT,
+FIND_SUSPEND,
+FIND_ABORT
+} FindProgressStatus;
+
 /* List of directories to be ignored, separated by ':' */
 char *find_ignore_dirs = 0;
 
@@ -80,6 +87,11 @@ static int matches;  /* Number of matche
 static int is_start;   /* Status of the start/stop toggle button */
 static char *old_dir;
 
+/* Where did we stop */
+static int resuming;
+static int last_line;
+static int last_pos;
+
 static Dlg_head *find_dlg; /* The dialog */
 
 static WButton *stop_button;   /* pointer to the stop button */
@@ -437,32 +449,61 @@ get_line_at (int file_fd, char *buf, int
 return buffer;
 }
 
-/* 
+static FindProgressStatus
+check_find_events(Dlg_head *h)
+{
+Gpm_Event event;
+int c;
+
+c = get_event (&event, h->mouse_status == MOU_REPEAT, 0);
+if (c != EV_NONE) {
+   dlg_process_event (h, c, &event);
+   if (h->ret_value == B_ENTER
+   || h->ret_value == B_CANCEL
+   || h->ret_value == B_AGAIN
+   || h->ret_value == B_PANELIZE) {
+   /* dialog terminated */
+   return FIND_ABORT;
+   }
+   if (!h->send_idle_msg) {
+   /* searching suspended */
+   return FIND_SUSPEND;
+   }
+}
+
+return FIND_CONT;
+}
+
+/*
  * search_content:
  *
  * Search the global (FIXME) regexp compiled content_pattern string in the
  * DIRECTORY/FILE.  It will add the found entries to the find listbox.
+ *
+ * returns 0 if do_search should look for another file
+ * 1 if do_search should exit and proceed to the event handler
  */
-static void
+static int
 search_content (Dlg_head *h, char *directory, char *filename)
 {
 struct stat s;
 char buffer [BUF_SMALL];
 char *fname;
 int file_fd;
+int ret_val = 0;
 
 fname = concat_dir_and_file (directory, filename);
 
 if (mc_stat (fname, &s) != 0 || !S_ISREG (s.st_mode)){
g_free (fname);
-   return;
+   return 0;
 }
 
 file_fd = mc_open (fname, O_RDONLY);
 g_free (fname);
 
 if (file_fd == -1)
-   return;
+   return 0;
 
 g_snprintf (buffer, sizeof (buffer), _("Grepping in %s"), name_trunc (filename, 
FIND2_X_USE));
 
@@ -480,7 +521,15 @@ search_content (Dlg_head *h, char *direc
char *p;
int found = 0;
 
-   while ((p = get_line_at (file_fd, buffer, &pos, &n_read, sizeof (buffer), 
&has_newline))){
+   if (resuming) {
+  /* We've been previously suspended, start from the previous positio n */
+  resuming = 0;
+  line = last_line;
+  pos = last_pos;
+   }
+
+while ((p = get_line_at (file_fd, buffer, &pos, &n_read, sizeof (buffer), 
&has_newline))
+   && (ret_val == 0)) {
if (found == 0){/* Search in binary line once */
if (regexec (r, p, 1, 0, 0) == 0){
g_free (p);
@@ -494,10 +543,34 @@ search_content (Dlg_head *h, char *direc
found = 0;
}
g_free (p);
+
+   if ((line & 0xff) == 0) {
+   FindProgressStatus res;
+
+   res = check_find_events(h);
+   switch (res) {
+   case FIND_ABORT:
+   stop_idle (h);
+   ret_val = 1;
+   break;
+
+   case FIND_SUSPEND:
+   resuming = 1;
+   last_line = line;
+   last_pos = pos;
+   ret_val = 1;
+   break;
+
+   default:
+   break;
+   }
+   }
}
 }
 disable_interrupt_key ();
 mc_close (file_fd);
+
+return ret_val;
 }
 
 static int
@@ -593,9 +666,12 @@ do_search (struct Dlg_head *h)
 }
 
 if (regexp_match (find_pattern, dp->d_name, match_file)){
-   if (content_pattern)
-   search_content (h, directory, dp->d_name);
-   else 
+   if (content_pattern) {
+   if (search_content (h, directory, dp->d_name)) {
+   g_free (tmp_name);
+   retu

[PATCH] File search responsiveness

[David Sterba]

Hi,

long time ago ...
 
 * From: Jindrich Makovicka 
 * To: mc-devel gnome org
 * Subject: [patch] interruptible file search & viewer operations
 * Date: Sun, 04 May 2003 10:38:36 +0200

 This is a reincarnation of patches I sent some time ago, but they
 weren't accepted due to code freeze before 4.6.0. I ported them to the
 current CVS and still hope you can find them useful.

 find.diff modifies file search so it handles events during searching the
 file contents, which results in much greater responsiveness of the
 interface.

 view.diff adds event checks to various places where the execution can
 get stuck - searching and file loading at the beginning and file loading
 in the growing view. There already were some checks in the search
 functions, but this patch allows using other keys than Ctrl-C, too
 (2xESC, Ctrl-G, F10).

 --
 Jindrich Makovicka
[END]

I tried the find improvement. Responsibility is great (i.e. immediate).
E.g. moving through buttons is possible, while searching through a large file.


David
diff -X .diffignore -urNp mc/src/ChangeLog mc-find/src/ChangeLog
--- mc/src/ChangeLog	Tue Jul  1 19:53:15 CEST 2003
+++ mc-find/src/ChangeLog	Tue Jul  1 19:53:15 CEST 2003
@@ -0,0 +1,7 @@
+
+	* file.c: New enum for find progress state. Add context vars
+	for last position.
+	(check_find_events): New func.
+	(search_content): Resume operation and return status to the caller.
+	(run_process): Init.
+
diff -X .diffignore -urNp mc/src/find.c mc-find/src/find.c
--- mc/src/find.c	Wed Apr 16 17:26:29 2003
+++ mc-find/src/find.c	Tue Jul  1 19:42:37 2003
@@ -43,6 +43,7 @@
 #include "wtools.h"
 #include "cmd.h"		/* view_file_at_line */
 #include "boxes.h"
+#include "key.h"
 #include "../vfs/vfs.h"
 
 /* Size of the find parameters window */
@@ -64,6 +65,12 @@ enum {
 B_VIEW
 };
 
+typedef enum {
+FIND_CONT,
+FIND_SUSPEND,
+FIND_ABORT
+} FindProgressStatus;
+
 /* List of directories to be ignored, separated by ':' */
 char *find_ignore_dirs = 0;
 
@@ -80,6 +87,11 @@ static int matches;		/* Number of matche
 static int is_start;		/* Status of the start/stop toggle button */
 static char *old_dir;
 
+/* Where did we stop */
+static int resuming;
+static int last_line;
+static int last_pos;
+
 static Dlg_head *find_dlg;	/* The dialog */
 
 static WButton *stop_button;	/* pointer to the stop button */
@@ -437,32 +449,61 @@ get_line_at (int file_fd, char *buf, int
 return buffer;
 }
 
-/* 
+static FindProgressStatus
+check_find_events(Dlg_head *h)
+{
+Gpm_Event event;
+int c;
+
+c = get_event (&event, h->mouse_status == MOU_REPEAT, 0);
+if (c != EV_NONE) {
+   dlg_process_event (h, c, &event);
+   if (h->ret_value == B_ENTER
+   || h->ret_value == B_CANCEL
+   || h->ret_value == B_AGAIN
+   || h->ret_value == B_PANELIZE) {
+   /* dialog terminated */
+   return FIND_ABORT;
+   }
+   if (!h->send_idle_msg) {
+   /* searching suspended */
+   return FIND_SUSPEND;
+   }
+}
+
+return FIND_CONT;
+}
+
+/*
  * search_content:
  *
  * Search the global (FIXME) regexp compiled content_pattern string in the
  * DIRECTORY/FILE.  It will add the found entries to the find listbox.
+ *
+ * returns 0 if do_search should look for another file
+ * 1 if do_search should exit and proceed to the event handler
  */
-static void
+static int
 search_content (Dlg_head *h, char *directory, char *filename)
 {
 struct stat s;
 char buffer [BUF_SMALL];
 char *fname;
 int file_fd;
+int ret_val = 0;
 
 fname = concat_dir_and_file (directory, filename);
 
 if (mc_stat (fname, &s) != 0 || !S_ISREG (s.st_mode)){
 	g_free (fname);
-	return;
+	return 0;
 }
 
 file_fd = mc_open (fname, O_RDONLY);
 g_free (fname);
 
 if (file_fd == -1)
-	return;
+	return 0;
 
 g_snprintf (buffer, sizeof (buffer), _("Grepping in %s"), name_trunc (filename, FIND2_X_USE));
 
@@ -480,7 +521,15 @@ search_content (Dlg_head *h, char *direc
 	char *p;
 	int found = 0;
 
-	while ((p = get_line_at (file_fd, buffer, &pos, &n_read, sizeof (buffer), &has_newline))){
+	if (resuming) {
+	   /* We've been previously suspended, start from the previous positio n */
+	   resuming = 0;
+	   line = last_line;
+	   pos = last_pos;
+	}
+
+while ((p = get_line_at (file_fd, buffer, &pos, &n_read, sizeof (buffer), &has_newline))
+		&& (ret_val == 0)) {
 	if (found == 0){	/* Search in binary line once */
 		if (regexec (r, p, 1, 0, 0) == 0){
 		g_free (p);
@@ -494,10 +543,37 @@ search_content (Dlg_head *h, char *direc
 		found = 0;
 	}
 	g_free (p);
+
+	if ((line & 0xff) == 0) {
+		FindProgressStatus res;
+
+		printf("\n\r***");
+		sleep(2);
+
+		res = check_find_events(h);
+		switch (res) {
+		case FIND_ABORT:
+		stop_idle (h);
+		ret_val = 1;
+		break;
+
+		case FIND_SUSPEND:
+		resuming = 1;
+		last_line = line;
+		last_

BUG: Bg. copy & RO overwrite, assertion fail

[David Sterba]

Hi,

assume this situation:
1. make a directory
2. copy some files into this dir
3. remove write acces
4. copy the same files into the directory again
   in background
5. [expect] file replace query dialog should pop up
   (as in foreground mode)
   [got] assertion fail in filegui.c:685

The test ctx->ui != NULL fails and the program silently
continues (i.e. no warning message).

The problem is in:
file.c:1934 (panel_operate).
if (do_bg)
ctx->ui = NULL;
else
file_op_context_create_ui (ctx, operation, 1);

and the assertion later filegui.c:685 (file_progress_real_query_replace)
g_return_val_if_fail (ctx->ui != NULL, FILE_CONT);
fails.

One solution is to let create the UI context for foreground and also
for background.


Btw, the context in the parent process is not destroyed. The line
is commented out. (file.c:1913)
I think, it' a leak, because the operation context is created locally
in panel_operate and destruction does not affect the child.


David


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: How to apply snapshot patches?

[David Sterba]

Hi

> Could anybody tell me a way to cleanly apply snapshot patches to
> the reference (4.6.0) tree?
>
> I'm doing
>
> $ cd mc-4.6.0
> $ patch -p4 < ../mc-4.6.0-2003-06-25-17.diff
I think the problem is in '-p4'. If you cd into right mc tree,
there should go '-p1' which means 'strip one directory from left'.
see 'man patch' for details (e.g. the parameter '-p').

bye
David


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Sugesstion for code cleanups

[David Sterba]

Hi,

I just looked around sources and found many FIXMEs. Some of
them apparently old or talking about thinks that should be
really fixed (but are not).

I'd like to ask, if it's worth to map all these parts,
analyze or suggest correct solution,
and add new potentially suspicious parts.

Most of them are code cleanups, some need wider code changes.

I don't know if it's convenient to treat all such parts as bugs
and file them into BTS or just put some items to TODO.


bye
David

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

[PATCH] Typos in hints.cs

[David Sterba]

Hi,

just fix for simple typos in Czech hint file.


David
--- lib/mc.hint.cs
+++ lib/mc.hint.cs
@@ -5,7 +5,7 @@
 Tip: Chcete zadat speciální znak(napø. tabelátor)? Pou¾ijte Ctrl-Q a daný znak.
 Tip: Nechcete ji¾ vidìt tipy? Vypnìte je v Nastavení/Zobrazení/Dal¹í nastavení.
 Tip: Adresáøe vyberete pøidáním lomítka na konec vzorku.
-Tip: Pokud Vá¹ terminál nezní nebo nemá funkèní klávesy, pou¾ijte Esc+èíslo.
+Tip: Pokud Vá¹ terminál nezná nebo nemá funkèní klávesy, pou¾ijte Esc+èíslo.
 Tip: Domácí stránka programu Midnight Commander je http://www.ibiblio.org/mc/
 Tip: Zprávy o chybách posílejte na [EMAIL PROTECTED] (anglicky).
 Tip: Pomocí klávesy Tab zmìníte aktuální panel.
@@ -22,12 +22,12 @@
 Tip: Chcete vidìt zálohy svých souborù (konèí ~). Pou¾ijte Nastavení.
 Tip: Doplòování funguje ve vstupních øádkách v¹ech dialogù. Pou¾ijte M-Tab.
 Tip: Na terminálech s pomalou odezvou skuste na parametr -s (mc -s).
-Tip: S nalezenými soubory mù¾ete pracovat. Stiknìte tlaèítko Panelizace.
+Tip: S nalezenými soubory mù¾ete pracovat. Stisknìte tlaèítko Panelizace.
 Tip: Pro opravdu slo¾ité operace zkuste pøíkaz Pøíkaz/Externí panelizace.
 Tip: Pokud chcete zmìnit adresáø pøi práci na pøíkoazové øádce, zkuste M-c.
 Poznámka: Pøíkazy shellu nefungují, pokud nepracujete na lokální systému souborù.
 Tip: Smazaný text obnovíte C-y.
-Tip: Pokud nìkteré klávesy nefunfují, pou¾ijte menu Nastavení/uèení kláves.
+Tip: Pokud nìkteré klávesy nefungují, pou¾ijte menu Nastavení/uèení kláves.
 Tip: F13 (nebo Shift-F3) vyvolá prohlí¾ení bez zpracování obsahu souboru.
 Tip: Pokud v xtermu nepracují klávesy, zkuste soubory xterm.ad, .ti a .tcap.
 Tip: Editor pro klávesu F4 urèíte pomocí promìnné prostøedí EDITOR.

[PATCH] Add 'Refresh', 'Free all VFS' to VFS list dialog

[David Sterba]

Hi,

I'm sending a patch which adds buttons for freeing and refreshing VFS list
in the dialog 'Active VFS list', and removes the redundant item
from menu.

It seems to me more logical to keep VFS list-related things in one place.


David
diff -X .diffignore -urNp mc/src/ChangeLog mc-vfs/src/ChangeLog
--- mc/src/ChangeLog	Sat Jun 28 14:55:50 CEST 2003
+++ mc-vfs/src/ChangeLog	Sat Jun 28 14:55:50 CEST 2003
@@ -0,0 +1,8 @@
+2003-06-27  David Sterba  <[EMAIL PROTECTED]>
+
+	* hotlist.c: Add buttons 'Refresh', 'Free all VFS' to Active VFS
+	dialog.
+	(hotlist_button_callback): Handle the buttons.
+
+	* main.c: Remove the 'Free VFS now' menu item.
+
diff -X .diffignore -urNp mc/src/hotlist.c mc-vfs/src/hotlist.c
--- mc/src/hotlist.c	Sat Dec 21 09:43:15 2002
+++ mc-vfs/src/hotlist.c	Fri Jun 27 16:17:06 2003
@@ -68,6 +68,11 @@
 #define B_APPEND	(B_USER + 6)
 #define B_MOVE		(B_USER + 7)
 
+#ifdef	USE_VFS
+#define B_FREE_ALL_VFS	(B_USER + 8)
+#define B_REFRESH_VFS	(B_USER + 9)
+#endif
+
 static WListbox *l_hotlist;
 static WListbox *l_movelist;
 
@@ -117,6 +122,10 @@ static struct _hotlist_but {
 { B_CANCEL, NORMAL_BUTTON,   0,   53, N_("&Cancel"), "cc",   LIST_HOTLIST|LIST_VFSLIST|LIST_MOVELIST},
 { B_UP_GROUP, NORMAL_BUTTON, 0,   42, N_("&Up"), "up",   LIST_HOTLIST|LIST_MOVELIST},
 { B_ADD_CURRENT, NORMAL_BUTTON,  0,   20, N_("&Add current"),"ad",   LIST_HOTLIST},
+#ifdef	USE_VFS
+{ B_REFRESH_VFS, NORMAL_BUTTON,  0,   43, N_("&Refresh"), "r",   LIST_VFSLIST},
+{ B_FREE_ALL_VFS, NORMAL_BUTTON, 0,   20, N_("Free &all VFS now"), "f", LIST_VFSLIST},
+#endif
 { B_ENTER, DEFPUSH_BUTTON,   0,0, N_("Change &To"),  "ct",   LIST_HOTLIST|LIST_VFSLIST|LIST_MOVELIST},
 };
 
@@ -252,6 +261,13 @@ unlink_entry (struct hotlist *entry)
 	entry->up = 0;
 }
 
+#ifdef USE_VFS
+static void add_name_to_list (char *path)
+{
+listbox_add_item (l_hotlist, 0, 0, path, 0);
+}
+#endif /* !USE_VFS */
+
 static int hotlist_button_callback (int action, void *data)
 {
 switch (action) {
@@ -369,6 +385,18 @@ static int hotlist_button_callback (int 
 	break;
 	}
 
+#ifdef	USE_VFS
+case B_FREE_ALL_VFS:
+	vfs_expire (1);
+	/* fall through */
+
+case B_REFRESH_VFS:
+	listbox_remove_list (l_hotlist);
+	listbox_add_item (l_hotlist, 0, 0, home_dir, 0);
+	vfs_fill_names (add_name_to_list);
+	return 0;
+#endif	/* USE_VFS */
+
 default:
 	return 1;
 	break;
@@ -477,13 +505,6 @@ static int l_call (void *l)
 hotlist_callback (dlg, 'u', DLG_POST_KEY);
 return listbox_nothing;
 }
-
-#ifdef USE_VFS
-static void add_name_to_list (char *path)
-{
-listbox_add_item (l_hotlist, 0, 0, path, 0);
-}
-#endif /* !USE_VFS */
 
 /*
  * Expands all button names (once) and recalculates button positions.
diff -X .diffignore -urNp mc/src/main.c mc-vfs/src/main.c
--- mc/src/main.c	Mon Jun 23 20:40:23 2003
+++ mc-vfs/src/main.c	Sat Jun 28 14:50:02 2003
@@ -917,7 +917,6 @@ static menu_entry CmdMenu[] = {
 {' ', N_("di&Rectory hotlistC-\\"), 'R', quick_chdir_cmd},
 #ifdef USE_VFS
 {' ', N_("&Active VFS list  C-x a"), 'A', reselect_vfs},
-{' ', N_("Fr&ee VFSs now"), 'E', free_vfs_now},
 #endif
 #ifdef WITH_BACKGROUND
 {' ', N_("&Background jobs  C-x j"), 'B', jobs_cmd},

Re: Why my mouse does not work under console (under xterm i works fine)?

[David Sterba]

Hi,

> Why my mouse does not work under console (under xterm i works fine)?

What do you mean by 'does not work'? The mouse cursor does not appear
at all, or it's just incorrect interaction with MC?

Look if the GPM is running (process 'gpm').
In short, it's a program which handles mouse on console. See 'man gpm' for 
more details.


David


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] Add 'Ignore ...' buttons to error msg window

[David Sterba]

Hi,

> What about keeping current buttons, but changing 'Ignore' from 'Ignore
> all' to 'Ignore similar'? That seems right the right thing to do
> (without having to explain what Ignore similar means).

I think it will be more consistent with other commanders to have
buttons for 'ignore' (just one) and 'ignore all' (for all such errors).
If a new error type pops up the user shall choose again.

So, the button 'Ignore similar' got removed.


David


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] Do not select symlinked dirs as files

[David Sterba]

Hi,

> I think it's a wrong place.  Whether you want to select symlinks to
> directories depends on the data you are working with, not on what kind
> of user you are.
Yes, I agree. 

> This should be in the select dialog.
Done.

Select/Unselect input dialog now shows the option.
I added new functions to handle the extended input dialog and let
(only) the select/unselect dialog to use it. Other input dialogs are left
unchanged (layout, contents and calling functions).
See changelog for details.


David
diff -S ChangeLog -X .diffignore -urNp mc/src/ChangeLog mc-sel/src/ChangeLog
--- mc/src/ChangeLog	Sun Jun 15 21:15:13 2003
+++ mc-sel/src/ChangeLog	Wed Jun 18 12:19:37 2003
@@ -0,0 +1,18 @@
+2003-06-18  David Sterba  <[EMAIL PROTECTED]>
+
+	* background.c: Set number of supported arguments for background
+	jobs to 6 due to extensions of quick dialog.
+	(background_attention): Handle the count.
+	(message_3s): Fix the incorrect number of params passed.
+	(input_dialog_help): Adjust call to real_input_dialog_help.
+	(input_dialog_help_ext): New function.
+	* cmd.c (select_cmd, unselect_cmd, reverse_selection_cmd):
+	Handle symlinked directories as directories in file selections
+	if wanted. Add a variable for it.
+	(unselect_cmd, select_cmd): Add extended option to selection dialog.
+	* main.h: Extern the variable.
+	* wtools.c (real_input_dialog_help): New param for dlg extension.
+	Split widget sets into basic and extended. Update layout of dialog.
+	(input_dialog_ext): New function. Extends the basic input dialog.
+	* wtools.h: Add new functions and extension enum. 
+
diff -S ChangeLog -X .diffignore -urNp mc/src/background.c mc-sel/src/background.c
--- mc/src/background.c	Mon Jun  2 20:13:43 2003
+++ mc-sel/src/background.c	Wed Jun 18 12:09:20 2003
@@ -66,7 +66,7 @@ int socketpair(int, int, int, int fd[2])
 /* File descriptor for talking to our parent */
 static int parent_fd;
 
-#define MAXCALLARGS 4		/* Number of arguments supported */
+#define MAXCALLARGS 6		/* Number of arguments supported */
 #define mymsg "Desde el hijo\n\r"
 
 struct TaskList *task_list = NULL;
@@ -330,6 +330,14 @@ background_attention (int fd, void *clos
 		result = (*(int (*)(int, char *, char *, char *, char *))routine)
 		(Background, data [0], data [1], data [2], data [3]);
 		break;
+	case 5:
+		result = (*(int (*)(int, char *, char *, char *, char *, char *))routine)
+		(Background, data [0], data [1], data [2], data [3], data [4]);
+		break;
+	case 6:
+		result = (*(int (*)(int, char *, char *, char *, char *, char *, char *))routine)
+		(Background, data [0], data [1], data [2], data [3], data [4], data [5]);
+		break;
 	}
 	else
 	switch (argc){
@@ -349,6 +357,14 @@ background_attention (int fd, void *clos
 		result = (*(int (*)(FileOpContext *, int, char *, char *, char *, char *))routine)
 		(ctx, Background, data [0], data [1], data [2], data [3]);
 		break;
+	case 5:
+		result = (*(int (*)(FileOpContext *, int, char *, char *, char *, char *, char *))routine)
+		(ctx, Background, data [0], data [1], data [2], data [3], data [4]);
+		break;
+	case 6:
+		result = (*(int (*)(FileOpContext *, int, char *, char *, char *, char *, char *, char *))routine)
+		(ctx, Background, data [0], data [1], data [2], data [3], data [4], data [5]);
+		break;
 	}
 
 	/* Send the result code and the value for shared variables */
@@ -378,6 +394,14 @@ background_attention (int fd, void *clos
 	resstr = (*(char * (*)(char *, char *, char *, char *))routine)
 		(data [0], data [1], data [2], data [3]);
 	break;
+	case 5:
+	resstr = (*(char * (*)(char *, char *, char *, char *, char *))routine)
+		(data [0], data [1], data [2], data [3], data [4]);
+	break;
+	case 6:
+	resstr = (*(char * (*)(char *, char *, char *, char *, char *, char*))routine)
+		(data [0], data [1], data [2], data [3], data [4], data [5]);
+	break;
 	default: g_assert_not_reached();
 	}
 	if (resstr){
@@ -509,7 +533,7 @@ message_3s (int flags, char *title, cons
 	const char *str2, const char *str3)
 {
 if (we_are_background)
-	parent_call ((void *)real_message_3s, NULL, 3, sizeof (flags), &flags,
+	parent_call ((void *)real_message_3s, NULL, 5, sizeof (flags), &flags,
 		 strlen (title), title, strlen (str1), str1,
 	 strlen (str2), str2, strlen (str3), str3);
 else
@@ -526,7 +550,21 @@ input_dialog_help (char *header, char *t
    strlen (help), help,
    strlen (def_text), def_text);
 else
-	return real_input_dialog_help (header, text, help, def_text);
+	return real_input_dialog_help (0, header, text, help, def_text);
+}
+
+char *
+input_dialog_help_ext (DlgExtensions ext, char *header, char *text, char *help, char *def_text)
+{
+if (we_are_background)
+	return parent_call_string ((void *)real_input_dialog_help, 5,
+   sizeof (ext),  &ext,
+   strlen (header),   header,
+   strlen (tex

Re: [PATCH] Do not select symlinked dirs as files

[David Sterba]

Hi,

so, now it is possible to choose in 'Configuration' menu whether to select
symlinked dir as file or directory.

The default (after first run of patched mc) is as before (i.e.
sym. dir as file).

Patch uploaded to MC patch tracking system.

David

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

[PATCH] Fix for segfault on large syntax file

[David Sterba]

Hi,

this pach fixes segfaulting on syntax files with more than
1024 keywords per context (and possibly with more than
128 contexts). These numbers were harcoded and now they grow
as the alloced number does not suffice.

This fixes a bug number #3829 in MC bug tracking system.

Motto: "1024 will be enough for everyone forever"


David
diff -S ChangeLog -X .diffignore -urNp mc/edit/ChangeLog mc-large-syntax/edit/ChangeLog
--- mc/edit/ChangeLog	Tue Jun 10 18:59:53 2003
+++ mc-large-syntax/edit/ChangeLog	Fri Jun 13 19:13:32 2003
@@ -0,0 +1,6 @@
+2003-06-13  David Sterba  <[EMAIL PROTECTED]>
+
+	* syntax.c (edit_read_syntax_rules): Dynamically allocate
+	more space for contexts and for words in context. Fixes segfault
+	on syntax files with more than 1024 keywords in a context.
+
diff -S ChangeLog -X .diffignore -urNp mc/edit/syntax.c mc-large-syntax/edit/syntax.c
--- mc/edit/syntax.c	Thu Mar  6 19:42:33 2003
+++ mc-large-syntax/edit/syntax.c	Fri Jun 13 19:17:40 2003
@@ -648,13 +648,16 @@ edit_read_syntax_rules (WEdit *edit, FIL
 int num_words = -1, num_contexts = -1;
 int argc, result = 0;
 int i, j;
+int alloc_contexts = MAX_CONTEXTS,
+	alloc_words_per_context = MAX_WORDS_PER_CONTEXT,
+	max_alloc_words_per_context = MAX_WORDS_PER_CONTEXT;
 
 args[0] = 0;
 
 strcpy (whole_left, "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_01234567890");
 strcpy (whole_right, "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_01234567890");
 
-r = edit->rules = g_malloc0 (MAX_CONTEXTS * sizeof (struct context_rule *));
+r = edit->rules = g_malloc0 (alloc_contexts * sizeof (struct context_rule *));
 
 if (!defines)
 	defines = g_tree_new ((GCompareFunc) strcmp);
@@ -760,10 +763,7 @@ edit_read_syntax_rules (WEdit *edit, FIL
 		c->first_left = *c->left;
 		c->first_right = *c->right;
 	}
-	c->keyword = g_malloc0 (MAX_WORDS_PER_CONTEXT * sizeof (struct key_word *));
-#if 0
-	c->max_words = MAX_WORDS_PER_CONTEXT;
-#endif
+	c->keyword = g_malloc0 (alloc_words_per_context * sizeof (struct key_word *));
 	num_words = 1;
 	c->keyword[0] = g_malloc0 (sizeof (struct key_word));
 	subst_defines (defines, a, &args[1024]);
@@ -780,7 +780,15 @@ edit_read_syntax_rules (WEdit *edit, FIL
 	c->keyword[0]->color = this_try_alloc_color_pair (fg, bg);
 	c->keyword[0]->keyword = g_strdup (" ");
 	check_not_a;
-	num_contexts++;
+
+	alloc_words_per_context = MAX_WORDS_PER_CONTEXT;
+	if (num_contexts++ > alloc_contexts) {
+		struct context_rule **tmp;
+
+		alloc_contexts += 128;
+		tmp = g_realloc (r, alloc_contexts * sizeof (struct context_rule *));
+		r = tmp;
+	}
 	} else if (!strcmp (args[0], "spellcheck")) {
 	if (!c) {
 		result = line;
@@ -828,7 +836,18 @@ edit_read_syntax_rules (WEdit *edit, FIL
 		bg = last_bg;
 	k->color = this_try_alloc_color_pair (fg, bg);
 	check_not_a;
-	num_words++;
+
+	if (num_words++ > alloc_words_per_context) {
+		struct key_word **tmp;
+
+		alloc_words_per_context += 1024;
+
+		if (alloc_words_per_context > max_alloc_words_per_context)
+		max_alloc_words_per_context = alloc_words_per_context;
+
+		tmp = g_realloc (c->keyword, alloc_words_per_context * sizeof (struct key_word *));
+		c->keyword = tmp;
+	}
 	} else if (*(args[0]) == '#') {
 	/* do nothing for comment */
 	} else if (!strcmp (args[0], "file")) {
@@ -870,7 +889,10 @@ edit_read_syntax_rules (WEdit *edit, FIL
 }
 
 {
-	char first_chars[MAX_WORDS_PER_CONTEXT + 2], *p;
+	char *first_chars, *p;
+
+	first_chars = g_malloc (max_alloc_words_per_context + 2);
+
 	for (i = 0; edit->rules[i]; i++) {
 	c = edit->rules[i];
 	p = first_chars;
@@ -880,6 +902,8 @@ edit_read_syntax_rules (WEdit *edit, FIL
 	*p = '\0';
 	c->keyword_first_chars = g_strdup (first_chars);
 	}
+
+	g_free (first_chars);
 }
 
 return result;

Re: [PATCH] Do not select symlinked dirs as files

[David Sterba]

Hi,

> I don't like this. I want when selecting all that symlinks are being
> selected as well. With other words. It should behave as it is now.

Well, let's make it optional then (in 'Configuration' menu), because
it is not always the desired behaviour.

David

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

(no subject)

[David Sterba]

Hi,

I'd like to ask, what is the rason of excluding operation 'Move' from
computing totals in panel_operate() [file.c:2023] ?

code:
-- file.c -
// this vvv
if (operation != OP_MOVE && verbose && file_op_compute_totals) {
panel_compute_totals (panel, &ctx->progress_count,
  &ctx->progress_bytes);
---

Without the first condition the progress dialog of 'Move' shows the same
information about 'totals' as 'Copy'.

David

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

[PATCH] Do not select symlinked dirs as files

[David Sterba]

Hi,

this patch changes selection of files and dirs so that
symlinked dirs are not selected as files, but only
as directories (i.e. with "/" appended to file mask in selection dialog).

'Select', 'Unselect' and 'Reverse select' are consistent.

I think this i correct behaviour.

David
2003-06-11  David Sterba  <[EMAIL PROTECTED]>

* cmd.c (select_cmd, unselect_cmd, reverse_selection_cmd):
Handle symlinked directories as directories in file selections.

diff -X .diffignore -urNp mc/src/cmd.c mc-1ft/src/cmd.c
--- mc-sel/src/cmd.c	Tue Feb 18 06:25:45 2003
+++ mc/src/cmd.c	Wed Jun 11 12:46:03 2003
@@ -502,7 +502,8 @@ void reverse_selection_cmd (void)
 
 for (i = 0; i < cpanel->count; i++){
 	file = &cpanel->dir.list [i];
-	if (S_ISDIR (file->buf.st_mode))
+	if (S_ISDIR (file->buf.st_mode) ||
+	link_isdir ( &(cpanel->dir.list [i]) ))
 	continue;
 	do_file_mark (cpanel, i, !file->f.marked);
 }
@@ -535,7 +536,8 @@ void select_cmd (void)
 for (i = 0; i < cpanel->count; i++){
 if (!strcmp (cpanel->dir.list [i].fname, ".."))
 continue;
-	if (S_ISDIR (cpanel->dir.list [i].buf.st_mode)){
+	if (S_ISDIR (cpanel->dir.list [i].buf.st_mode) ||
+	link_isdir ( &(cpanel->dir.list [i]) )) {
 	if (!dirflag)
 continue;
 } else {
@@ -579,9 +581,10 @@ void unselect_cmd (void)
 reg_exp_t [strlen(reg_exp_t) - 1] = 0;
 }
 for (i = 0; i < cpanel->count; i++){
-if (!strcmp (cpanel->dir.list [i].fname, "..")) 
+if (!strcmp (cpanel->dir.list [i].fname, ".."))
 continue;
-	if (S_ISDIR (cpanel->dir.list [i].buf.st_mode)){
+	if (S_ISDIR (cpanel->dir.list [i].buf.st_mode) ||
+	link_isdir ( &(cpanel->dir.list [i]) )) {
 	if (!dirflag)
 	continue;
 } else {

[PATCH] Add 'Ignore ...' buttons to error msg window

[David Sterba]

;
+return real_do_file_error (ctx, Foreground, ign, str);
 }
 
 static int
diff -X .diffignore -urNp mc/src/file.h mc-ignore/src/file.h
--- mc/src/file.h	Sun Dec  8 19:59:50 2002
+++ mc-ignore/src/file.h	Tue Jun 10 12:50:13 2003
@@ -30,10 +30,10 @@ extern int file_op_compute_totals;
 
 /* Error reporting routines */
 /* Report error with one file */
-int file_error (char *format, char *file);
+int file_error (FileOpContext *ctx, FileErrorIgnoreSet ign, char *format, char *file);
 
 /* Report error with two files */
-int files_error (char *format, char *file1, char *file2);
+int files_error (FileOpContext *ctx, FileErrorIgnoreSet ign, char *format, char *file1, char *file2);
 
 /* Query routines */
 
diff -X .diffignore -urNp mc/src/fileopctx.c mc-ignore/src/fileopctx.c
--- mc/src/fileopctx.c	Thu Dec 26 20:04:10 2002
+++ mc-ignore/src/fileopctx.c	Tue Jun 10 14:32:10 2003
@@ -51,6 +51,7 @@ file_op_context_new (void)
 ctx->preserve_uidgid = (geteuid () == 0) ? TRUE : FALSE;
 ctx->umask_kill = 077;
 ctx->erase_at_end = TRUE;
+ctx->ignore_set = IGN_NONE;
 
 return ctx;
 }
diff -X .diffignore -urNp mc/src/fileopctx.h mc-ignore/src/fileopctx.h
--- mc/src/fileopctx.h	Fri Jun  6 20:17:55 2003
+++ mc-ignore/src/fileopctx.h	Tue Jun 10 15:04:41 2003
@@ -52,6 +52,16 @@ typedef struct {
 	/* Controls appending to files */
 	int do_append;
 
+	/* Ignore errors (all, similar, in current directory) */
+	/* contains flags of ignored errors:
+	 * IGN_RMDIR - ignores error on dir removal
+	 * IGN_CHOWN
+	 * IGN_CHMOD
+	 * IGN_STAT - ignore 'cannot stat' error
+	 * IGN_ALL - all previous
+	 */
+	int ignore_set;
+
 	/* Whether to stat or lstat */
 	int follow_links;
 
@@ -129,6 +139,27 @@ typedef enum {
 RECURSIVE_NEVER,
 RECURSIVE_ABORT
 } FileCopyMode;
+
+typedef enum {
+IGN_NONE = 0,
+IGN_RMDIR = 1<<0,
+IGN_CHOWN = 1<<1,
+IGN_CHMOD = 1<<2,
+IGN_STAT = 1<<3,
+
+IGN_LAST_FLAG = 1<<4,
+IGN_MASK = (IGN_LAST_FLAG)-1,
+
+IGN_ONE = 1<<8,	/* should not display 'ignore all/similar' for one file*/
+IGN_ALL = 1<<9
+} FileErrorIgnoreSet;
+
+#define IGNORE_TEST(ctx,flag)	((ctx)->ignore_set & (flag) & IGN_MASK)
+#define IGNORE_SET(ctx,flag)	((ctx)->ignore_set |= ((flag) & IGN_MASK))
+#define IGNORE_ONE(ctx)	((ctx)->ignore_set & (IGN_ONE))
+#define IGNORE_ONE_SET(ctx)	((ctx)->ignore_set |= IGN_ONE)
+#define IGNORE_ALL_SET(ctx)	((ctx)->ignore_set |= IGN_ALL)
+#define IGNORE_ALL(ctx)		((ctx)->ignore_set & IGN_ALL)
 
 /* First argument passed to real functions */
 enum OperationMode {
Binary files mc/src/man2hlp and mc-ignore/src/man2hlp differ
Binary files mc/src/mc and mc-ignore/src/mc differ
Binary files mc/src/mcmfmt and mc-ignore/src/mcmfmt differ
diff -X .diffignore -urNp mc/src/tree.c mc-ignore/src/tree.c
--- mc/src/tree.c	Mon Mar 10 21:27:55 2003
+++ mc-ignore/src/tree.c	Tue Jun 10 13:22:11 2003
@@ -702,7 +702,7 @@ static void tree_move (WTree *tree, char
 	return;
 }
 if (!S_ISDIR (buf.st_mode)){
-	file_error (_(" Destination \"%s\" must be a directory \n %s "),
+	file_error (NULL, IGN_NONE, _(" Destination \"%s\" must be a directory \n %s "),
 		dest);
 	g_free (dest);
 	return;
2003-06-10  David Sterba  <[EMAIL PROTECTED]>

Add 'Ignore ...' buttons to error message dialogs
* fileopctx.h: New item containing ignore flags into context.
New macros to test/set flags.
* fileopctx.c (file_op_context_new): Init the item.

* file.h: Add params to file_error, files_error.
* file.c: Add params to do_file_error, real_do_file_error.
Adjust all callers of file_error, files_error, do_file_error.
(do_file_error): Update background processing
(real_do_file_error): Add params and update all callers, namely
while background processing.
Add options to query dialog and handle result (set ignored flags).
(file_error, files_error): Test for ignored flags and don't display
message.

* tree.c: Adjust caller of file_error.

Bug in background processing and error handling

[David Sterba]

Hi,

while implementing 'Ignore ...' buttons to error messages,
I came accros a strange behaviour of
background processing + error handling.

Let's say, I want to copy many files into a directory
but don't have permission to.
In case of foreground processing, everythig is ok.

Now do the same, but send the copy job to background (in copy dialog).
The error message dialog pops up and says 'Permission denied ...', that's ok.
For now on, any user action (keypress) pops up next error window, until
all errors are gone.

I opened the background job list from menu (and closing the error window
every time). The job was marked 'Running', ok.
'Stop' button correctly stops the job, and no more errors pop up.
'Kill' (right after Stop or not) pops up 2 error windows concerning background
errors 'Background sent us a request for more arguments than we can handle'
and 'Unknown error in child'.
MC process starts to eat up the whole memory and CPU and gets killed
by OOM Kill.

'Resume' on Stopped job behaves like before Stop.

Pressing 'Abort' on first (or any) error message stops popping the
messages but the job remains background marked 'Running' and
can be killed safely.


While testing the 'Ignore all' button on error messages and background
processing, the job does not pop up any error message, but seem so
sleep. In list of bkg. jobs is marked as 'Running'.
'Stop'/'Resume' works fine, but the job canot be killed.

Assuming that any keypress will let the bkg. job continue I tried
to copy a few files (on bkg.) and then viewing the bgk. job list,
but the job remained 'Running'.


I haven't looked into background processing code, so these are only my
observations.


If desired, I will fill in bugzilla (when savannah.org will be up again).

MC version - 4.6.0 cvs 8.6.2003 (but earlier versions seem to be affected 
too).


David


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

[PATCH] Assume Shift+Backspace is Backspace

[David Sterba]

Hello,

I'm sending a patch, wich corrects keypress of 'Shift+Backspace'
to 'Backspace'.

It seems to me more comfortable not to release the Shift key
when typing variable name and making a typo.
By now Shift+BS does nothing and only slows down typing.

I think Shift+BS has not any specific meaning which could be
possibly broken by such change.


David
diff -urN key.c.orig key.c
--- key.c.orig	Sat Mar 15 01:31:15 2003
+++ key.c	Mon May 12 21:08:38 2003
@@ -595,6 +595,12 @@
 	mod &= ~KEY_M_CTRL;
 }
 
+/* Shift+BackSpace is backspace */
+if (c == KEY_BACKSPACE && (mod & KEY_M_SHIFT)) {
+c = KEY_BACKSPACE;
+mod &= ~KEY_M_SHIFT;
+}
+
 /* Convert Shift+Fn to F(n+10) */
 if (c >= KEY_F (1) && c <= KEY_F (10) && (mod & KEY_M_SHIFT)) {
 	c += 10;

Re: File find: open viewer does not jump to line?

[David Sterba]

Hi,

> Can you sent here diff -u .mc-old/ini .mc/ini output?
Attached.

Dave
--- .mc-old/ini	Fri Feb  7 20:31:55 2003
+++ .mc/ini	Fri Feb  7 21:13:11 2003
@@ -1,18 +1,4 @@
 
-[Layout]
-equal_split=1
-first_panel_size=50
-message_visible=0
-keybar_visible=0
-xterm_hintbar=0
-output_lines=0
-menubar_visible=0
-command_prompt=1
-show_mini_info=1
-permission_mode=1
-filetype_mode=1
-xterm_title=1
-
 [Midnight-Commander]
 show_backups=1
 show_dot_files=1
@@ -21,11 +7,10 @@
 pause_after_run=1
 shell_patterns=1
 auto_save_setup=1
-align_extensions=1
 auto_menu=0
 use_internal_view=1
-use_internal_edit=0
-clear_before_exec=0
+use_internal_edit=1
+clear_before_exec=1
 mix_all_files=0
 fast_reload=0
 fast_reload_msg_shown=0
@@ -36,22 +21,19 @@
 safe_delete=0
 mouse_repeat_rate=100
 double_click_speed=250
-eight_bit_clean=1
-full_eight_bits=1
-use_8th_bit_as_meta=0
+use_8th_bit_as_meta=1
 confirm_view_dir=0
 mouse_move_pages=1
 mouse_move_pages_viewer=1
 fast_refresh=0
 navigate_with_arrows=0
-advanced_chown=1
 drop_menus=0
 wrap_mode=1
 old_esc_mode=0
 cd_symlinks=1
 show_all_if_ambiguous=0
-have_fast_cpu=1
-iconify_on_exec=1
+have_fast_cpu=0
+max_dirt_limit=10
 torben_fj_mode=0
 use_file_to_guess_type=1
 alternate_plus_minus=0
@@ -77,6 +59,7 @@
 editor_backspace_through_tabs=0
 editor_fake_half_tabs=1
 editor_option_save_mode=0
+editor_option_save_position=1
 editor_option_backup_ext_int=-1
 editor_option_auto_para_formatting=0
 editor_option_typewriter_wrap=0
@@ -84,53 +67,56 @@
 editor_syntax_highlighting=1
 nice_rotating_dash=1
 horizontal_split=0
-max_dirt_limit=10
-editor_option_save_position=1
+
+[Layout]
+equal_split=1
+first_panel_size=50
+message_visible=1
+keybar_visible=1
+xterm_title=1
+output_lines=0
+command_prompt=1
+menubar_visible=1
+show_mini_info=1
+permission_mode=0
+filetype_mode=1
 
 [Dirs]
-other_dir=/usr/src/linux-2.4.20B/drivers/scsi
-current_is_left=1
+other_dir=/mnt/hotv/home/sterd9am/.mc
+current_is_left=0
 
 [New Left Panel]
 display=listing
 reverse=0
 case_sensitive=1
 sort_order=name
-list_mode=user
-user_format=half type,name,|,size,|,perm
-user_status0=half type,name,perm
-user_status1=half type,name,|,size,|,perm
-user_status2=half type,name
-user_status3=half type,name
-user_status4=half type,name,|,size,|,perm
-user_mini_status=1
+list_mode=full
+user_format=half type name | size | perm
+user_status0=half type name | size | perm
+user_status1=half type name | size | perm
+user_status2=half type name | size | perm
+user_status3=half type name | size | perm
+user_mini_status=0
 
 [New Right Panel]
 display=listing
 reverse=0
 case_sensitive=1
 sort_order=name
-list_mode=user
-user_format=half type,name,|,size,|,perm
-user_status0=half type,name,perm
-user_status1=half type,name,|,size,|,perm
-user_status2=half type,name
-user_status3=half type,name
-user_status4=half type,name,|,size,|,perm
-user_mini_status=1
+list_mode=full
+user_format=half type name | size | perm
+user_status0=half type name | size | perm
+user_status1=half type name | size | perm
+user_status2=half type name | size | perm
+user_status3=half type name | size | perm
+user_mini_status=0
 
 [Misc]
[EMAIL PROTECTED]
+ftpfs_password=anonymous@
 ftp_proxy_host=gate
-display_codepage=ISO-8859-2
-
-[terminal:xterm]
-bs=
-end=\eOF
-home=\eOH
+display_codepage=Other_8_bit
 
 [Panelize]
 Find *.orig after patching=find . -name \*.orig -print
 Find SUID and SGID programs=find . \( \( -perm -04000 -a -perm +011 \) -o \( -perm -02000 -a -perm +01 \) \) -print
 Find rejects after patching=find . -name \*.rej -print
-neco=fgrep

Re: File find: open viewer does not jump to line?

[David Sterba]

Hi,

> You can try this before running mc:
>
> $ cd
> $ mv .mc .mc-old
> (and may be)
>
> Sometimes fresh configuration solves strange problems.
Yes, it works now.

Dave
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: File find: open viewer does not jump to line?

[David Sterba]

Hi,

> Give more details.  Describe:
>
> 1) What you do.
I open the file find dialog. Enter the string to search. Press OK to start 
search. Wait until some files are found. Go to the entry, pres F3. The 
internal viewer opens. Press F5 (view current line). It always show 1, 
although the found entry says e.g. "ChangeLog:1054".

> 2) What you expect to get.
I expect to be positioned to line 1054.

> 3) What you actually get.
The file position is always on first line.

> If you are using external viewer and editor, starting on a certain line is
> not supported for an obvious reason - different viewers and editors may
> have different command line switches for that.
This happens with the internal viewer.

bye
David

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: File find: open viewer does not jump to line?

[David Sterba]

Hi,


> Hello David.
>
> On Fri, 7 Feb 2003, David Sterba wrote:
> > [in mc 4.6.0]
> > opening editor/viewer in file find dialog does not go to the line.
> > I think, it worked in the past versions.
>
> Strange.
> It works for me.

I just compiled and tried the latest CVS version, but it still does not work.
Maybe the error is only at me. Well, I'll try to find out what's wrong.

bye
Dave

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

File find: open viewer does not jump to line?

[David Sterba]

Hi,

[in mc 4.6.0]
opening editor/viewer in file find dialog does not go to the line.
I think, it worked in the past versions.

bye
Dave
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: hotlist: now with edit

[David Sterba]

Hi,

> Please report your experience. Please also share your ideas on
> these issues:
>
> 1. Hotkeys of entries may obscure the hotkeys of the buttons in
> the bottom of the list. Do we need to: block conflicting
> hotkeys from being entered, or warn the user, or disable button
> hotkeys?
As for me, I'd rather have the hotkeys assigned to the entries.
Maybe, the buttons should be reorganized so the most used would
be easy reachable when jumping form list to buttonset with tab,
e.g. 'New Entry' should be first.

> 2. Do we need to check for duplicate hotkeys in one group?
Hm, if we allow more entries assingned to one hotkey, then pressing
the key should "cycle-jump" through entries.

bye
Dave
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

re: hotkeys in hotlist patch submitted

[David Sterba]

hi,

it works for me too :-)

i find the hotkeys very useful. in current implementation
i "simulate" hotkeys by placing the most visited dirs
to top and bottom (or near to), so this is about 4-6 dirs.

the "Up" button does not work (nothing happens).
i came across this just randomly, i cant remember i have used it,

i had one problem with compilation:
in hotlist.c:413 there is a declaration of variable inside
a block but after statments (C++ allowes this).

bye
dave
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] xterm titlebar

[David Sterba]

Hi,


> +fprintf (stdout, "\33]0;mc - %s\7", d);
How about writing into /dev/tty ?

Anyway, good feature :-)

bye
Dave
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

MC Hints: F13 == Shift-F3 ?

[David Sterba]

Hi,


in hint files (all languages) is a mistake:
Hint: F13 (or Shift-F3) invokes the viewer in raw mode.

There should be Shift-F1.
Patch attached.


bye
Dave
--- lib/mc.hint.cs
+++ lib/mc.hint.cs
@@ -29,7 +29,7 @@
 Poznámka: Pøíkazy shellu nefungují, pokud nepracujete na lokální systému souborù.
 Tip: Smazaný text obnovíte C-y.
 Tip: Pokud nìkteré klávesy nefunfují, pou¾ijte menu Nastavení/uèení kláves.
-Tip: F13 (nebo Shift-F3) vyvolá prohlí¾ení bez zpracování obsahu souboru.
+Tip: F13 (nebo Shift-F1) vyvolá prohlí¾ení bez zpracování obsahu souboru.
 Tip: Pokud v xtermu nepracují klávesy, zkuste soubory xterm.ad, .ti a .tcap.
 Tip: Editor pro klávesu F4 urèíte pomocí promìnné prostøedí EDITOR.
 Tip: Externí prohlí¾eè urèíte promìnnou PAGER.
--- lib/mc.hint.es
+++ lib/mc.hint.es
@@ -32,7 +32,7 @@
 Ayudita: Con C-y puede recuperar texto eliminado.
 Ayudita: ¿Alguna tecla rebelde? Puede educarla con "Redefinir teclas".
 Ayudita: Para ver la salida de un comando por el visor M-!
-Ayudita: F13 (o Mayúsculas-F3) invoca el visor en modo primitivo, sin formatos.
+Ayudita: F13 (o Mayúsculas-F1) invoca el visor en modo primitivo, sin formatos.
 Ayudita: ¿Problemas de teclas en terminales X? Use xterm.ad, .ti y .tcap
 Ayudita: F4 puede usar cualquier editor que indiquemos en la variable EDITOR.
 Ayudita: Se puede usar un visor externo indicado en la variable PAGER.
--- lib/mc.hint.hu
+++ lib/mc.hint.hu
@@ -31,7 +31,7 @@
 Tipp: A pufferben levõ (például "C-k"-val oda tett) szöveg visszahozása: C-y
 Tipp: Ha nem mûködnek bizonyos billentyûk: "Beállítások/Billentyûk megtanulása".
 Tipp: Egy parancs kimenetének megjelenítése a fájlmegjelenítõben: M-!
-Tipp: Az F13 (vagy Shift-F3) a fájlmegjelenítõt "nyers" módban indítja el.
+Tipp: Az F13 (vagy Shift-F1) a fájlmegjelenítõt "nyers" módban indítja el.
 Tipp: X-terminálon nem mûködõ billentyûk? Lásd "xterm.ad", ".ti", ".tcap" fájlok.
 Tipp: Az F4-re használandó szerkesztõt az EDITOR shell-változóval lehet megadni.
 Tipp: A külsõ fájlmegjelenítõt a PAGER shell-változóval lehet megadni.
--- lib/mc.hint.it
+++ lib/mc.hint.it
@@ -31,7 +31,7 @@
 Dritta: riesuma il testo nell'editor integrato con C-u.
 Dritta: non ti funzionano alcuni tasti? Guarda in Opzioni/Impara tasti.
 Dritta: per vedere il risultato di un comando nel visualizzatore, usa M-!
-Dritta: F13 (o Shift-F3) invoca il visualizzatore in modo 'raw'.
+Dritta: F13 (o Shift-F1) invoca il visualizzatore in modo 'raw'.
 Dritta: tasti non funzionanti in xterms? Usa i file xterm.ad, .ti e .tcap di mc.
 Dritta: puoi specificare l'editor per F4 con la variabile shell EDITOR.
 Dritta: puoi specificare il visualizzatore esterno con la variabile shell PAGER.
--- lib/mc.hint.nl
+++ lib/mc.hint.nl
@@ -31,7 +31,7 @@
 Hint: Laat tekst herleven met C-y.
 Hint: Werken sommige toetsen niet? Kijk naar Opties/Leer toetsen.
 Hint: Om naar de uitvoer van een commando in d viewer te kijken, drukke men M-!
-Hint: F13 (of Shift-F3) roept de viewer aan in ruwe modus.
+Hint: F13 (of Shift-F1) roept de viewer aan in ruwe modus.
 Hint: Werken toetsen in xterms niet? Gebruik onze xterm.ad, .ti en .tcap!
 Hint: Je kunt een editor onder F4 specificeren met de shell variabele EDITOR.
 Hint: Je kunt een externe viewer specificeren met de shell variabele PAGER.
--- lib/mc.hint
+++ lib/mc.hint
@@ -30,7 +30,7 @@
 Hint: Bring text back from the dead with C-y.
 Hint: Are some of your keys not working? Look at Options/Learn keys.
 Hint: To look at the output of a command in the viewer, use M-!
-Hint: F13 (or Shift-F1) invokes the viewer in raw mode.
+Hint: F13 (or Shift-F3) invokes the viewer in raw mode.
 Hint: Keys not working in xterms? Use our xterm.ad, .ti and .tcap files.
 Hint: You may specify the editor for F4 with the shell variable EDITOR.
 Hint: You may specify the external viewer with the shell variable PAGER.
--- lib/mc.hint.pl
+++ lib/mc.hint.pl
@@ -31,7 +31,7 @@
 Porada: Przywróæ skasowany tekst za pomoc± C-y.
 Porada: Niektóre klawisze nie dzia³aj±? Patrz menu Opcje|Definiuj klawisze...
 Porada: Aby obejrzeæ wyj¶cie polecenia w przegl±darce u¿yj M-!
-Porada: F13 (lub Shift-F3) wywo³uje przegl±darkê w trybie surowym.
+Porada: F13 (lub Shift-F1) wywo³uje przegl±darkê w trybie surowym.
 Porada: Nie dzia³aj± klawisze w xterm? U¿yj naszych plików xterm.ad, .ti i .tcap
 Porada: Mo¿esz okre¶liæ edytor pod F4 przez zmienn± pow³oki EDITOR.
 Porada: Mo¿esz okre¶liæ zewnêtrzn± przegl±darkê przez zmienn± pow³oki PAGER.
--- lib/mc.hint.ru
+++ lib/mc.hint.ru
@@ -30,7 +30,7 @@
 óÏ×ÅÔ: õÄÁÌÅÎÎÙÊ ÔÅËÓÔ ÍÏÖÎÏ ×ÅÒÎÕÔØ Ó ÐÏÍÏÝØÀ C-y.
 óÏ×ÅÔ: îÅËÏÔÏÒÙÅ ËÌÁ×ÉÛÉ ÎÅ ÒÁÂÏÔÁÀÔ? úÁÊÄÉÔÅ × îÁÓÔÒÏÊËÉ/òÁÓÐÏÚÎÁ×ÁÎÉÅ ËÌÁ×ÉÛ.
 óÏ×ÅÔ: äÌÑ ÐÏÌÕÞÅÎÉÑ ×Ù×ÏÄÁ ËÏÍÁÎÄÙ × ÏËÎÅ ÐÒÏÓÍÏÔÒÁ, ÎÁÂÅÒÉÔÅ M-!
-óÏ×ÅÔ: F13 (ÉÌÉ Shift-F3) ×ÙÚÙ×ÁÀÔ ÐÒÏÓÍÏÔÒÝÉË × ÒÅÖÉÍÅ ÎÅÏÂÒÁÂÏÔÁÎÎÙÈ ÄÁÎÎÙÈ.
+óÏ×ÅÔ: F13 (ÉÌÉ Shift-F1) ×ÙÚÙ×ÁÀÔ ÐÒÏÓÍÏÔÒÝÉË × ÒÅÖÉÍÅ ÎÅÏÂÒÁÂÏÔÁÎÎÙÈ ÄÁÎÎÙÈ.
 óÏ×ÅÔ: îÅ ÒÁÂÏÔÁÀÔ ËÌÁ×ÉÛÉ × xterm? ðÏ

Re: [PATCH] Find file non-recursively

[David Sterba]

Hi,

>   MC finds files in specified directory and in it's all subdirecories.
> I made a small patch that allows to choose how the files find: recursively
> (as usually) or not (new behaviour). The new checkbox "find recursively" is added in 
>"File find" dialog. The only find.c file is changed.
> 
>   Some times I need this feature, and I hope it will be useful for others.

I would appreciate to be able to set more find options, not only 
recursive/non-recursive. For example:
- regex filename matching
- minimum/maximum recursion depth
- date/time 
- (xdev) no cross device search

Maybe other (man find :-).
I think, these are used more frequently than others.
Maybe I try to implement them.


bye,
Dave

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re[4]: problem with nls on AIX

[David Sterba]

Hi,


> I ran autogen.sh on another PC (Linux) and copied configure to AIX.
> ./configure --disable-nls ends with
> 
> config.status: creating intl/Makefile
> config.status: error: cannot find input file: intl/Makefile.in
Just for compilation purpose ... supply a Makefile.in
with empty targets (all,install,check).

Dave

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH proposal] FISH: don't let ssh write its ouput tothecontrolling tty

[David Sterba]

Hi,

> > patch works fine for logging through username & password, but
> > not for rsa keys. MC successfully logs to the remote host but
> > does not know about it.
> 
> Does not know about what ? If it doesn't know the host a dialog box should
> appear and ask the user to confirm its identity. Are you saying that this box
> doesn't pop up ?
Hm, I am trying to say, that MC freezes (I should have been more precise, 
sorry). The remote host is up and running.
The spawned ssh proces apears in 'ps' list. Killing the ssh 
returns MC into normal operation (the shell link is not established).


bye
/dave

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH proposal] FISH: don't let ssh write its ouput tothecontrolling tty

[David Sterba]

Hi,

patch works fine for logging through username & password, but
not for rsa keys. MC successfully logs to the remote host but
does not know about it. I think, that this option is not
taken into account in the patch.

Adding hostkey works fine.

Tested on Linux.


Why are the pty_open_{slave,master} funcs moved from subshell.c
to utilunix.c


bye
/dave

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel