Re: sort char on the name line
mark said: (by the date of Tue, 30 Sep 2014 18:25:32 +1300) I get very upset each time my cursor hits the top name line and the sort order changes especially when I am using the mouse to pick up the top line of text and the cursor overshoots. funny, I find this feature useful. Maybe you could disable it by grepping source code for sort and trying to find relevant line to comment out. -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: technical question about branches
Janek Kozicki said: (by the date of Fri, 28 May 2010 16:33:33 +0200) Janek Kozicki said: (by the date of Sat, 22 May 2010 10:10:10 +0200) Andrew Borodin said: (by the date of Sat, 22 May 2010 10:08:02 +0400) If you will have your repo on github, we can review your branches, fetch them into main mc repo and merge to master. ok, I'll use github. Thanks for pointers. my apologies I can't today. Will try next week. heh, my sense of 'connection with you(?)' forces me to keep you informed about my lack of progress. I also couldn't do today. You can either go with the patches that I already submitted, or wait.. I dunno - more weeks? I guess, that sooner or later I will need scratch that itch again. Working in mc is for pleasure, not because it has to be done. So I wait when pleasure will coincide with enough time condition. best regards -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: technical question about branches
Janek Kozicki said: (by the date of Sat, 22 May 2010 10:10:10 +0200) Andrew Borodin said: (by the date of Sat, 22 May 2010 10:08:02 +0400) If you will have your repo on github, we can review your branches, fetch them into main mc repo and merge to master. ok, I'll use github. Thanks for pointers. my apologies I can't today. Will try next week. -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: technical question about branches
Andrew Borodin said: (by the date of Sat, 22 May 2010 10:08:02 +0400) If you will have your repo on github, we can review your branches, fetch them into main mc repo and merge to master. ok, I'll use github. Thanks for pointers. -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: getting mc GIT HEAD version + debian.
too much talking. It works: mkdir git-HEAD cd git-HEAD git clone git://midnight-commander.org/git/mc.git cd mc svn co svn://svn.debian.org/svn/pkg-mc/trunk/debian ./autogen.sh fakeroot debian/rules binary now I have git-HEAD here. I'm reading a quick git tutorial. I hope that soon you will be able to pull my branches with tree-view patches :) -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
getting real
Tell me if my idea of how to work here is correct: - create a trac ticket for each thing that I plan to do with tree view (I have several separate ideas). - create a branch for those tickets. - once some ticket is done: push it - then you can pull and test it. correct? My separate ideas. Should I use separate tickets for each? 1) use skins for display of ─ / ▶ / ▼ : #1518 2) display whether the subdirectories ▶ are hidden (dot-files) or not (it can be annoying if you try to unfold, and nothing unfolds, because the subdirectories are hidden). 3) Second press of Enter on a collapsed directory, which contains only hidden subdirectories, should unfold and show those hidden directories. 4) speed up detection whether a directory has subdirectories, by caching this information in the tree_entry struct: (mtime timestamp + yes|no) 5) display symlinked directories 6) use Enter to unfold/collapse a directory : #2202, #1517 7) Improve F3 Forget-this option by adding another Forget-everything-except-this That's the stuff that I am thinking about. Ideally each of them should be a separate (smaller) patch, but they will have to be applied in order (they depend on each other). Finely graining this should make it easier for you to review each patch. how do you think? Should I make 5 new tickets? PS: I'm browsing 'quick git tutorial' to find out, how to commit locally my current changes, and how to push them under some useful name for you, like 1518_skins_tree_view -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: getting real with tree view
Janek Kozicki said: (by the date of Fri, 21 May 2010 21:11:12 +0200) Tell me if my idea of how to work here is correct: - create a trac ticket for each thing that I plan to do with tree view (I have several separate ideas). - create a branch for those tickets. - once some ticket is done: push it - then you can pull and test it. correct? I allowed myself to make the tickets: 1) use skins for display of ─ / ▶ / ▼ : #1518 #1518 2) display whether the subdirectories ▶ are hidden (dot-files) or not (it can be annoying if you try to unfold, and nothing unfolds, because the subdirectories are hidden). #2207 3) Second press of Enter on a collapsed directory, which contains only hidden subdirectories, should unfold and show those hidden directories. #2208 4) speed up detection whether a directory has subdirectories, by caching this information in the tree_entry struct: (mtime timestamp + yes|no) #2209 5) display symlinked directories #2210 6) use Enter to unfold/collapse a directory : #2202, #1517 #2202, #1517 7) Improve F3 Forget-this option by adding another Forget-everything-except-this #2211 That's the stuff that I am thinking about. Ideally each of them should be a separate (smaller) patch, but they will have to be applied in order (they depend on each other). Finely graining this should make it easier for you to review each patch. how do you think? Should I make 5 new tickets? PS: I'm browsing 'quick git tutorial' to find out, how to commit locally my current changes, and how to push them under some useful name for you, like 1518_skins_tree_view -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
technical question about branches
ok, so I have cloned mc repository: git clone git://midnight-commander.org/git/mc.git now I want to work on ticket #1517 git checkout -b 1517_collapse_a_treeview_dir_with_enter I changed some file: git commit -a -m 'I am testing how git commit push works' Now I want to make it available for you. How? git push origin 1517_collapse_a_treeview_dir_with_enter fatal: The remote end hung up unexpectedly Do I need to make my own repo (github? gitorious?) so that you can fetch from it? Do I have an access to origin, because I made a trac account, and I'm simply unaware of that? Or should I `git format-patch master 1517_collapse_a_treeview_dir_with_enter` and attach it to tickets? something else? -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: how does skin recognize that UTF-8 is available?
Andrew Borodin said: (by the date of Thu, 20 May 2010 08:53:32 +0400) MC uses a default skin or a skin set in command line (-S option) or a skin set in the ~/.mc/ini file (skin key). You can try use another skin to view non-default sotring symbols. A skin selection dialog is missing from the Menu, or I am blind? Like Options-Skin. -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: tree view, more tweaking - switching to mc HEAD version.
Yury V. Zaytsev said: (by the date of Tue, 18 May 2010 17:11:14 +0200) On Tue, 2010-05-18 at 16:56 +0200, Janek Kozicki wrote: During the course I have learned a bit of how that tree-view code works, and I already have an idea how to optimize the current patch a little bit more. Depending on your patience you can either apply this patch or wait for the next one. That depends on how much time you would want to invest into this venture. Either you come up with a patch, attach it to the Trac ticket, we create a branch, review it and merge into the current master tree or you can checkout the latest source from git and then push your branch to github or somewhere else so that we can pull from you. I'm unfamiliar with git - never used it, except for mc. I used svn and bzr, but not git. If you care to tell me how to commit my patches to your repository I could do that. I have no idea how to set a git hub, so that you could pull from it. And my IP address is behind a firewall, so you couldn't reach my PC anyway. I am fine with sending patches, OTOH I'm afraid that *if* I continue to improve a tree-view code I might want to send more patches, so write access to repo might be useful. OTOH My limited time is conflicting with this obviously and I'm really unable to decide how dedicated to it I can be. But just for now, I am trying to update my branch as you suggested, to use the latest version, so I do: git reset --hard git checkout master git pull like this: ja...@atak:~/usr/deb-src/mc/mc-ORIGINAL-COPY$ git reset --hard HEAD is now at 70c0c3d Merge branch '2157_ncurses_fill_region' ja...@atak:~/usr/deb-src/mc/mc-ORIGINAL-COPY$ git checkout master Already on 'master' ja...@atak:~/usr/deb-src/mc/mc-ORIGINAL-COPY$ git pull Already up-to-date. Does it mean that I am at release 5.0 ? I see that version.h says: 4.7.2-48-g70c0c3d, but maybe it's filled in during compilation, and I couldn't compile the HEAD, read on. I am stuck with debian packages. I mean - I don't want to run 'mc' in any different way than by ending the compilation process by making a .deb package and installing it. I mean - everytime when I modify a source file, I compile to generate a .deb and install it, just to run mc. This is maybe longer, but it's the safest/laziest way for me. So, inside that directory with git branch have a /debian/ subdirectory so I just did: cd debian svn up svn info like this: ja...@atak:~/usr/deb-src/mc/mc-ORIGINAL-COPY$ cd debian ja...@atak:~/usr/deb-src/mc/mc-ORIGINAL-COPY/debian$ svn up At revision 408. ja...@atak:~/usr/deb-src/mc/mc-ORIGINAL-COPY/debian$ svn info Path: . URL: svn://svn.debian.org/svn/pkg-mc/trunk/debian Repository Root: svn://svn.debian.org/svn/pkg-mc Repository UUID: 1da7b59f-b76e-4e7a-8c78-615837a07e4c Revision: 408 Node Kind: directory Schedule: normal Last Changed Author: zaytsev-guest Last Changed Rev: 408 Last Changed Date: 2010-05-18 10:52:59 +0200 (wto, 18 maj 2010) So, with the latest version of debian build system in place, I want to compile, so I proceed in following manner: cd .. fakeroot debian/rules binary Which fails with error: config.status: error: cannot find input file: `vfs/extfs/a.in' And now, I am unable to make a debian package. What's wrong? I could try to download a fresh checkout of git repository, and put in there a fresh checkout of debian built system from repository. But I just forgot how I did that in the first place, and would need to look it up. So it was easier to update the current one :) So while HEAD isn't compiling, I'll continue today to tweak my current version of tree view with older mc checkout. In fact, rebasing to the latest master is recommended as we are now applying auto-indent to every file we touch so that hopefully the crazy ad hoc indentation will finally go away without causing too much conflicts. Which files did you already auto indent? Currently it's PITA, because I am using TAB character which is 8 chars long. But whole mc code seems to be tabulated at 4 space characters. Are you drifting away from this, or towards this? I have no preference here (forget the TAB flame war), I'm just asking for vim flags, so that vim will take care of this for me :) If you make a patch on top of an source file that has been subsequently auto-indented it will become essentially un-applicable for us. of course :) P.S. We all should probably be doing something else... :-) hell yeah :) -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
how does skin recognize that UTF-8 is available?
I wanted to check how to use ▶ / ▼ for (un)folding a directory in tree view. If UTF-8 is available then I'd like to use ▶ / ▼. Andrew recommended using skin engine for that. So I suppose that I would just call for an up-arrow and get either a UTF8 on or a ASCII one. But now I'm troubled. I switched to UTF8 recently and mc is still using ' and , to show the sorting direction. Instead of ↓ and ↑. A quick grep shows that the character is fixed to a skin, and not to UTF8 availability: $ grep sort-sign-up ./* -R ./misc/skins/darkfar.ini:sort-sign-up=↑ ./misc/skins/featured.ini:sort-sign-up = ↑ ./misc/skins/default.ini:sort-sign-up = ' ./misc/skins/double-lines.ini:sort-sign-up = ' Maybe 'mc' should detect if UTF8 is available and either use default-ASCII.ini skin or default-UTF8.ini skin. But there is currently just one: the ASCII one default.ini. Or I'm just not getting it, and it just works. Then - how? -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: tree view, more tweaking
Yury V. Zaytsev said: (by the date of Mon, 17 May 2010 14:24:08 +0200) On Fri, 2010-05-14 at 18:05 +0200, Janek Kozicki wrote: Hi, I was working to improve the tree view feature, please have a look at my video: http://janek.kozicki.pl/nn/mc-tree-view.mpg As a tangential note, what bothers me is the gray background. I think regular blue color scheme would be nicer. yes, it is bothering me too. I think I've seen somewhere the code that sets the color, I'll try to change it to blue background. -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: tree view, more tweaking
Andrew Borodin said: (by the date of Sat, 15 May 2010 09:35:22 +0400) On Fri, 14 May 2010 18:05:41 +0200 Janek Kozicki wrote: I was working to improve the tree view feature Thanks! It seems that Tree widget is almost unused by MC users therefore it exists as is without any developing and improving. Very nice! Thank you for your positive feedback :) Sorry for late response, typically I have very little time during the week. In fact that day when I produced that patch, I should have been doing something else, but that tree view in mc was bothering me so much, that I couldn't focus on my own work without fixing it ;) During the course I have learned a bit of how that tree-view code works, and I already have an idea how to optimize the current patch a little bit more. Depending on your patience you can either apply this patch or wait for the next one. Also I'm thinking about adding symlinked directories to the display, but I'm not sure if I'll achieve that. That is because in my dirtree I am extensively using symlinked directories. I would be extremely happy however if you would consider applying this patch, after your review (and some cleaning perhaps). Would you create a ticket at the www.midniht-commander.org? Thanks. I have just registered on the website. I'll try to investigate later how this trac system works, I never used it :) -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: tree view, more tweaking
Janek Kozicki said: (by the date of Tue, 18 May 2010 16:56:31 +0200) Would you create a ticket at the www.midniht-commander.org? Thanks. I have just registered on the website. I'll try to investigate later how this trac system works, I never used it :) ok, trac ticket #2202 the optimizations I had in mind were about calling how_many_folded = tree_store_remove_entry (tree-selected_ptr-name,FALSE,FALSE); by using the same method that I later applied in does_it_have_subdirectories(..) by this method such call can be made a bit faster. But it's not for today. So I submitted the current patch. -- Janek Kozicki http://janek.kozicki.pl/ | ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
tree view, more tweaking
Hi,
I was working to improve the tree view feature, please have a look at
my video:
http://janek.kozicki.pl/nn/mc-tree-view.mpg
It is now quite intuitive.
Problem is that my knowledge of mc code is weak and I have
implemented it, most likely, in a very inefficient way. I would be
extremely happy however if you would consider applying this patch,
after your review (and some cleaning perhaps).
I hope that this patch will apply to HEAD version, because I was
working on 4.7.0.1-42-g901def1
best regards
--
Janek Kozicki http://janek.kozicki.pl/ |
diff -ur mc-ORIGINAL/src/tree.c TEN-mc-iproved-tree/src/tree.c
--- mc-ORIGINAL/src/tree.c 2010-01-10 15:19:51.0 +0100
+++ TEN-mc-iproved-tree/src/tree.c 2010-05-14 17:45:11.0 +0200
@@ -155,7 +155,7 @@
tree_remove_entry (WTree *tree, char *name)
{
(void) tree;
-tree_store_remove_entry (name);
+tree_store_remove_entry (name,TRUE,TRUE);
}
static void
@@ -213,6 +213,47 @@
}
}
+static gboolean
+does_it_have_subdirectories (tree_entry *current)
+{
+DIR *dirp;
+struct dirent *dp;
+struct stat buf;
+const char *dir;
+dir=current-name;
+
+if(current-next current-next-sublevel current-sublevel)
+ return TRUE;
+
+/* scanning current dir for subdirectories */
+dirp = mc_opendir(dir);
+if (dirp) {
+ for (dp = mc_readdir(dirp); dp; dp = mc_readdir(dirp)) {
+ char *full_name;
+
+ if (dp-d_name[0] == '.') {
+ if (dp-d_name[1] == 0
+ || (dp-d_name[1] == '.' dp-d_name[2] == 0))
+ continue;
+ }
+
+ full_name = concat_dir_and_file(dir, dp-d_name);
+ if (mc_lstat(full_name, buf) != -1) {
+ if (S_ISDIR(buf.st_mode))
+ {
+ g_free(full_name);
+ mc_closedir(dirp);
+ return TRUE; /* return on first found */
+ }
+ }
+ g_free(full_name);
+ }
+ mc_closedir(dirp);
+}
+
+return FALSE;
+}
+
static void
show_tree (WTree *tree)
{
@@ -221,6 +262,8 @@
int i, j, topsublevel;
int x, y;
int tree_lines, tree_cols;
+gboolean has_subdirectories;
+has_subdirectories=FALSE;
/* Initialize */
x = y = 0;
@@ -324,7 +367,24 @@
tty_setcolor (SELECTED_COLOR);
}
+
/* Show sub-name */
+ has_subdirectories = does_it_have_subdirectories(current);
+
+ tty_set_alt_charset (TRUE);
+ tty_print_char (ACS_HLINE);
+ tty_set_alt_charset (FALSE);
+ if(has_subdirectories)
+ {
+ tty_print_char ('+');
+ }
+ else
+ {
+ tty_set_alt_charset (TRUE);
+ tty_print_char (ACS_HLINE);
+ tty_set_alt_charset (FALSE);
+ }
+
tty_print_char (' ');
tty_print_string (str_fit_to_term (current-subname,
tree_cols - 2 - 4 - 3 * j, J_LEFT_FIT));
@@ -494,28 +554,137 @@
}
static void
-tree_chdir_sel (WTree *tree)
+tree_chdir_sel (WTree *tree, gboolean is_this_only_an_xtree_refresh__NOT_Pressing_Enter_key)
{
+int how_many_folded;
+how_many_folded = -1;
if (!tree-is_panel)
- return;
+return;
+/* Folding or unfolding */
+if( xtree_mode
+ /* this is xtree_mode and Enter was pressed */
+ ! is_this_only_an_xtree_refresh__NOT_Pressing_Enter_key) /* in xtree_mode pressing Enter means folding a tree */
+ /* so I want to either fold or unflod */
+{
+ /* I don't know whether to fold or unfold, so let's fold first, to see many of them were there: */
+if (tree-selected_ptr)
+how_many_folded = tree_store_remove_entry (tree-selected_ptr-name,FALSE,TRUE);
+
+ if(how_many_folded == 0) /* aha - there was nothing to fold, so we want to unfold it */
+ {
+change_panel ();
+
+if (do_cd (tree-selected_ptr-name, cd_exact))
+select_item (current_panel);
+else
+message (D_ERROR, MSG_ERROR, _( Cannot chdir to \%s\ \n %s ),
+ tree-selected_ptr-name, unix_error_string (errno));
-change_panel ();
+change_panel ();
+ }
+ else
+ /* aha, there was something and we have folded it, this is OK. We wanted to do this anyway*/
+ {
+ }
+show_tree (tree);
+}
+else if ( xtree_mode
+ /* this is xtree_mode and Enter was NOT pressed */
+ is_this_only_an_xtree_refresh__NOT_Pressing_Enter_key)
+ /* so I want to refresh without unfolding */
+{
+
+
+ /* I don't want to fold or unfold. I want to keep it as it was. But, unfortunately refreshing means unfolding too.
+ So
+ First: I am checking whether it was folded or unfolded, by actually *NOT* FOLDING IT: really_remove=FALSE */
+if (tree-selected_ptr)
+how_many_folded = tree_store_remove_entry (tree-selected_ptr-name,FALSE,FALSE);
+
+ /* Second: I am refreshing the second panel */
+change_panel ();
+
+if (do_cd (tree-selected_ptr-name, cd_exact))
+select_item (current_panel);
+else
+message (D_ERROR, MSG_ERROR, _( Cannot chdir to \%s\ \n %s ),
+ tree
xtree-mode / dynamic static - tree view patch
Hi, Today I was using Tree view a little bit, because directory structure in my project got too large. And I had to browse it somehow. And so, I found out that the Dynamic / Static toggle is totally useless for me. But the xtree-mode toggle was extremely useful. I would remove dynamic/static completely and put xtree-mode toggle there, but this could offend someone, so instead I added an option to toggle xtree-mode. So now, the F4 toggles two boolean variables. 00 → 01 → 10 → 11 → 00 see attached patch. In fact, at first I wanted to use the empty F7 label for that, but I just couldn't get it to work. Despite my best efforts the function to toggle the boolean, linked to F7 was never called. If you are curious what I have done here, see the second, “WTF” patch. best regards -- Janek Kozicki http://janek.kozicki.pl/ | Only in TEN-mc-toggle__xtree-mode: Makefile Only in TEN-mc-toggle__xtree-mode/config: config.guess.cdbs-orig Only in TEN-mc-toggle__xtree-mode/config: config.sub.cdbs-orig Only in TEN-mc-toggle__xtree-mode: config.h Only in TEN-mc-toggle__xtree-mode: config.log Only in TEN-mc-toggle__xtree-mode: config.status Only in TEN-mc-toggle__xtree-mode/contrib: Makefile Only in TEN-mc-toggle__xtree-mode/contrib/dist: Makefile Only in TEN-mc-toggle__xtree-mode/contrib/dist/debian: Makefile Only in TEN-mc-toggle__xtree-mode/contrib/dist/gentoo: Makefile Only in TEN-mc-toggle__xtree-mode/contrib/dist: mc.qpg Only in TEN-mc-toggle__xtree-mode/contrib/dist: pkginfo Only in TEN-mc-toggle__xtree-mode/contrib/dist: prototype Only in TEN-mc-toggle__xtree-mode/contrib/dist/redhat: Makefile Only in TEN-mc-toggle__xtree-mode/contrib/dist/redhat: mc.spec Only in TEN-mc-toggle__xtree-mode/contrib: mc-wrapper.csh Only in TEN-mc-toggle__xtree-mode/contrib: mc-wrapper.sh Only in TEN-mc-toggle__xtree-mode/contrib: mc.csh Only in TEN-mc-toggle__xtree-mode/contrib: mc.sh Only in TEN-mc-toggle__xtree-mode/debian: files Only in TEN-mc-toggle__xtree-mode/debian: mc Only in TEN-mc-toggle__xtree-mode/debian: mc-dbg Only in TEN-mc-toggle__xtree-mode/debian: mc-dbg.debhelper.log Only in TEN-mc-toggle__xtree-mode/debian: mc-dbg.substvars Only in TEN-mc-toggle__xtree-mode/debian: mc.debhelper.log Only in TEN-mc-toggle__xtree-mode/debian: mc.postinst.debhelper Only in TEN-mc-toggle__xtree-mode/debian: mc.postrm.debhelper Only in TEN-mc-toggle__xtree-mode/debian: mc.substvars Only in TEN-mc-toggle__xtree-mode/debian: stamp-autotools Only in TEN-mc-toggle__xtree-mode/debian: stamp-autotools-files Only in TEN-mc-toggle__xtree-mode/debian: stamp-makefile-build Only in TEN-mc-toggle__xtree-mode/debian: stamp-makefile-install Only in TEN-mc-toggle__xtree-mode/debian: tmp Only in TEN-mc-toggle__xtree-mode/doc: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hints: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hlp: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hlp/es: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hlp/es: mc.hlp.es Only in TEN-mc-toggle__xtree-mode/doc/hlp/hu: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hlp/hu: mc.hlp.hu Only in TEN-mc-toggle__xtree-mode/doc/hlp/it: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hlp/it: mc.hlp.it Only in TEN-mc-toggle__xtree-mode/doc/hlp: mc.hlp Only in TEN-mc-toggle__xtree-mode/doc/hlp/pl: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hlp/pl: mc.hlp.pl Only in TEN-mc-toggle__xtree-mode/doc/hlp/ru: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hlp/ru: mc.hlp.ru Only in TEN-mc-toggle__xtree-mode/doc/hlp/sr: Makefile Only in TEN-mc-toggle__xtree-mode/doc/hlp/sr: mc.hlp.sr Only in TEN-mc-toggle__xtree-mode/doc/man: Makefile Only in TEN-mc-toggle__xtree-mode/doc/man/es: Makefile Only in TEN-mc-toggle__xtree-mode/doc/man/es: mc.1 Only in TEN-mc-toggle__xtree-mode/doc/man/hu: Makefile Only in TEN-mc-toggle__xtree-mode/doc/man/hu: mc.1 Only in TEN-mc-toggle__xtree-mode/doc/man/it: Makefile Only in TEN-mc-toggle__xtree-mode/doc/man/it: mc.1 Only in TEN-mc-toggle__xtree-mode/doc/man: mc.1 Only in TEN-mc-toggle__xtree-mode/doc/man: mcedit.1 Only in TEN-mc-toggle__xtree-mode/doc/man: mcserv.8 Only in TEN-mc-toggle__xtree-mode/doc/man: mcview.1 Only in TEN-mc-toggle__xtree-mode/doc/man/pl: Makefile Only in TEN-mc-toggle__xtree-mode/doc/man/pl: mc.1 Only in TEN-mc-toggle__xtree-mode/doc/man/ru: Makefile Only in TEN-mc-toggle__xtree-mode/doc/man/ru: mc.1 Only in TEN-mc-toggle__xtree-mode/doc/man/sr: Makefile Only in TEN-mc-toggle__xtree-mode/doc/man/sr: mc.1 Only in TEN-mc-toggle__xtree-mode/doc/man/sr: mcserv.8 Only in TEN-mc-toggle__xtree-mode/edit: Makefile Only in TEN-mc-toggle__xtree-mode/edit: bookmark.o Only in TEN-mc-toggle__xtree-mode/edit: choosesyntax.o Only in TEN-mc-toggle__xtree-mode/edit: edit.o Only in TEN-mc-toggle__xtree-mode/edit: editcmd.o Only in TEN-mc-toggle__xtree-mode/edit: editcmd_dialogs.o Only in TEN-mc-toggle__xtree-mode/edit: editdraw.o Only in TEN-mc-toggle__xtree-mode/edit: editkeys.o Only in TEN-mc-toggle__xtree-mode/edit
builtin editor, color background bug.
Compare two screenshots. One with curtsor position at 71'th character, another at 72'th position. The background suddenly becomes black. -- Janek Kozicki | attachment: scr_2881.pngattachment: scr_2882.png___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: quick-view line-wrap bug.
Andrew Borodin said: (by the date of Sun, 10 Jan 2010 09:23:18 +0300) The 1918_quick_view_corruption branch already merged to the master one. It works like a charm. And the bug is fixed! Thank you very much. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: quick-view line-wrap bug.
Andrew Borodin said: (by the date of Thu, 07 Jan 2010 09:53:59 +0300) Thanks for the bugreport. I've created a ticket: http://www.midnight-commander.org/ticket/1944 how can I download this? Forgive me my git ignorance. I tried (again) to http://www.midnight-commander.org/changeset/8c84095ae1afc1f60eb1cb73e318cf315ac77a9c Download in other formats: Unified Diff You will probably tell me to switch branch. But I already switched, because I need to use this patch: git checkout -b 1918_quick_view_corruption origin/1918_quick_view_corruption How can I use both patches at the same time? -- Janek Kozicki ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: New layout question.
Oswald Buddenhagen said: (by the date of Tue, 5 Jan 2010 15:47:15 +0100) - assuming mouse interaction is removed, just displaying the current state is relatively useless as well, as one can easily see the effects in the first place. sorting by columns, just by clicking on the column is faster than going to menu and selecting the sort method. It's a one click vs. 5 or 6 keystrokes. Same about sorting direction. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: quick view
Andrew Borodin said: (by the date of Sun, 03 Jan 2010 18:08:34 +0300) # go to website http://www.midnight-commander.org/changeset/121875c21965f6654307c8979287a89e8fddb22f You must compile the entire 1918_quick_view_corruption branch. After git clone, get the branch: git checkout -b 1918_quick_view_corruption origin/1918_quick_view_corruption wow, it works! Great and thanks a lot! -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Fwd: Re: memory leak with quick view]
Yury V. Zaytsev said: (by the date of Sun, 03 Jan 2010 13:46:56 +0100) Ticket #1918 (Quick view corruption) created by zyv http://www.midnight-commander.org/ticket/1918 There's a patch proposed by Andrew, could you please confirm that it fixes the issue for you? unfortunately not. Here's what I have done right now, so you can confirm that I indeed have used this patch: mkdir ZZ ; cd ZZ svn co svn://svn.debian.org/svn/pkg-mc/trunk git clone git://midnight-commander.org/git/mc.git mv trunk/debian mc cd mc # go to website http://www.midnight-commander.org/changeset/121875c21965f6654307c8979287a89e8fddb22f # click on bottom of that page Download in other formats: Unified Diff patch -p0 changeset_r121875c21965f6654307c8979287a89e8fddb22f.diff # patch got applied without errors fakeroot debian/rules binary sudo dpkg -i ../mc_4.7.0.1-1_amd64.deb That's the version from mc -V: ja...@atak:~$ mc -V GNU Midnight Commander 4.7.0.1-17-g3900dfa Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With internationalization support With multiple codepages support Data types: char 8 int 32 long 64 void * 64 off_t 64 ecs_char 8 Also, since in patch description you assumed that it goes wrong when used without utf8, I checked this - and I have found a way to workaround this patch. I only need to: LANG=POSIX Then it is not messed up, and looks like on attached screenshot. Ticket #1919 (Directories are not highlighted on default install on Debian) created by zyv http://www.midnight-commander.org/ticket/1919 I apparently fixed the Debian packaging bug in the latest release, although the file lists still need careful inspection. this one seems is fixed - directories have white color now. -- Janek Kozicki | attachment: scr_2842.png___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Fwd: Re: memory leak with quick view]
Janek Kozicki said: (by the date of Sun, 3 Jan 2010 14:40:57 +0100) Also, since in patch description you assumed that it goes wrong when used without utf8, I checked this - and I have found a way to workaround this patch. I only need to: LANG=POSIX Then it is not messed up, and looks like on attached screenshot. I want to report an undefined behaviour: The LANG=POSIX workaround works about 50% of tries. I just open an xterm, and type: LANG=POSIX mc That's really weird. Also I tried this on mc without your proposed patch. Same behaviour. Even more weird is that I can get following: $ LANG=POSIX mc # here it works, so F10, quit mc, and run it again in same xterm: $ LANG=POSIX mc # now it doesn't work -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Fwd: Re: memory leak with quick view]
Yury V. Zaytsev said: (by the date of Mon, 21 Dec 2009 13:17:49 +0100) Hi! On Mon, 2009-12-21 at 14:59 +0300, Andrew Borodin wrote: On Sun, 20 Dec 2009 16:30:48 +0100 Janek Kozicki wrote: Those problems are still present. Do I need to select some other skin? - gray directory names (not white) This works for me. Probably there's a problem with the color palette of your terminal emulator. I created a separate user account to be sure that there isn't any leftover configuration. And I can reproduce this bug in text console (not under X), and also under xterm launched without any extra arguments. Both under a fresh user account. - quick view on binary files breaks display It's known bug. The viewer in panel is created with wrong coordinates and sizes. I could reproduce it with LANG=C mc and quick view on the left panel. Care to post the ticket number? Sly Ilia didn't seem to be able to reproduce it yesterday??? In fact I'm unable to create a condition when those two bugs do not appear :) Otherwise I would be able to tell you how to fix it, and that would help you to identify the bug. best regards -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: memory leak with quick view
OK, I've tested this. In 4.7.0-pre4-206-g8791773 this bug does not exist. But I cannot use this version (I even made a debian package of it), because the skins are broken and mc looks really terrible. +--- Warning + | Unable to load 'default' skin. | | Default skin has been loaded | ++ Can you tell me what was the fix, so that I could apply the patch to an older debian version and fix the memory leak? Or eventually how to fix the skin problem, but I suppose that it is debian specific (the location of skins, etc). best regards -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: memory leak with quick view
Yury V. Zaytsev said: (by the date of Fri, 11 Dec 2009 22:09:23 +0100) Check out the trac for the instructions: http://www.midnight-commander.org/ The latest package snapshot can be found here: http://svn.debian.org/viewsvn/pkg-mc/ thanks, time limited, but I hope to check this tomorrow. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
memory leak with quick view
Hi, GNU Midnight Commander 4.7.0-pre1 Did anybody already report the memory leak with C-x q Quick view after you resize terminal window? Maybe that's already fixed, and my mc version is just too old? To see this error, you need to quick view on a big .xml file, then resize the terminal window few times. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: utf8 and mc
3. patch -p0 ./mc-4.6.2-utf8.patch patch -p0 ./mc-4.6.2-utf8.patch :) -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: mc alt-o vs. alt-i, alt-o
Zsolt said: (by the date of Sun, 25 Jan 2009 15:48:01 +0100) mc 4.6.1 version in alt-o function is very good, but mc 4.6.2pre1 version in alt-o function is change a very old function. heh, I never known that alt-o and alt-i are doing anything. I have 4.6.2 and alt-o shows content of currently highlighted dir in another panel. alt-i seems to open current dir in another panel. I wonder what they were doing in 4.6.1 ? -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: automatic symlink maintenance
Enrico Weigelt said: (by the date of Sat, 3 Jan 2009 16:56:24 +0100) * Janek Kozicki janek_li...@wp.pl schrieb: * Janek Kozicki janek_li...@wp.pl schrieb: Would you be so kind to consider my feature request? http://mail.gnome.org/archives/mc-devel/2008-November/msg3.html IMHO, such a feature clearly doesn't belong into mc itself - it's a filesystem issue ;-P You are right! Thanks, it never occurred to me. I'm going to ask ext3 developers about that. Filesystem doesnt necessarily mean disk-filesystem. It's a job for some overlaying FS. (9P is your friend ;-P) I checked 9P. It's a nice stuff, but in reality I don't see it in near future on my stock debian testing desktop. To the contrary patching mc to add this feature is quite possible and much simpler, from my standpoint. It's just a simple symlink tracking it can't be *that* difficult... Maybe, just maybe, I'll be able to produce a patch for that, together with a friend of mine, would you guys be willing to add such a patch to the trunk? PS: I'm very happy to see mc development flourishing again! -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: mcedit - fancy tab handling
Enrico Weigelt said: (by the date of Mon, 5 Jan 2009 19:22:25 +0100) Hi folks, I've just seen that current mcedit (from git tree) has some fancy tab handling (shows -- symbols). When had this been introduced ? I noticed this after upgrading debian etch to lenny. I like it, but sometimes it's inconvenient when I want to copy/paste with mouse. (using shift-mouseclicks) The best if there's a way to turn it on/off. And if it's somewhere easily accessible with menu/shortcuts. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: automatic symlink maintenance [WAS: Removing myself from the project]
Enrico Weigelt said: (by the date of Fri, 26 Dec 2008 02:47:33 +0100) * Janek Kozicki janek_li...@wp.pl schrieb: Would you be so kind to consider my feature request? http://mail.gnome.org/archives/mc-devel/2008-November/msg3.html IMHO, such a feature clearly doesn't belong into mc itself - it's a filesystem issue ;-P You are right! Thanks, it never occurred to me. I'm going to ask ext3 developers about that. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Happy New Year
Slava Zanko said: (by the date of Wed, 31 Dec 2008 11:58:35 +0200) Happy New Year, have enough money and happiness to you and your family. aww, man. Thanks. I'm as happy with my wife and three daughters that I had never imagined I would be. Now if only I could get some (more) money -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Removing myself from the project
Patrick Winnertz said: (by the date of Wed, 17 Dec 2008 20:07:46 +0100) Hey Pavel, Could you please be so kind and add me to the list of people who are allowed to commit into the cvs? I would like to work further on mc and integrate patches from the mc clone into mc. It would be very sad if mc will die out. wow! I'm very happy that there is an active contributor coming in! Would you be so kind to consider my feature request? http://mail.gnome.org/archives/mc-devel/2008-November/msg3.html until your message I was seriously worried that mc is dead already. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Further Midnight Commander development
Slava Zanko said: (by the date of Thu, 18 Dec 2008 02:23:07 +0200) Alex Custov Andrew Savchenko Denis Frolov Dmitry Korzhevin Pavel Vasil'ev Slava Zanko Isn't Patrick Winnertz part of your newly formed development team? I guess that he wants to be! He just asked for write access to CVS. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
