Re: [PATCH] space on prompt bugfix

2005-03-21 Thread buc
Jindrich Novy wrote:
I did two patches to fix it so that you can decide which one is better
commit candidate.
Patch1:
Allows an user to type leading spaces on the command prompt, but when
enter is pressed, it tests whether the user typed at least something
except spaces. In case it finds only spaces, it deletes them from the
command prompt and let the enter be further processed.
Patch2:
Doesn't let the user to type leading spaces if he didn't write a non-
space letter already.
 

IMHO, patch1 is better way. Else end user can decide the space key is 
not working ...

--
Dmitry Butskoj [EMAIL PROTECTED]
Saint-Petersburg, Russia

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: [PATCH] space on prompt bugfix

2005-03-21 Thread buc
Jindrich Novy wrote:
IMHO, patch1 is better way. Else end user can decide the space key is 
not working ...
   

Yes, the spacebar won't be working for leading spaces. However, typing
the leading spaces in the command prompt IMHO doesn't make too much
sense to me so maybe after patch2 is applied we may use the spacebar as
an equivalent of Ins for selecting files/dirs as usual in other
filemanagers when nothing is actually typed in the command prompt.
That is a slight advantage of the second patch so please let me know if
you like/dislike the idea so that I can do another patch for this or
simply be happy with the patch1.
 

Intuitively, the MC can be perceived as a screen extension to shell 
(which became possible due to ncurses/slang lib and Ctr/Fn/Alt/Meta 
keyboard features). Therefore, MC`s cmdline should be closer to a shell 
command line, rather than a screen application input field.
  Currently, we have only one printable character -- Tab -- which 
behaves unser MC and a shell differently (and it is reasonable). But 
don`t add space to this list!
  There are a lot of keyboard buttons, modifier keys etc. to do things 
easy -- let MC cmdline be a true command line.

--
Dmitry Butskoj [EMAIL PROTECTED]
Saint-Petersburg, Russia

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: [RFE][PATCH] Allow cd smb://, cd sh://, cd mc:// vfs requests

2005-02-07 Thread buc
Jindrich Novy wrote:
Hi,
since we can access ftp filesystems either like cd /#ftp: or more
intuitively like cd ftp:// it's not a bad idea IMNSHO to add such
extensions also for other filesystems. The attached patch implements
such an extension and it makes vfs_translate_url() more comprehensive in
the way that the aliases are kept in a separate table. strip_password()
is modified to take the change in account.
Cheers,
Jindrich
 

Jindrich,
 As you have already touched this part of the code, think about one 
more feature: replace /#ftp-like prefixes to ftp://-like on command 
line substitution (%d, %D,  M-Enter, etc.)
  In most cases such substitution is used to form an argument of a 
command, i.e. rmp -i %D/%F, or lynx -dump %D . Currently, only 
internal cd command can eat /#ftp: . 
 An ideal variant is: internal cd can handel both mc and general 
form, command line substitution should mostly use general form.

 I have a patch (written some years ago) for ftp://; case...
--
Dmitry Butskoj [EMAIL PROTECTED]
Saint-Petersburg, Russia
Red Hat Certified Engineer 809003662809495
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: [RFE][PATCH] Allow cd smb://, cd sh://, cd mc:// vfs requests

2005-02-07 Thread buc
Jindrich Novy wrote:
Hello Dmitry,
I only wanted to propose a more intuitive way to access various VFSes to
the most of users and to let them use the functionality ASAP. Some
further work to let them make their life with mc more comfortable is
welcome so if you have any pending patches similar to this problem, no
one will be angry if you send them here ;)
Cheers,
Jindrich
My old patch attached. It locates the place where something should be 
done now, not for ftp only...

--
Dmitry Butskoj [EMAIL PROTECTED]
Saint-Petersburg, Russia
Red Hat Certified Engineer 809003662809495
diff -Nrbu mc-4.6.0/src/util.c mc-4.6.0-OK/src/util.c
--- mc-4.6.0/src/util.c	2003-11-13 18:25:13.0 +0300
+++ mc-4.6.0-OK/src/util.c	2003-11-13 18:22:23.0 +0300
@@ -186,6 +186,13 @@
 	*d++ = '.';
 	*d++ = '/';
 }
+else if (*s == '/'  s[1] == '#' 
+	 !strncmp (s, /#ftp:, 6)
+) {
+	strcpy (d, ftp://;);
+	s += 6;
+	d += 6;
+}
 
 for (; *s; s++, d++) {
 	switch (*s) {
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: Restoring the functionality of Alt-o

2005-02-02 Thread buc
Leonard den Ottolander wrote:
Hi Miguel,
On Mon, 2005-01-31 at 15:51, Miguel de Icaza wrote:
 

I will make it a configuration feature, and restore the old behavior by
default.
   

Maybe keep the new behaviour the default? You seem to be the only one
still remembering the old behaviour ;-).
Leonard.
 

I remeber it too! :-)  (And my users actually use it!)
But I not against if it will be a new behavior as default...
--
Dmitry Butskoj [EMAIL PROTECTED]
Saint-Petersburg, Russia
Red Hat Certified Engineer 809003662809495
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel