Re: [Midnight Commander] #113: savannah: make tabs and trailing spaces visible
#113: savannah: make tabs and trailing spaces visible -+-- Reporter: slavazanko | Owner: slavazanko Type: defect | Status: accepted Priority: major | Milestone: Component: mcedit | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: -+-- Changes (by slavazanko): * owner: = slavazanko * status: new = accepted -- Ticket URL: www.midnight-commander.org/ticket/113#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #113: savannah: make tabs and trailing spaces visible
#113: savannah: make tabs and trailing spaces visible -+-- Reporter: slavazanko | Owner: slavazanko Type: defect | Status: testing Priority: major | Milestone: Component: mcedit | Version: 4.6.1 Resolution: fixed |Keywords: review Blocking: | Blockedby: -+-- Changes (by slavazanko): * status: accepted = testing * resolution: = fixed Comment: Visibility of tabs and spaces already present. -- Ticket URL: www.midnight-commander.org/ticket/113#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #113: savannah: make tabs and trailing spaces visible
#113: savannah: make tabs and trailing spaces visible -+-- Reporter: slavazanko | Owner: Type: defect | Status: new Priority: major | Milestone: Component: mcedit | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: -+-- Changes (by metux): * keywords: = review -- Ticket URL: www.midnight-commander.org/ticket/113#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #113: savannah: make tabs and trailing spaces visible
#113: savannah: make tabs and trailing spaces visible
+---
Reporter: slavazanko | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: mc-core | Version: 4.6.1
Keywords: |Blocking:
Blockedby: |
+---
Original: http://savannah.gnu.org/bugs/?13146
||Submitted by:||Oswald Buddenhagen ossi||Submitted on:||Sat 21 May 2005
07:25:17 PM UTC||
||Category:||Editor||Severity:||3 - Normal||
||Status:||In Progress||Privacy:||Public||
||Assigned to:||None||Open/Closed:||Open||
||Release:||current (CVS or snapshot)||Operating System:||All||
Discussion:
{{{
Sun 06 Jul 2008 04:12:04 PM UTC, comment #24:
I noticed I cannot just use the Unicode characters (like p-ch = 0xB7), as
that does not take into account terminals that are not in UTF-8. But the
fix is simple enough (p-ch = SLsmg_Is_Unicode ? 0xB7 : .).
BTW, I also implemented the MS Word-style tabs, i.e. printing a right-
arrow in the middle of a tab. I sort of prefer it over the tabs.
It is a patch that currently replaces the existing tab mechanism, but IMHO
this should all be made configurable once the maintainers decide to wake
up and give me some sort of ok...
(file #16007)
Jan Engelhardt hirogen2
Sun 06 Jul 2008 01:24:09 PM UTC, comment #23:
Patch #4 -- cedit-symbol-prefs.diff
This patch changes the space fill character to some Unicode dot (·) [this
one is also available on the text console], and makes the -- tab
filler into the Unicode ◀──▶ too.
(file #16006)
Jan Engelhardt hirogen2
Sun 06 Jul 2008 01:21:22 PM UTC, comment #22:
Patch #3 -- cedit-fix-whitespace.diff
We definitely need to set MOD_WHITESPACE or the space between tab stops is
drawn with some random color.
(file #16005)
Jan Engelhardt hirogen2
Sun 06 Jul 2008 01:19:54 PM UTC, comment #21:
Patch #2 -- cedit-eol-mark.diff
This patch implements comment #8's suggestion to use ¶ as an EOL marker.
It can be toggled using the OptionsHighlight options dialog, or, of
course, by editing ~/.mc/config directly.
(file #16004)
Jan Engelhardt hirogen2
Sun 06 Jul 2008 01:17:43 PM UTC, comment #20:
Ok since nobody replied here are some patches of my own.
They require that mc(edit) has COMPLETE support for UTF-8!, which is not
the case in the mc source distribution. The openSUSE .src.rpm has the
required utf8 bits. Will try to make them submit theirs.
Patch #1 -- cedit-configurable-highlight.diff
This is for comment #19; it allows to switch highlighting. Firstly, it
adds a dialog (Options Highlight options) where you can precisely select
what to highlight
[ ] Global syntax highlighting
[ ] Tab highlighting (those -- markers, which, btw, can get very
ugly if you have lots of code)
[ ] Whitespace highlighting (dots at the end-of-line, and, if tab
highlighting is disabled, anywhere on the line)
One can already toggle Syntax highlighting with Ctrl-S in mc 4.6.2, for
the latter two, I added Ctrl-V as a hotkey which cycles through the
possibilities. My personal preference is to have Tab highlight OFF and
Whitespace highlight ON.
(file #16003)
Jan Engelhardt hirogen2
Fri 29 Feb 2008 07:16:33 PM UTC, comment #19:
Oh, god... I just updated my Debian box, and I now run MC 4.6.2-pre1 (as
outputted by mcedit --version). It appears that this patch is included in
this version of mcedit. I really dislike it. Besides suffering from the
'cursor disappearing' thingy, I just think its ugly. But that's my humble
opinion :)
How can I disable it? The patches attached to this report don't seem to
make a new configurable parameter available in the configuration dialogs.
Jurrie Overgoor leadpumper
Tue 04 Sep 2007 05:29:40 AM UTC, comment #18:
Pavel, I applied your patch to vte-0.16.8. It works.
Andrew Borodin a_borodin
Mon 03 Sep 2007 01:15:42 PM UTC, comment #17:
Ok. I tracked the bug to vte_terminal_determine_colors() in the vte
package. To request brighter colors one forces the terminal into bold
mode. It seems that in this mode vte allows only the foreground color to
be bright. In vte's terms a bright color is the same color as the normal
one but with a special flag set. So what happens is that when the time
comes for the cursor to blink vte switches the current forground color
with the current background color and vice versa... As I said above
both colors are indentified in the same way but one has a special flag,
however vte uses this flag to brighten the foreground color so at the end
we end up as if nothing happened. It's hard to say whether this is the
desired behaviour .. I'll attach a simple patch which changes vte to do
what seems more logically correct... and I'll open a report in gnome's
Re: [Midnight Commander] #113: savannah: make tabs and trailing spaces visible
#113: savannah: make tabs and trailing spaces visible
-+--
Reporter: slavazanko | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: mc-core | Version: 4.6.1
Resolution: |Keywords:
Blocking: | Blockedby:
-+--
Description changed by slavazanko:
Old description:
Original: http://savannah.gnu.org/bugs/?13146
||Submitted by:||Oswald Buddenhagen ossi||Submitted on:||Sat 21 May
2005 07:25:17 PM UTC||
||Category:||Editor||Severity:||3 - Normal||
||Status:||In Progress||Privacy:||Public||
||Assigned to:||None||Open/Closed:||Open||
||Release:||current (CVS or snapshot)||Operating System:||All||
Discussion:
{{{
Sun 06 Jul 2008 04:12:04 PM UTC, comment #24:
I noticed I cannot just use the Unicode characters (like p-ch = 0xB7),
as that does not take into account terminals that are not in UTF-8. But
the fix is simple enough (p-ch = SLsmg_Is_Unicode ? 0xB7 : .).
BTW, I also implemented the MS Word-style tabs, i.e. printing a right-
arrow in the middle of a tab. I sort of prefer it over the tabs.
It is a patch that currently replaces the existing tab mechanism, but
IMHO this should all be made configurable once the maintainers decide to
wake up and give me some sort of ok...
(file #16007)
Jan Engelhardt hirogen2
Sun 06 Jul 2008 01:24:09 PM UTC, comment #23:
Patch #4 -- cedit-symbol-prefs.diff
This patch changes the space fill character to some Unicode dot (·) [this
one is also available on the text console], and makes the -- tab
filler into the Unicode ◀──▶ too.
(file #16006)
Jan Engelhardt hirogen2
Sun 06 Jul 2008 01:21:22 PM UTC, comment #22:
Patch #3 -- cedit-fix-whitespace.diff
We definitely need to set MOD_WHITESPACE or the space between tab stops
is drawn with some random color.
(file #16005)
Jan Engelhardt hirogen2
Sun 06 Jul 2008 01:19:54 PM UTC, comment #21:
Patch #2 -- cedit-eol-mark.diff
This patch implements comment #8's suggestion to use ¶ as an EOL marker.
It can be toggled using the OptionsHighlight options dialog, or, of
course, by editing ~/.mc/config directly.
(file #16004)
Jan Engelhardt hirogen2
Sun 06 Jul 2008 01:17:43 PM UTC, comment #20:
Ok since nobody replied here are some patches of my own.
They require that mc(edit) has COMPLETE support for UTF-8!, which is not
the case in the mc source distribution. The openSUSE .src.rpm has the
required utf8 bits. Will try to make them submit theirs.
Patch #1 -- cedit-configurable-highlight.diff
This is for comment #19; it allows to switch highlighting. Firstly, it
adds a dialog (Options Highlight options) where you can precisely
select what to highlight
[ ] Global syntax highlighting
[ ] Tab highlighting (those -- markers, which, btw, can get very
ugly if you have lots of code)
[ ] Whitespace highlighting (dots at the end-of-line, and, if tab
highlighting is disabled, anywhere on the line)
One can already toggle Syntax highlighting with Ctrl-S in mc 4.6.2, for
the latter two, I added Ctrl-V as a hotkey which cycles through the
possibilities. My personal preference is to have Tab highlight OFF and
Whitespace highlight ON.
(file #16003)
Jan Engelhardt hirogen2
Fri 29 Feb 2008 07:16:33 PM UTC, comment #19:
Oh, god... I just updated my Debian box, and I now run MC 4.6.2-pre1 (as
outputted by mcedit --version). It appears that this patch is included in
this version of mcedit. I really dislike it. Besides suffering from the
'cursor disappearing' thingy, I just think its ugly. But that's my humble
opinion :)
How can I disable it? The patches attached to this report don't seem to
make a new configurable parameter available in the configuration dialogs.
Jurrie Overgoor leadpumper
Tue 04 Sep 2007 05:29:40 AM UTC, comment #18:
Pavel, I applied your patch to vte-0.16.8. It works.
Andrew Borodin a_borodin
Mon 03 Sep 2007 01:15:42 PM UTC, comment #17:
Ok. I tracked the bug to vte_terminal_determine_colors() in the vte
package. To request brighter colors one forces the terminal into bold
mode. It seems that in this mode vte allows only the foreground color to
be bright. In vte's terms a bright color is the same color as the normal
one but with a special flag set. So what happens is that when the time
comes for the cursor to blink vte switches the current forground color
with the current background color and vice versa... As I said above
both colors are indentified in the same way but one has a special flag,
however vte uses this flag to brighten the foreground color so at the end
we end up as if nothing happened. It's hard to say whether this is the
desired behaviour .. I'll attach a simple patch which changes vte
